linux.git/fs/ceph, branch v3.2-rc7

ceph: add missing spin_unlock at ceph_mdsc_build_path()

2011-12-13T19:59:53+00:00

one of the paths was missing spin_unlock

Signed-off-by: Yehuda Sadeh

ceph: fix SEEK_CUR, SEEK_SET regression

2011-12-13T17:19:26+00:00

Commit 06222e491e663dac939f04b125c9dc52126a75c4 got the if wrong so that
it always evaluates as true.  This is semantically harmless, but makes
SEEK_CUR and SEEK_SET needlessly query the server.

Rewrite the if to explicitly enumerate the cases we DO need a valid i_size
to make this code less fragile.

Reported-by: Roel Kluin 
Signed-off-by: Sage Weil

ceph: use i_ceph_lock instead of i_lock

2011-12-07T18:46:44+00:00

We have been using i_lock to protect all kinds of data structures in the
ceph_inode_info struct, including lists of inodes that we need to iterate
over while avoiding races with inode destruction.  That requires grabbing
a reference to the inode with the list lock protected, but igrab() now
takes i_lock to check the inode flags.

Changing the list lock ordering would be a painful process.

However, using a ceph-specific i_ceph_lock in the ceph inode instead of
i_lock is a simple mechanical change and avoids the ordering constraints
imposed by igrab().

Reported-by: Amon Ott 
Signed-off-by: Sage Weil

ceph: fix rasize reporting by ceph_show_options

2011-12-02T17:27:54+00:00

Fix typo.

Reported-by: mowang da 
Signed-off-by: Sage Weil

ceph: initialize root dentry

2011-11-11T17:50:17+00:00

Set up d_fsdata on the root dentry.  This fixes a NULL pointer dereference
in ceph_d_prune on umount.  It also means we can eventually strip out all
of the conditional checks on d_fsdata because it is now set unconditionally
(prior to setting up the d_ops).

Fix the ceph_d_prune debug print while we're here.

Signed-off-by: Sage Weil

ceph: fix iput race when queueing inode work

2011-11-06T05:06:31+00:00

If we queue a work item that calls iput(), make sure we ihold() before
attempting to queue work. Otherwise our queued work might miraculously run
before we notice the queue_work() succeeded and call ihold(), allowing the
inode to be destroyed.

That is, instead of

	if (queue_work(...))
		ihold();

we need to do

	ihold();
	if (!queue_work(...))
		iput();

Reported-by: Amon Ott 
Signed-off-by: Sage Weil

ceph/super.c: quiet sparse noise

2011-11-06T04:10:12+00:00

Quiet the sparse noise:

warning: symbol 'create_fs_client' was not declared. Should it be static?
warning: symbol 'destroy_fs_client' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten 
Cc: Sage Weil 
ceph-devel@vger.kernel.org
Signed-off-by: Sage Weil

ceph/mds_client.c: quiet sparse noise

2011-11-06T04:10:11+00:00

Quiet the following sparse noise:

warning: symbol 'get_nonsnap_parent' was not declared. Should it be static?
warning: symbol 'done_closing_sessions' was not declared. Should it be static?

Local functions don't need external visability. Make them static.

Signed-off-by: H Hartley Sweeten 
Cc: Sage Weil 
Signed-off-by: Sage Weil

ceph: use new D_COMPLETE dentry flag

2011-11-06T04:10:10+00:00

We used to use a flag on the directory inode to track whether the dcache
contents for a directory were a complete cached copy.  Switch to a dentry
flag CEPH_D_COMPLETE that is safely updated by ->d_prune().

Signed-off-by: Sage Weil

ceph: clear parent D_COMPLETE flag when on dentry prune

2011-11-03T16:23:49+00:00

When the VFS prunes a dentry from the cache, clear the D_COMPLETE flag
on the parent dentry.  Do this for the live and snapshotted namespaces. Do
not bother for the .snap dir contents, since we do not cache that.

Signed-off-by: Sage Weil