linux.git/fs/ceph, branch v3.0-rc5

ceph: unwind canceled flock state

2011-06-08T04:36:45+00:00

If we request a lock and then abort (e.g., ^C), we need to send a matching
unlock request to the MDS to unwind our lock attempt to avoid indefinitely
blocking other clients.

Reported-by: Brian Chrisman 
Signed-off-by: Sage Weil

ceph: fix ENOENT logic in striped_read

2011-06-08T04:34:16+00:00

Getting ENOENT is equivalent to reading 0 bytes.  Make that correction
before setting up the hit_stripe and was_short flags.

Fixes the following case:
 dd if=/dev/zero of=/mnt/fs_depot/dd3 bs=1 seek=1048576 count=0
 dd if=/mnt/fs_depot/dd3 of=/root/ddout1 skip=8 bs=500 count=2 iflag=direct

Reported-by: Henry C Chang 
Signed-off-by: Sage Weil

ceph: fix short sync reads from the OSD

2011-06-08T04:34:14+00:00

If we get a short read from the OSD because the object is small, we need to
zero the remainder of the buffer.  For O_DIRECT reads, the attempted range
is not trimmed to i_size by the VFS, so we were actually looping
indefinitely.

Fix by trimming by i_size, and the unconditionally zeroing the trailing
range.

Reported-by: Jeff Wu 
Signed-off-by: Sage Weil

ceph: use ihold when we already have an inode ref

2011-06-08T04:34:11+00:00

We should use ihold whenever we already have a stable inode ref, even
when we aren't holding i_lock.  This avoids adding new and unnecessary
locking dependencies.

Signed-off-by: Sage Weil

ceph: fix cap flush race reentrancy

2011-05-24T18:52:12+00:00

In e9964c10 we change cap flushing to do a delicate dance because some
inodes on the cap_dirty list could be in a migrating state (got EXPORT but
not IMPORT) in which we couldn't actually flush and move from
dirty->flushing, breaking the while (!empty) { process first } loop
structure.  It worked for a single sync thread, but was not reentrant and
triggered infinite loops when multiple syncers came along.

Instead, move inodes with dirty to a separate cap_dirty_migrating list
when in the limbo export-but-no-import state, allowing us to go back to
the simple loop structure (which was reentrant).  This is cleaner and more
robust.

Audited the cap_dirty users and this looks fine:
list_empty(&ci->i_dirty_item) is still a reliable indicator of whether we
have dirty caps (which list we're on is irrelevant) and list_del_init()
calls still do the right thing.

Signed-off-by: Sage Weil

ceph: avoid inode lookup on nfs fh reconnect

2011-05-24T18:52:06+00:00

If we get the inode from the MDS, we have a reference in req; don't do a
fresh lookup.

Signed-off-by: Sage Weil

ceph: use LOOKUPINO to make unconnected nfs fh more reliable

2011-05-24T18:52:05+00:00

If we are unable to locate an inode by ino, ask the MDS using the new
LOOKUPINO command.

Signed-off-by: Sage Weil

ceph: check return value for start_request in writepages

2011-05-19T18:25:05+00:00

Since we pass the nofail arg, we should never get an error; BUG if we do.
(And fix the function to not return an error if __map_request fails.)

Signed-off-by: Sage Weil

ceph: remove useless check

2011-05-19T18:25:05+00:00

rc is only ever 0 or negative in this method.

Signed-off-by: Sage Weil

ceph: fix broken comparison in readdir loop

2011-05-19T18:25:04+00:00

Both off and fi->offset are unsigned, so the difference is always >= 0.
Compare them directly instead of the sign of the difference.

Signed-off-by: Sage Weil