linux.git/fs/ceph/file.c, branch v5.13

ceph: fix error handling in ceph_atomic_open and ceph_lookup

2021-06-22T11:53:28+00:00

Commit aa60cfc3f7ee broke the error handling in these functions such
that they don't handle non-ENOENT errors from ceph_mdsc_do_request
properly.

Move the checking of -ENOENT out of ceph_handle_snapdir and into the
callers, and if we get a different error, return it immediately.

Fixes: aa60cfc3f7ee ("ceph: don't use d_add in ceph_handle_snapdir")
Signed-off-by: Jeff Layton 
Reviewed-by: Ilya Dryomov 
Signed-off-by: Ilya Dryomov

ceph: must hold snap_rwsem when filling inode for async create

2021-06-22T11:53:28+00:00

...and add a lockdep assertion for it to ceph_fill_inode().

Cc: stable@vger.kernel.org # v5.7+
Fixes: 9a8d03ca2e2c3 ("ceph: attempt to do async create when possible")
Signed-off-by: Jeff Layton 
Reviewed-by: Ilya Dryomov 
Signed-off-by: Ilya Dryomov

ceph: drop pinned_page parameter from ceph_get_caps

2021-04-27T21:52:23+00:00

All of the existing callers that don't set this to NULL just drop the
page reference at some arbitrary point later in processing. There's no
point in keeping a page reference that we don't use, so just drop the
reference immediately after checking the Uptodate flag.

Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: avoid counting the same request twice or more

2021-04-27T21:52:23+00:00

If the request will retry, skip updating the latency metric.

Signed-off-by: Xiubo Li 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: rename the metric helpers

2021-04-27T21:52:23+00:00

Signed-off-by: Xiubo Li 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: don't use d_add in ceph_handle_snapdir

2021-04-27T21:52:23+00:00

It's possible ceph_get_snapdir could end up finding a (disconnected)
inode that already exists in the cache. Change the prototype for
ceph_handle_snapdir to return a dentry pointer and have it use
d_splice_alias so we don't end up with an aliased dentry in the cache.

Reported-by: Al Viro 
Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

libceph, rbd, ceph: "blacklist" -> "blocklist"

2020-10-12T13:29:26+00:00

Signed-off-by: Ilya Dryomov

ceph: add ceph_sb_to_mdsc helper support to parse the mdsc

2020-10-12T13:29:26+00:00

This will help simplify the code.

[ jlayton: fix minor merge conflict in quota.c ]

Signed-off-by: Xiubo Li 
Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: drop special-casing for ITER_PIPE in ceph_sync_read

2020-10-12T13:29:26+00:00

This special casing was added in 7ce469a53e71 (ceph: fix splice
read for no Fc capability case). The confirm callback for ITER_PIPE
expects that the page is Uptodate and returns an error otherwise.

A simpler workaround is just to use the Uptodate bit, which has no
meaning for anonymous pages. Rip out the special casing for ITER_PIPE
and just SetPageUptodate before we copy to the iter.

Cc: John Hubbard 
Suggested-by: Al Viro 
Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: remove unnecessary return in switch statement

2020-10-12T13:29:26+00:00

Since there's a return immediately after the 'break', there's no need for
this extra 'return' in the S_IFDIR case.

Signed-off-by: Luis Henriques 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov