linux.git/fs/ceph/file.c, branch v4.17

ceph: fix iov_iter issues in ceph_direct_read_write()

2018-05-10T08:15:12+00:00

dio_get_pagev_size() and dio_get_pages_alloc() introduced in commit
b5b98989dc7e ("ceph: combine as many iovec as possile into one OSD
request") assume that the passed iov_iter is ITER_IOVEC.  This isn't
the case with splice where it ends up poking into the guts of ITER_BVEC
or ITER_PIPE iterators, causing lockups and crashes easily reproduced
with generic/095.

Rather than trying to figure out gap alignment and stuff pages into
a page vector, add a helper for going from iov_iter to a bio_vec array
and make use of the new CEPH_OSD_DATA_TYPE_BVECS code.

Fixes: b5b98989dc7e ("ceph: combine as many iovec as possile into one OSD request")
Link: http://tracker.ceph.com/issues/18130
Signed-off-by: Ilya Dryomov 
Reviewed-by: Jeff Layton 
Reviewed-by: "Yan, Zheng" 
Tested-by: Luis Henriques

ceph: fix rsize/wsize capping in ceph_direct_read_write()

2018-05-10T08:15:00+00:00

rsize/wsize cap should be applied before ceph_osdc_new_request() is
called.  Otherwise, if the size is limited by the cap instead of the
stripe unit, ceph_osdc_new_request() would setup an extent op that is
bigger than what dio_get_pages_alloc() would pin and add to the page
vector, triggering asserts in the messenger.

Cc: stable@vger.kernel.org
Fixes: 95cca2b44e54 ("ceph: limit osd write size")
Signed-off-by: Ilya Dryomov 
Reviewed-by: "Yan, Zheng"

ceph: quota: update MDS when max_bytes is approaching

2018-04-02T09:17:52+00:00

When we're reaching the ceph.quota.max_bytes limit, i.e., when writing
more than 1/16th of the space left in a quota realm, update the MDS with
the new file size.

This mirrors the fuse-client approach with commit 122c50315ed1 ("client:
Inform mds file size when approaching quota limit"), in the ceph git tree.

Signed-off-by: Luis Henriques 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: quota: support for ceph.quota.max_bytes

2018-04-02T09:17:52+00:00

Signed-off-by: Luis Henriques 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: quota: support for ceph.quota.max_files

2018-04-02T09:17:51+00:00

This patch adds support for the max_files quota.  It hooks into all the
ceph functions that add new filesystem objects that need to be checked
against the quota limits.  When these limits are hit, -EDQUOT is returned.

Note that we're not checking quotas on ceph_link().  ceph_link doesn't
really create a new inode,  and since the MDS doesn't update the directory
statistics when a new (hard) link is created (only with symlinks), they
are not accounted as a new file.

Signed-off-by: Luis Henriques 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: optimize memory usage

2018-04-02T08:12:49+00:00

In current code, regular file and directory use same struct
ceph_file_info to store fs specific data so the struct has to
include some fields which are only used for directory
(e.g., readdir related info), when having plenty of regular files,
it will lead to memory waste.

This patch introduces dedicated ceph_dir_file_info cache for
readdir related thins. So that regular file does not include those
unused fields anymore.

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: filter out used flags when printing unused open flags

2018-04-02T08:12:48+00:00

Filter out used access mode flags when printing unused open flags.

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: change variable name to follow common rule

2018-04-02T08:12:47+00:00

Variable name ci is mostly used for ceph_inode_info.
Variable name fi is mostly used for ceph_file_info.
Variable name cf is mostly used for ceph_cap_flush.

Change variable name to follow above common rules
in case of confusing.

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: add newline to end of debug message format

2018-04-02T08:12:44+00:00

Some of dout format do not include newline in the end,
fix for the files which are in fs/ceph and net/ceph directories,
and changing printk to dout for printing debug info in super.c

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: only dirty ITER_IOVEC pages for direct read

2018-03-30T09:17:48+00:00

If a page is already locked, attempting to dirty it leads to a deadlock
in lock_page().  This is what currently happens to ITER_BVEC pages when
a dio-enabled loop device is backed by ceph:

  $ losetup --direct-io /dev/loop0 /mnt/cephfs/img
  $ xfs_io -c 'pread 0 4k' /dev/loop0

Follow other file systems and only dirty ITER_IOVEC pages.

Cc: stable@kernel.org
Signed-off-by: "Yan, Zheng" 
Reviewed-by: Ilya Dryomov 
Signed-off-by: Ilya Dryomov