linux.git/fs/ceph/addr.c, branch v5.14

ceph: add IO size metrics support

2021-06-28T22:15:51+00:00

This will collect IO's total size and then calculate the average
size, and also will collect the min/max IO sizes.

The debugfs will show the size metrics in bytes and will let the
userspace applications to switch to what they need.

URL: https://tracker.ceph.com/issues/49913
Signed-off-by: Xiubo Li 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: make ceph_netfs_read_ops static

2021-06-28T21:49:24+00:00

The sparse tool complains as follows:

fs/ceph/addr.c:316:37: warning:
 symbol 'ceph_netfs_read_ops' was not declared. Should it be static?

This symbol is not used outside of addr.c, so mark it static.

Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
Reviewed-by: Ilya Dryomov 
Signed-off-by: Ilya Dryomov

ceph: remove bogus checks and WARN_ONs from ceph_set_page_dirty

2021-06-28T21:49:24+00:00

The checks for page->mapping are odd, as set_page_dirty is an
address_space operation, and I don't see where it would be called on a
non-pagecache page.

The warning about the page lock also seems bogus.  The comment over
set_page_dirty() says that it can be called without the page lock in
some rare cases. I don't think we want to warn if that's the case.

Reported-by: Matthew Wilcox 
Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: convert some PAGE_SIZE invocations to thp_size()

2021-04-27T21:52:23+00:00

Start preparing to allow the use of THPs in the pagecache with ceph by
making it use thp_size() in lieu of PAGE_SIZE in the appropriate places.

Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: drop pinned_page parameter from ceph_get_caps

2021-04-27T21:52:23+00:00

All of the existing callers that don't set this to NULL just drop the
page reference at some arbitrary point later in processing. There's no
point in keeping a page reference that we don't use, so just drop the
reference immediately after checking the Uptodate flag.

Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: only check pool permissions for regular files

2021-04-27T21:52:23+00:00

There is no need to do a ceph_pool_perm_check() on anything that isn't a
regular file, as the MDS is what handles talking to the OSD in those
cases. Just return 0 if it's not a regular file.

Reported-by: Luis Henriques 
Signed-off-by: Jeff Layton 
Reviewed-by: Xiubo Li 
Signed-off-by: Ilya Dryomov

ceph: rename the metric helpers

2021-04-27T21:52:23+00:00

Signed-off-by: Xiubo Li 
Reviewed-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: use attach/detach_page_private for tracking snap context

2021-04-27T21:52:23+00:00

There is some ambiguity around the use of PagePrivate. It's
generally expected in core code that if PagePrivate is set then
you have a reference to it. It's not clear that ceph always
does (and I believe it may not).

Change ceph to use attach/detach_page_private so that we keep a
reference to the page until the snap context is detached.

Link: https://lore.kernel.org/ceph-devel/2503810.1616508988@warthog.procyon.org.uk/T/#mf29e5abbb0ec8035cde0de30778690de7d956f84
Reported-by: David Howells 
Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: convert ceph_readpages to ceph_readahead

2021-04-27T21:52:22+00:00

Convert ceph_readpages to ceph_readahead and make it use
netfs_readahead. With this we can rip out a lot of the old
readpage/readpages infrastructure.

Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov

ceph: convert ceph_write_begin to netfs_write_begin

2021-04-27T21:52:22+00:00

Convert ceph_write_begin to use the netfs_write_begin helper. Most of
the ops we need for it are already in place from the readpage conversion
but we do add a new check_write_begin op since ceph needs to be able to
vet whether there is an incompatible writeback already in flight before
reading in the page.

With this, we can also remove the old ceph_do_readpage helper.

Signed-off-by: Jeff Layton 
Signed-off-by: Ilya Dryomov