linux.git/fs/ceph/acl.c, branch v5.2

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 173

2019-05-30T18:26:40+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license v2 as published
  by the free software foundation this program is distributed in the
  hope that it will be useful but without any warranty without even
  the implied warranty of merchantability or fitness for a particular
  purpose see the gnu general public license for more details you
  should have received a copy of the gnu general public license along
  with this program if not write to the free software foundation inc
  59 temple place suite 330 boston ma 021110 1307 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 1 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Richard Fontana 
Reviewed-by: Kate Stewart 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070034.485313544@linutronix.de
Signed-off-by: Greg Kroah-Hartman

libceph: introduce ceph_pagelist_alloc()

2018-10-22T08:28:21+00:00

struct ceph_pagelist cannot be embedded into anything else because it
has its own refcount.  Merge allocation and initialization together.

Signed-off-by: Ilya Dryomov

ceph: check snap first in ceph_set_acl()

2018-10-22T08:28:20+00:00

Do the snap check first in ceph_set_acl(), so we can avoid
unnecessary operations when the inode has snap.

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: return errors from posix_acl_equiv_mode() correctly

2018-08-02T19:26:12+00:00

In order to return correct error code should replace variable ret
using err in error case.

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: restore ctime as well in the case of restoring old mode

2018-08-02T19:26:11+00:00

It's better to restore ctime as well in the case of restoring old mode
in ceph_set_acl().

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: add retry logic for error -ERANGE in ceph_get_acl()

2018-08-02T19:26:11+00:00

When the size of acl extended attribution is larger than pre-allocated
value buffer size, we will hit error '-ERANGE' and it's probabaly caused
by concurrent get/set acl from different clients. In this case, current
logic just sets acl to NULL so that we cannot get proper information but
the operation looks successful.

This patch adds retry logic for error -ERANGE and return -EIO if fail
from the retry. Additionally, print real errno when failing from
__ceph_getxattr().

Signed-off-by: Chengguang Xu 
Reviewed-by: "Yan, Zheng" 
Signed-off-by: Ilya Dryomov

ceph: unify inode i_ctime update

2017-06-14T17:37:23+00:00

Current __ceph_setattr() can set inode's i_ctime to current_time(),
req->r_stamp or attr->ia_ctime. These time stamps may have minor
differences. It may cause potential problem.

Signed-off-by: "Yan, Zheng" 
Acked-by: Arnd Bergmann 
Signed-off-by: Ilya Dryomov

ceph: Propagate dentry down to inode_change_ok()

2016-09-22T08:56:19+00:00

To avoid clearing of capabilities or security related extended
attributes too early, inode_change_ok() will need to take dentry instead
of inode. ceph_setattr() has the dentry easily available but
__ceph_setattr() is also called from ceph_set_acl() where dentry is not
easily available. Luckily that call path does not need inode_change_ok()
to be called anyway. So reorganize functions a bit so that
inode_change_ok() is called only from paths where dentry is available.

Reviewed-by: Christoph Hellwig 
Acked-by: Jeff Layton 
Signed-off-by: Jan Kara

posix_acl: Clear SGID bit when setting file permissions

2016-09-22T08:55:32+00:00

When file permissions are modified via chmod(2) and the user is not in
the owning group or capable of CAP_FSETID, the setgid bit is cleared in
inode_change_ok().  Setting a POSIX ACL via setxattr(2) sets the file
permissions as well as the new ACL, but doesn't clear the setgid bit in
a similar way; this allows to bypass the check in chmod(2).  Fix that.

References: CVE-2016-7097
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Jan Kara 
Signed-off-by: Andreas Gruenbacher

ceph: Get rid of d_find_alias in ceph_set_acl

2016-04-23T19:41:30+00:00

Create a variant of ceph_setattr that takes an inode instead of a
dentry.  Change __ceph_setxattr (and also __ceph_removexattr) to take an
inode instead of a dentry.  Use those in ceph_set_acl so that we no
longer need a dentry there.

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: "Yan, Zheng" 
Signed-off-by: Al Viro