linux.git/fs/btrfs/tests, branch v6.14

btrfs: selftests: fix btrfs_test_delayed_refs() leak of transaction

2025-02-17T16:24:14+00:00

The btrfs_transaction struct leaks, which can cause sporadic fstests
failures when kmemleak checking is enabled:

kmemleak: 5 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
> cat /sys/kernel/debug/kmemleak
unreferenced object 0xffff88810fdc6c00 (size 512):
  comm "modprobe", pid 203, jiffies 4294892552
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace (crc 6736050f):
    __kmalloc_cache_noprof+0x133/0x2c0
    btrfs_test_delayed_refs+0x6f/0xbb0 [btrfs]
    btrfs_run_sanity_tests.cold+0x91/0xf9 [btrfs]
    0xffffffffa02fd055
    do_one_initcall+0x49/0x1c0
    do_init_module+0x5b/0x1f0
    init_module_from_file+0x70/0x90
    idempotent_init_module+0xe8/0x2c0
    __x64_sys_finit_module+0x6b/0xd0
    do_syscall_64+0x54/0x110
    entry_SYSCALL_64_after_hwframe+0x76/0x7e

The transaction struct was initially stack-allocated but switched to
heap following frame size compiler warnings.

Fixes: 2b34879d97e27 ("btrfs: selftests: add delayed ref self test cases")
Signed-off-by: David Disseldorp 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: selftests: add a selftest for deleting two out of three extents

2025-01-14T14:57:55+00:00

Add a selftest creating three extents and then deleting two out of the
three extents.

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: add test for punching a hole into 3 RAID stripe-extents

2025-01-14T14:56:40+00:00

Test creating a range of three RAID stripe-extents and then punch a hole
in the middle, deleting all of the middle extents and partially deleting
the "book ends".

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: add selftest for punching holes into the RAID stripe extents

2025-01-14T14:54:45+00:00

Add a selftest for punching a hole into a RAID stripe extent. The test
create an 1M extent and punches a 64k bytes long hole at offset of 32k from
the start of the extent.

Afterwards it verifies the start and length of both resulting new extents
"left" and "right" as well as the absence of the hole.

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: test RAID stripe-tree deletion spanning two items

2025-01-14T14:54:44+00:00

Add a selftest for RAID stripe-tree deletion with a delete range spanning
two items, so that we're punching a hole into two adjacent RAID stripe
extents truncating the first and "moving" the second to the right.

The following diagram illustrates the operation:

 |--- RAID Stripe Extent ---||--- RAID Stripe Extent ---|
 |-----  keep  -----|--- drop ---|-----  keep  ----|

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: don't split RAID extents in half

2025-01-14T14:52:30+00:00

The selftests for partially deleting the start or tail of RAID
stripe-extents split these extents in half.

This can hide errors in the calculation, so don't split the RAID
stripe-extents in half but delete the first or last 16K of the 64K
extents.

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: check for correct return value of failed lookup

2025-01-14T14:52:30+00:00

Commit 5e72aabc1fff ("btrfs: return ENODATA in case RST lookup fails")
changed btrfs_get_raid_extent_offset()'s return value to ENODATA in case
the RAID stripe-tree lookup failed.

Adjust the test cases which check for absence of a given range to check
for ENODATA as return value in this case.

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: correct RAID stripe-tree feature flag setting

2025-01-14T14:47:54+00:00

RAID stripe-tree is an incompatible feature not a read-only compatible, so
set the incompat flag not a compat_ro one in the selftest code.

Subsequent changes in btrfs_delete_raid_extent() will start checking for
this flag.

Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: selftests: add delayed ref self test cases

2025-01-13T13:53:13+00:00

The recent fix for a stupid mistake I made uncovered the fact that we
don't have adequate testing in the delayed refs code, as it took a
pretty extensive and long running stress test to uncover something that
a unit test would have uncovered right away.

Fix this by adding a delayed refs self test suite.  This will validate
that the btrfs_ref transformation does the correct thing, that we do the
correct thing when merging delayed refs, and that we get the delayed
refs in the order that we expect.  These are all crucial to how the
delayed refs operate.

I introduced various bugs (including the original bug) into the delayed
refs code to validate that these tests caught all of the shenanigans
that I could think of.

Reviewed-by: Boris Burkov 
Signed-off-by: Josef Bacik 
Signed-off-by: David Sterba

btrfs: tests: implement case for partial RAID stripe-tree delete

2024-11-11T13:34:19+00:00

Implement self-tests for partial deletion of RAID stripe-tree entries.

These two new tests cover both the deletion of the front of a RAID
stripe-tree stripe extent as well as truncation of an item to make it
smaller.

Reviewed-by: Filipe Manana 
Signed-off-by: Johannes Thumshirn 
Signed-off-by: David Sterba