linux.git/fs/btrfs/relocation.c, branch v6.3

btrfs: use PAGE_{ALIGN, ALIGNED, ALIGN_DOWN} macro

2023-02-13T16:50:34+00:00

The header file linux/mm.h provides PAGE_ALIGN, PAGE_ALIGNED,
PAGE_ALIGN_DOWN macros. Use these macros to make code more
concise.

Signed-off-by: Yushan Zhou 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: split the bio submission path into a separate file

2022-12-05T17:00:57+00:00

The code used by btrfs_submit_bio only interacts with the rest of
volumes.c through __btrfs_map_block (which itself is a more generic
version of two exported helpers) and does not really have anything
to do with volumes.c.  Create a new bio.c file and a bio.h header
going along with it for the btrfs_bio-based storage layer, which
will grow even more going forward.

Also update the file with my copyright notice given that a large
part of the moved code was written or rewritten by me.

Reviewed-by: Josef Bacik 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: introduce a bitmap based csum range search function

2022-12-05T17:00:57+00:00

Although we have an existing function, btrfs_lookup_csums_range(), to
find all data checksums for a range, it's based on a btrfs_ordered_sum
list.

For the incoming RAID56 data checksum verification at RMW time, we don't
want to waste time by allocating temporary memory.

So this patch will introduce a new helper, btrfs_lookup_csums_bitmap().
It will use bitmap based result, which will be a perfect fit for later
RAID56 usage.

Signed-off-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: concentrate all tree block parentness check parameters into one structure

2022-12-05T17:00:56+00:00

There are several different tree block parentness check parameters used
across several helpers:

- level
  Mandatory

- transid
  Under most cases it's mandatory, but there are several backref cases
  which skips this check.

- owner_root
- first_key
  Utilized by most top-down tree search routine. Otherwise can be
  skipped.

Those four members are not always mandatory checks, and some of them are
the same u64, which means if some arguments got swapped compiler will
not catch it.

Furthermore if we're going to further expand the parentness check, we
need to modify quite some helpers just to add one more parameter.

This patch will concentrate all these members into a structure called
btrfs_tree_parent_check, and pass that structure for the following
helpers:

- btrfs_read_extent_buffer()
- read_tree_block()

Signed-off-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: pass btrfs_inode to btrfs_add_delayed_iput

2022-12-05T17:00:55+00:00

The function is for internal interfaces so we should use the
btrfs_inode.

Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: drop private_data parameter from extent_io_tree_init

2022-12-05T17:00:54+00:00

All callers except one pass NULL, so the parameter can be dropped and
the inode::io_tree initialization can be open coded.

Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: pass btrfs_inode to btrfs_inode_unlock

2022-12-05T17:00:53+00:00

The function is for internal interfaces so we should use the
btrfs_inode.

Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: pass btrfs_inode to btrfs_inode_lock

2022-12-05T17:00:53+00:00

The function is for internal interfaces so we should use the
btrfs_inode.

Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: use a structure to pass arguments to backref walking functions

2022-12-05T17:00:50+00:00

The public backref walking functions have quite a lot of arguments that
are passed down the call stack to find_parent_nodes(), the core function
of the backref walking code.

The next patches in series will need to add even arguments to these
functions that should be passed not only to find_parent_nodes(), but also
to other functions used by the later (directly or even lower in the call
stack).

So create a structure to hold all these arguments and state used by the
main backref walking function, find_parent_nodes(), and use it as the
argument for the public backref walking functions iterate_extent_inodes(),
btrfs_find_all_leafs() and btrfs_find_all_roots().

Signed-off-by: Filipe Manana 
Signed-off-by: David Sterba

btrfs: use a single argument for extent offset in backref walking functions

2022-12-05T17:00:50+00:00

The interface for find_parent_nodes() has two extent offset related
arguments:

1) One u64 pointer argument for the extent offset;

2) One boolean argument to tell if the extent offset should be ignored or
   not.

These are confusing, becase the extent offset pointer can be NULL and in
some cases callers pass a NULL value as a way to tell the backref walking
code to ignore offsets in file extent items (and simply consider all file
extent items that point to the target data extent).

The boolean argument was added in commit c995ab3cda3f ("btrfs: add a flag
to iterate_inodes_from_logical to find all extent refs for uncompressed
extents"), but it was never really necessary, it was enough if it could
find a way to get a NULL value passed to the "extent_item_pos" argument of
find_parent_nodes(). The arguments are also passed to functions called
by find_parent_nodes() and respective helper functions, which further
makes everything more complicated than needed.

Then we have several backref walking related functions that end up calling
find_parent_nodes(), either directly or through some other function that
they call, and for many we have to use an "extent_item_pos" (u64) argument
and a boolean "ignore_offset" argument too.

This is confusing and not really necessary. So use a single argument to
specify the extent offset, as a simple u64 and not as a pointer, but
using a special value of (u64)-1, defined as a documented constant, to
indicate when the extent offset should be ignored.

This is also preparation work for the upcoming patches in the series that
add other arguments to find_parent_nodes() and other related functions
that use it.

Signed-off-by: Filipe Manana 
Signed-off-by: David Sterba