linux.git/fs/btrfs/relocation.c, branch v4.13

btrfs: fix integer overflow in calc_reclaim_items_nr

2017-06-29T18:17:02+00:00

Dave Jones hit a WARN_ON(nr < 0) in btrfs_wait_ordered_roots() with
v4.12-rc6.  This was because commit 70e7af244 made it possible for
calc_reclaim_items_nr() to return a negative number.  It's not really a
bug in that commit, it just didn't go far enough down the stack to find
all the possible 64->32 bit overflows.

This switches calc_reclaim_items_nr() to return a u64 and changes everyone
that uses the results of that math to u64 as well.

Reported-by: Dave Jones 
Fixes: 70e7af2 ("Btrfs: fix delalloc accounting leak caused by u32 overflow")
Signed-off-by: Chris Mason 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: qgroup: Fix qgroup reserved space underflow by only freeing reserved ranges

2017-06-29T18:17:02+00:00

[BUG]
For the following case, btrfs can underflow qgroup reserved space
at an error path:
(Page size 4K, function name without "btrfs_" prefix)

         Task A                  |             Task B
----------------------------------------------------------------------
Buffered_write [0, 2K)           |
|- check_data_free_space()       |
|  |- qgroup_reserve_data()      |
|     Range aligned to page      |
|     range [0, 4K)          <<< |
|     4K bytes reserved      <<< |
|- copy pages to page cache      |
                                 | Buffered_write [2K, 4K)
                                 | |- check_data_free_space()
                                 | |  |- qgroup_reserved_data()
                                 | |     Range alinged to page
                                 | |     range [0, 4K)
                                 | |     Already reserved by A <<<
                                 | |     0 bytes reserved      <<<
                                 | |- delalloc_reserve_metadata()
                                 | |  And it *FAILED* (Maybe EQUOTA)
                                 | |- free_reserved_data_space()
                                      |- qgroup_free_data()
                                         Range aligned to page range
                                         [0, 4K)
                                         Freeing 4K
(Special thanks to Chandan for the detailed report and analyse)

[CAUSE]
Above Task B is freeing reserved data range [0, 4K) which is actually
reserved by Task A.

And at writeback time, page dirty by Task A will go through writeback
routine, which will free 4K reserved data space at file extent insert
time, causing the qgroup underflow.

[FIX]
For btrfs_qgroup_free_data(), add @reserved parameter to only free
data ranges reserved by previous btrfs_qgroup_reserve_data().
So in above case, Task B will try to free 0 byte, so no underflow.

Reported-by: Chandan Rajendra 
Signed-off-by: Qu Wenruo 
Reviewed-by: Chandan Rajendra 
Tested-by: Chandan Rajendra 
Signed-off-by: David Sterba

btrfs: qgroup: Introduce extent changeset for qgroup reserve functions

2017-06-29T18:17:02+00:00

Introduce a new parameter, struct extent_changeset for
btrfs_qgroup_reserved_data() and its callers.

Such extent_changeset was used in btrfs_qgroup_reserve_data() to record
which range it reserved in current reserve, so it can free it in error
paths.

The reason we need to export it to callers is, at buffered write error
path, without knowing what exactly which range we reserved in current
allocation, we can free space which is not reserved by us.

This will lead to qgroup reserved space underflow.

Reviewed-by: Chandan Rajendra 
Signed-off-by: Qu Wenruo 
Signed-off-by: David Sterba

Btrfs: replace tree->mapping with tree->private_data

2017-06-19T16:25:58+00:00

For extent_io tree's we have carried the address_mapping of the inode
around in the io tree in order to pull the inode back out for calling
into various tree ops hooks.  This works fine when everything that has
an extent_io_tree has an inode.  But we are going to remove the
btree_inode, so we need to change this.  Instead just have a generic
void * for private data that we can initialize with, and have all the
tree ops use that instead.  This had a lot of cascading changes but
should be relatively straightforward.

Signed-off-by: Josef Bacik 
Reviewed-by: Chandan Rajendra 
Reviewed-by: David Sterba 
[ minor reordering of the callback prototypes ]
Signed-off-by: David Sterba

btrfs: Make btrfs_orphan_add take btrfs_inode

2017-02-28T10:30:10+00:00

Signed-off-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: Make btrfs_drop_extent_cache take btrfs_inode

2017-02-28T10:30:08+00:00

Signed-off-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: all btrfs_delalloc_release_metadata take btrfs_inode

2017-02-28T10:30:07+00:00

Signed-off-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: Make btrfs_delalloc_reserve_metadata take btrfs_inode

2017-02-28T10:30:07+00:00

Signed-off-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: free-space-cache, clean up unnecessary root arguments

2017-02-17T11:03:56+00:00

The free space cache APIs accept a root but always use the tree root.

Also, btrfs_truncate_free_space_cache accepts a root AND an inode but
the inode always points to the root anyway, so let's just pass the inode.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: convert btrfs_inc_block_group_ro to accept fs_info

2017-02-17T11:03:56+00:00

btrfs_inc_block_group_ro is either passed the extent root or the dev
root, but it doesn't do anything with the dev tree.  Let's convert
to passing an fs_info and using the extent root.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba