linux.git/fs/btrfs/ordered-data.c, branch v6.5

btrfs: add a btrfs_finish_ordered_extent helper

2023-06-19T11:59:37+00:00

Add a helper to complete an ordered_extent without first doing a lookup.
The tracepoint cannot use the ordered_extent class as we also want to
print the range.

Reviewed-by: Johannes Thumshirn 
Reviewed-by: Josef Bacik 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: factor out a btrfs_queue_ordered_fn helper

2023-06-19T11:59:37+00:00

Factor out a helper to queue up an ordered_extent completion in a work
queue.  This new helper will later be used complete an ordered_extent
without first doing a lookup.

Reviewed-by: Johannes Thumshirn 
Reviewed-by: Josef Bacik 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: factor out a can_finish_ordered_extent helper

2023-06-19T11:59:37+00:00

Factor out a helper from btrfs_mark_ordered_io_finished that does the
actual per-ordered_extent work to check if we want to schedule an I/O
completion.  This new helper will later be used complete an
ordered_extent without first doing a lookup.

Reviewed-by: Johannes Thumshirn 
Reviewed-by: Josef Bacik 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: remove btrfs_add_ordered_extent

2023-06-19T11:59:36+00:00

All callers are gone now.

Reviewed-by: Johannes Thumshirn 
Reviewed-by: Josef Bacik 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: handle completed ordered extents in btrfs_split_ordered_extent

2023-06-19T11:59:33+00:00

To delay splitting ordered_extents to I/O completion time we need to be
able to handle fully completed ordered extents in
btrfs_split_ordered_extent.  Besides a bit of accounting this primarily
involved moving over the csums to the split bio for the range that it
covers, which is simple enough because we always have one
btrfs_ordered_sum per bio.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Signed-off-by: David Sterba

btrfs: atomically insert the new extent in btrfs_split_ordered_extent

2023-06-19T11:59:33+00:00

Currently there is a small race window in btrfs_split_ordered_extent,
where the reduced old extent can be looked up on the per-inode rbtree
or the per-root list while the newly split out one isn't visible yet.

Fix this by open coding btrfs_alloc_ordered_extent in
btrfs_split_ordered_extent, and holding the tree lock and
root->ordered_extent_lock over the entire tree and extent manipulation.

Note that this introduces new lock ordering because previously
ordered_extent_lock was never held over the tree lock.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: split btrfs_alloc_ordered_extent to allocation and insertion helpers

2023-06-19T11:59:33+00:00

Split two low-level helpers out of btrfs_alloc_ordered_extent to allocate
and insert the logic extent.  The pure alloc helper will be used to
improve btrfs_split_ordered_extent.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: return the new ordered_extent from btrfs_split_ordered_extent

2023-06-19T11:59:33+00:00

Return the ordered_extent split from the passed in one.  This will be
needed to be able to store an ordered_extent in the btrfs_bio.

Reviewed-by: Naohiro Aota 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: optimize the logical to physical mapping for zoned writes

2023-06-19T11:59:32+00:00

The current code to store the final logical to physical mapping for a
zone append write in the extent tree is rather inefficient.  It first has
to split the ordered extent so that there is one ordered extent per bio,
so that it can look up the ordered extent on I/O completion in
btrfs_record_physical_zoned and store the physical LBA returned by the
block driver in the ordered extent.

btrfs_rewrite_logical_zoned then has to do a lookup in the chunk tree to
see what physical address the logical address for this bio / ordered
extent is mapped to, and then rewrite it in the extent tree.

To optimize this process, we can store the physical address assigned in
the chunk tree to the original logical address and a pointer to
btrfs_ordered_sum structure the in the btrfs_bio structure, and then use
this information to rewrite the logical address in the btrfs_ordered_sum
structure directly at I/O completion time in btrfs_record_physical_zoned.
btrfs_rewrite_logical_zoned then simply updates the logical address in
the extent tree and the ordered_extent itself.

The code in btrfs_rewrite_logical_zoned now runs for all data I/O
completions in zoned file systems, which is fine as there is no remapping
to do for non-append writes to conventional zones or for relocation, and
the overhead for quickly breaking out of the loop is very low.

Because zoned file systems now need the ordered_sums structure to
record the actual write location returned by zone append, allocate dummy
structures without the csum array for them when the I/O doesn't use
checksums, and free them when completing the ordered_extent.

Note that the btrfs_bio doesn't grow as the new field are places into
a union that is so far not used for data writes and has plenty of space
left in it.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: fold btrfs_clone_ordered_extent into btrfs_split_ordered_extent

2023-04-17T16:01:21+00:00

The function btrfs_clone_ordered_extent is very specific to the usage in
btrfs_split_ordered_extent.  Now that only a single call to
btrfs_clone_ordered_extent is left, just fold it into
btrfs_split_ordered_extent to make the operation more clear.

Reviewed-by: Josef Bacik 
Tested-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig 
Signed-off-by: David Sterba