linux.git/fs/btrfs/ordered-data.c, branch v4.12

btrfs: convert btrfs_ordered_extent.refs from atomic_t to refcount_t

2017-04-18T12:07:23+00:00

refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.

Signed-off-by: Elena Reshetova 
Signed-off-by: Hans Liljestrand 
Signed-off-by: Kees Cook 
Signed-off-by: David Windsor 
Signed-off-by: David Sterba

btrfs: convert btrfs_transaction.use_count from atomic_t to refcount_t

2017-04-18T12:07:23+00:00

refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.

Signed-off-by: Elena Reshetova 
Signed-off-by: Hans Liljestrand 
Signed-off-by: Kees Cook 
Signed-off-by: David Windsor 
Signed-off-by: David Sterba

btrfs: Make btrfs_lookup_ordered_range take btrfs_inode

2017-02-28T10:30:08+00:00

Signed-off-by: Nikolay Borisov 
Signed-off-by: David Sterba

Btrfs: clean up btrfs_ordered_update_i_size

2017-02-14T14:50:58+00:00

Since we have a good helper entry_end, use it for ordered extent.

Signed-off-by: Liu Bo 
Reviewed-by: David Sterba 
[ whitespace reformatting ]
Signed-off-by: David Sterba

Btrfs: fix btrfs_ordered_update_i_size to update disk_i_size properly

2017-02-14T14:50:57+00:00

btrfs_ordered_update_i_size can be called by truncate and endio, but
only endio takes ordered_extent which contains the completed IO.

while truncating down a file, if there are some in-flight IOs,
btrfs_ordered_update_i_size in endio will set disk_i_size to
@orig_offset that is zero.  If truncating-down fails somehow, we try to
recover in memory isize with this zero'd disk_i_size.

Fix it by only updating disk_i_size with @orig_offset when
btrfs_ordered_update_i_size is not called from endio while truncating
down and waiting for in-flight IOs completing their work before recover
in-memory size.

Besides fixing the above issue, add an assertion for last_size to double
check we truncate down to the desired size.

Signed-off-by: Liu Bo 
Signed-off-by: David Sterba

btrfs: Make btrfs_get_logged_extents take btrfs_inode

2017-02-14T14:50:55+00:00

Signed-off-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: root->fs_info cleanup, add fs_info convenience variables

2016-12-06T15:06:59+00:00

In routines where someptr->fs_info is referenced multiple times, we
introduce a convenience variable.  This makes the code considerably
more readable.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: pull node/sector/stripe sizes out of root and into fs_info

2016-12-06T15:06:58+00:00

We track the node sizes per-root, but they never vary from the values
in the superblock.  This patch messes with the 80-column style a bit,
but subsequent patches to factor out root->fs_info into a convenience
variable fix it up again.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: unsplit printed strings

2016-09-26T16:08:44+00:00

CodingStyle chapter 2:
"[...] never break user-visible strings such as printk messages,
because that breaks the ability to grep for them."

This patch unsplits user-visible strings.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

btrfs: Fix slab accounting flags

2016-07-26T11:52:25+00:00

BTRFS is using a variety of slab caches to satisfy internal needs.
Those slab caches are always allocated with the SLAB_RECLAIM_ACCOUNT,
meaning allocations from the caches are going to be accounted as
SReclaimable. At the same time btrfs is not registering any shrinkers
whatsoever, thus preventing memory from the slabs to be shrunk. This
means those caches are not in fact reclaimable.

To fix this remove the SLAB_RECLAIM_ACCOUNT on all caches apart from the
inode cache, since this one is being freed by the generic VFS super_block
shrinker. Also set the transaction related caches as SLAB_TEMPORARY,
to better document the lifetime of the objects (it just translates
to SLAB_RECLAIM_ACCOUNT).

Signed-off-by: Nikolay Borisov 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba