linux.git/fs/btrfs/export.c, branch v4.11

btrfs: Make btrfs_ino take a struct btrfs_inode

2017-02-14T14:50:51+00:00

Currently btrfs_ino takes a struct inode and this causes a lot of
internal btrfs functions which consume this ino to take a VFS inode,
rather than btrfs' own struct btrfs_inode. In order to fix this "leak"
of VFS structs into the internals of btrfs first it's necessary to
eliminate all uses of struct inode for the purpose of inode. This patch
does that by using BTRFS_I to convert an inode to btrfs_inode. With
this problem eliminated subsequent patches will start eliminating the
passing of struct inode altogether, eventually resulting in a lot cleaner
code.

Signed-off-by: Nikolay Borisov 
[ fix btrfs_get_extent tracepoint prototype ]
Signed-off-by: David Sterba

btrfs: remove redundant inode null check

2017-02-14T14:50:50+00:00

The check for a null inode is redundant since the function
is a callback for exportfs, which will itself crash if
dentry->d_inode or parent->d_inode is NULL.  Removing the
null check makes this consistent with other file systems.

Also remove the redundant null dir check too.

Found with static analysis by CoverityScan, CID 1389472

Kudos to Jeff Mahoney for reviewing and explaining the error in
my original patch (most of this explanation went into the above
commit message) and David Sterba for pointing out that the dir
check is also redundant.

Signed-off-by: Colin Ian King 
Signed-off-by: David Sterba

btrfs: root->fs_info cleanup, add fs_info convenience variables

2016-12-06T15:06:59+00:00

In routines where someptr->fs_info is referenced multiple times, we
introduce a convenience variable.  This makes the code considerably
more readable.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

BTRFS: support NFSv2 export

2015-10-06T13:55:23+00:00

The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
that returned by encode_fh - it may be larger.

With NFSv2, the filehandle is fixed length, so it may appear longer
than expected and be zero-padded.

So we must test that fh_len is at least some value, not exactly equal
to it.

Signed-off-by: NeilBrown 
Acked-by: David Sterba

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15T19:06:57+00:00

that's the bulk of filesystem drivers dealing with inodes of their own

Signed-off-by: David Howells 
Signed-off-by: Al Viro

btrfs: kill the key type accessor helpers

2014-09-17T20:37:12+00:00

btrfs_set_key_type and btrfs_key_type are used inconsistently along with
open coded variants. Other members of btrfs_key are accessed directly
without any helpers anyway.

Signed-off-by: David Sterba 
Signed-off-by: Chris Mason

btrfs: remove fs/btrfs/compat.h

2013-11-12T03:03:19+00:00

fs/btrfs/compat.h only contained trivial macro wrappers of drop_nlink()
and inc_nlink().  This doesn't belong in mainline.

Signed-off-by: Zach Brown 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: cleanup: don't check the same thing twice

2013-06-14T15:29:30+00:00

btrfs_read_fs_root_no_name() already checks if btrfs_root_refs()
is zero and returns ENOENT in this case. There is no need to do
it again in six places.

Signed-off-by: Stefan Behrens 
Signed-off-by: Josef Bacik

fs: encode_fh: return FILEID_INVALID if invalid fid_type

2013-02-26T07:46:10+00:00

This patch is a follow up on below patch:

[PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type
commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63

Signed-off-by: Namjae Jeon 
Signed-off-by: Vivek Trivedi 
Acked-by: Steven Whitehouse 
Acked-by: Sage Weil 
Signed-off-by: Al Viro

->encode_fh() API change

2012-05-30T03:28:33+00:00

pass inode + parent's inode or NULL instead of dentry + bool saying
whether we want the parent or not.

NOTE: that needs ceph fix folded in.

Signed-off-by: Al Viro