linux.git/fs/btrfs/dev-replace.h, branch v5.1

btrfs: dev-replace: open code trivial locking helpers

2018-12-17T13:51:45+00:00

The dev-replace locking functions are now trivial wrappers around rw
semaphore that can be used directly everywhere. No functional change.

Signed-off-by: David Sterba

btrfs: dev-replace: remove custom read/write blocking scheme

2018-12-17T13:51:45+00:00

After the rw semaphore has been added, the custom blocking using
::blocking_readers and ::read_lock_wq is redundant.

The blocking logic in __btrfs_map_block is replaced by extending the
time the semaphore is held, that has the same blocking effect on writes
as the previous custom scheme that waited until ::blocking_readers was
zero.

Signed-off-by: David Sterba

btrfs: mark btrfs_dev_replace_start as static

2018-12-17T13:51:34+00:00

There isn't any other consumer other than in its own file dev-replace.c.

Signed-off-by: Anand Jain 
Reviewed-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: open code btrfs_after_dev_replace_commit

2018-10-15T15:23:37+00:00

Too trivial, the purpose can be simply documented in a comment.

Reviewed-by: Omar Sandoval 
Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: open code btrfs_dev_replace_stats_inc

2018-10-15T15:23:37+00:00

The wrapper is too trivial, open coding does not make it less readable.

Reviewed-by: Omar Sandoval 
Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: open code btrfs_dev_replace_clear_lock_blocking

2018-10-15T15:23:37+00:00

There's a single caller and the function name does not say it's actually
taking the lock, so open coding makes it more explicit.

For now, btrfs_dev_replace_read_lock is used instead of read_lock so
it's paired with the unlocking wrapper in the same block.

Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: replace GPL boilerplate by SPDX -- headers

2018-04-12T14:29:46+00:00

Remove GPL boilerplate text (long, short, one-line) and keep the rest,
ie. personal, company or original source copyright statements. Add the
SPDX header.

Unify the include protection macros to match the file names.

Signed-off-by: David Sterba

btrfs: split dev-replace locking helpers for read and write

2018-03-31T00:01:07+00:00

The current calls are unclear in what way btrfs_dev_replace_lock takes
the locks, so drop the argument, split the helpers and use similar
naming as for read and write locks.

Signed-off-by: David Sterba

btrfs: btrfs_dev_replace_cancel() can return int

2018-03-26T13:09:30+00:00

Current u64 return from btrfs_dev_replace_cancel() was probably done
to match the btrfs_ioctl_dev_replace_args::result. However as our
actual return value fits in int, and it further gets typecast to u64,
so just return int.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: rename __btrfs_dev_replace_cancel()

2018-03-26T13:09:30+00:00

Remove __ which is for the special functions.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba