linux.git/fs/btrfs/dev-replace.c, branch v6.16

btrfs: trivial conversion to return bool instead of int

2025-05-15T12:30:49+00:00

Old code has a lot of int for bool return values, bool is recommended
and done in new code. Convert the trivial cases that do simple 0/false
and 1/true. Functions comment are updated if needed.

Reviewed-by: Naohiro Aota 
Signed-off-by: David Sterba

btrfs: convert ASSERT(0) with handled errors to DEBUG_WARN()

2025-05-15T12:30:47+00:00

The use of ASSERT(0) is maybe useful for some cases but more like a
notice for developers. Assertions can be compiled in independently so
convert it to a debugging helper.

The difference is that it's just a warning and will not end up in BUG().
The converted cases are in connection with proper error handling.

Reviewed-by: Josef Bacik 
Signed-off-by: David Sterba

btrfs: rename free_extent_state() to include a btrfs prefix

2025-05-15T12:30:44+00:00

This is an exported function so it should have a 'btrfs_' prefix by
convention, to make it clear it's btrfs specific and to avoid collisions
with functions from elsewhere in the kernel.

Rename the function to add 'btrfs_' prefix to it.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: rename the functions to search for bits in extent ranges

2025-05-15T12:30:44+00:00

These functions are exported so they should have a 'btrfs_' prefix by
convention, to make it clear they are btrfs specific and to avoid
collisions with functions from elsewhere in the kernel.

So add a 'btrfs_' prefix to their name to make it clear they are from
btrfs.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: rename set_extent_bit() to include a btrfs prefix

2025-05-15T12:30:44+00:00

This is an exported function so it should have a 'btrfs_' prefix by
convention, to make it clear it's btrfs specific and to avoid collisions
with functions from elsewhere in the kernel.

So rename it to btrfs_set_extent_bit().

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: return a literal instead of a variable in btrfs_init_dev_replace()

2025-03-18T19:35:49+00:00

This is just a small clean up, it doesn't change how the code works.
Originally this code had a goto so we needed to set "ret = 0;" but now
it returns directly and so we can simplify it a bit by doing a
"return 0;" and removing the assignment.

Reviewed-by: Anand Jain 
Signed-off-by: Dan Carpenter 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: use BTRFS_PATH_AUTO_FREE in btrfs_run_dev_replace()

2025-03-18T19:35:47+00:00

This is the trivial pattern for path auto free, initialize at the
beginning and free at the end with simple goto -> return conversions.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: use BTRFS_PATH_AUTO_FREE in btrfs_init_dev_replace()

2025-03-18T19:35:47+00:00

This is the trivial pattern for path auto free, initialize at the
beginning and free at the end with simple goto -> return conversions.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: David Sterba

btrfs: dev-replace: remove unnecessary call to btrfs_mark_buffer_dirty()

2025-01-13T13:53:19+00:00

The call to btrfs_mark_buffer_dirty() at btrfs_run_dev_replace() is not
necessary as we have a path setup for writing with btrfs_search_slot()
having a 'cow' argument set to 1.

This just makes the code more verbose, confusing and add a little extra
overhead and well as increase the module's text size, so remove it.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Filipe Manana 
Signed-off-by: David Sterba

btrfs: correct typos in multiple comments across various files

2024-11-11T13:34:14+00:00

Fix some confusing spelling errors that were currently identified,
the details are as follows:

	block-group.c: 2800: 	uncompressible 	==> incompressible
	extent-tree.c: 3131:	EXTEMT		==> EXTENT
	extent_io.c: 3124: 	utlizing 	==> utilizing
	extent_map.c: 1323: 	ealier		==> earlier
	extent_map.c: 1325:	possiblity	==> possibility
	fiemap.c: 189:		emmitted	==> emitted
	fiemap.c: 197:		emmitted	==> emitted
	fiemap.c: 203:		emmitted	==> emitted
	transaction.h: 36:	trasaction	==> transaction
	volumes.c: 5312:	filesysmte	==> filesystem
	zoned.c: 1977:		trasnsaction	==> transaction

Signed-off-by: Shen Lichuan 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba