linux.git/fs/btrfs/dev-replace.c, branch v4.17

btrfs: replace GPL boilerplate by SPDX -- sources

2018-04-12T14:29:51+00:00

Remove GPL boilerplate text (long, short, one-line) and keep the rest,
ie. personal, company or original source copyright statements. Add the
SPDX header.

Signed-off-by: David Sterba

btrfs: split dev-replace locking helpers for read and write

2018-03-31T00:01:07+00:00

The current calls are unclear in what way btrfs_dev_replace_lock takes
the locks, so drop the argument, split the helpers and use similar
naming as for read and write locks.

Signed-off-by: David Sterba

btrfs: log, when replace, is canceled by the user

2018-03-26T13:09:34+00:00

For debugging or administration purposes, we would want to know if and
when the user cancels the replace, to complement the existing messages
when dev-replace starts or finishes.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
[ update changelog, fold fix for RCU warning from Nikolay ]
Signed-off-by: David Sterba

btrfs: fix null pointer deref when target device is missing

2018-03-26T13:09:34+00:00

The replace target device can be missing when mounted with -o degraded,
but we wont allocate a missing btrfs_device to it. So check the device
before accessing.

BUG: unable to handle kernel NULL pointer dereference at 00000000000000b0
IP: btrfs_destroy_dev_replace_tgtdev+0x43/0xf0 [btrfs]
Call Trace:
btrfs_dev_replace_cancel+0x15f/0x180 [btrfs]
btrfs_ioctl+0x2216/0x2590 [btrfs]
do_vfs_ioctl+0x625/0x650
SyS_ioctl+0x4e/0x80
do_syscall_64+0x5d/0x160
entry_SYSCALL64_slow_path+0x25/0x25

This patch has been moved in front of patch "btrfs: log, when replace,
is canceled by the user" that could reproduce the crash if the system
reboots inside btrfs_dev_replace_start before the
btrfs_dev_replace_finishing call.

 $ mkfs /dev/sda
 $ mount /dev/sda mnt
 $ btrfs replace start /dev/sda /dev/sdb
 
 $ mount po degraded /dev/sdb mnt
 

Signed-off-by: Anand Jain 
[ added reproducer description from mail ]
Signed-off-by: David Sterba

btrfs: open code btrfs_init_dev_replace_tgtdev_for_resume()

2018-03-26T13:09:30+00:00

btrfs_init_dev_replace_tgtdev_for_resume() initializes replace
target device in a few simple steps, so do it at the parent function.
Moreover, there isn't any other caller so just open code it.

Signed-off-by: Anand Jain 
Reviewed-by: Qu Wenruo 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: btrfs_dev_replace_cancel() can return int

2018-03-26T13:09:30+00:00

Current u64 return from btrfs_dev_replace_cancel() was probably done
to match the btrfs_ioctl_dev_replace_args::result. However as our
actual return value fits in int, and it further gets typecast to u64,
so just return int.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: rename __btrfs_dev_replace_cancel()

2018-03-26T13:09:30+00:00

Remove __ which is for the special functions.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: open code btrfs_dev_replace_cancel()

2018-03-26T13:09:29+00:00

btrfs_dev_replace_cancel() calls __btrfs_dev_replace_cancel() for the
actual cancel so just open code it.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: cleanup device states define BTRFS_DEV_STATE_REPLACE_TGT

2018-01-22T15:08:15+00:00

Currently device state is being managed by each individual int
variable such as struct btrfs_device::is_tgtdev_for_dev_replace.
Instead of that declare btrfs_device::dev_state
BTRFS_DEV_STATE_MISSING and use the bit operations.

Signed-off-by: Anand Jain 
[ whitespace adjustments ]
Signed-off-by: David Sterba

btrfs: cleanup device states define BTRFS_DEV_STATE_MISSING

2018-01-22T15:08:15+00:00

Currently device state is being managed by each individual int
variable such as struct btrfs_device::missing. Instead of that
declare btrfs_device::dev_state BTRFS_DEV_STATE_MISSING and use
the bit operations.

Signed-off-by: Anand Jain 
Reviewed-by : Nikolay Borisov 
[ whitespace adjustments ]
Signed-off-by: David Sterba