linux.git/fs/btrfs/compression.c, branch v6.17

btrfs: reject invalid compression level

2025-09-18T11:18:49+00:00

Inspired by recent changes to compression level parsing in
6db1df415d73fc ("btrfs: accept and ignore compression level for lzo")
it turns out that we do not do any extra validation for compression
level input string, thus allowing things like "compress=lzo:invalid" to
be accepted without warnings.

Although we accept levels that are beyond the supported algorithm
ranges, accepting completely invalid level specification is not correct.

Fix the too loose checks for compression level, by doing proper error
handling of kstrtoint(), so that we will reject not only too large
values (beyond int range) but also completely wrong levels like
"lzo:invalid".

Signed-off-by: Qu Wenruo 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: use pgoff_t for page index variables

2025-07-21T21:58:05+00:00

Any conversion of offsets in the logical or the physical mapping space
of the pages is done by a shift and the target type should be pgoff_t
(type of struct page::index). Fix the locations where it's still
unsigned long.

Signed-off-by: David Sterba

btrfs: replace nested usage of min & max with clamp in btrfs_compress_set_level()

2025-07-21T21:58:05+00:00

Refactor the btrfs_compress_set_level() function by replacing the
nested usage of min() and max() macro with clamp() to simplify the
code and improve readability.

Reviewed-by: Qu Wenruo 
Signed-off-by: George Hu 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: use our message helpers instead of pr_err/pr_warn/pr_info

2025-07-21T21:58:04+00:00

Our message helpers accept NULL for the fs_info in the context that does
not provide and print the common header of the message. The use of pr_*
helpers is only for special reasons, like module loading, device
scanning or multi-line output (print-tree).

Reviewed-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: rename ret2 to ret in btrfs_submit_compressed_read()

2025-05-15T12:30:49+00:00

We can now rename 'ret2' to 'ret' and use it for generic errors.

Reviewed-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: rename ret to status in btrfs_submit_compressed_read()

2025-05-15T12:30:48+00:00

We're using 'status' for the blk_status_t variables, rename 'ret' so we can
use it for generic errors.

Reviewed-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: simplify reading bio status in end_compressed_writeback()

2025-05-15T12:30:48+00:00

We don't need to have a separate variable to read the bio status, 'ret'
works for that just fine so remove 'error'.

Reviewed-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: use bvec_kmap_local() in btrfs_decompress_buf2page()

2025-05-15T12:30:47+00:00

This removes the last direct poke into bvec internals in btrfs.

Reviewed-by: Josef Bacik 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Qu Wenruo 
Signed-off-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: rename remaining exported extent map functions

2025-05-15T12:30:45+00:00

Rename all the exported functions from extent_map.h that don't have a
'btrfs_' prefix in their names, so that they are consistent with all the
other functions, to make it clear they are btrfs specific functions and
to avoid potential name collisions in the future with functions defined
elsewhere in the kernel.

Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: rename functions to allocate and free extent maps

2025-05-15T12:30:45+00:00

These functions are exported and don't have a 'btrfs_' prefix in their
names, which goes against coding style conventions. Rename them to have
such prefix, making it clear they are from btrfs and avoiding potential
collisions in the future with functions defined elsewhere outside btrfs.

Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba