linux.git/fs/btrfs/backref.c, branch v6.17

btrfs: set search_commit_root to false in iterate_inodes_from_logical()

2025-07-21T22:09:20+00:00

There's no point in checking at iterate_inodes_from_logical() if the path
has search_commit_root set, the only caller never sets search_commit_root
to true and it doesn't make sense for it ever to be true for the current
use case (logical_to_ino ioctl). So stop checking for that and since the
only caller allocates the path just for it to be used by
iterate_inodes_from_logical(), move the path allocation into that function.

Reviewed-by: Boris Burkov 
Signed-off-by: Filipe Manana 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: simplify debug print helpers without enabled printk

2025-07-21T21:56:39+00:00

The btrfs_debug() helpers depend on various config options. In case of
"no_printk" we don't need to define a special helper that in the end
does nothing but validates the parameters. As the default build config
is to validate the parameters we can simplify it to let the debug
helpers expand to nothing and remove btrfs_no_printk_in_rcu().

To avoid warnings use fs_info and inline one variable in
extent_from_logical().

Reviewed-by: Daniel Vacek 
Signed-off-by: David Sterba

btrfs: rename err to ret2 in resolve_indirect_refs()

2025-07-21T21:53:27+00:00

Unify naming of return value to the preferred way, move the variable to
the closest scope.

Reviewed-by: Anand Jain 
Signed-off-by: David Sterba

btrfs: pass struct rb_simple_node pointer directly in rb_simple_insert()

2025-07-21T21:53:26+00:00

Replace struct embedding with union to enable safe type conversion in
btrfs_backref_node, tree_block and mapping_node.

Adjust function calls to use the new unified API, eliminating redundant
parameters.

Signed-off-by: Pan Chuang 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: relocation: simplify unused logic related to LINK_LOWER

2025-07-21T21:53:25+00:00

btrfs_backref_link_edge() is always called with the LINK_LOWER argument.
We can simplify it and remove the LINK_LOWER and LINK_UPPER macros
completely.

The last call with LINK_UPPER was removed with commit 0097422c0dfe0a
("btrfs: remove clone_backref_node() from relocation").

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Daniel Vacek 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: use list_first_entry() everywhere

2025-05-15T12:30:47+00:00

Using the helper makes it a bit more clear that we're accessing the
first list entry.

Reviewed-by: Qu Wenruo 
Signed-off-by: David Sterba

btrfs: convert ASSERT(0) with handled errors to DEBUG_WARN()

2025-05-15T12:30:47+00:00

The use of ASSERT(0) is maybe useful for some cases but more like a
notice for developers. Assertions can be compiled in independently so
convert it to a debugging helper.

The difference is that it's just a warning and will not end up in BUG().
The converted cases are in connection with proper error handling.

Reviewed-by: Josef Bacik 
Signed-off-by: David Sterba

btrfs: convert WARN_ON(IS_ENABLED(CONFIG_BTRFS_DEBUG)) to DEBUG_WARN

2025-05-15T12:30:47+00:00

Use the conditional warning instead of typing the whole condition.
Optional message is printed where it seems clear what could be the
problem.

Conversion is left out in btree_csum_one_bio() because of the additional
condition.

Reviewed-by: Josef Bacik 
Signed-off-by: David Sterba

btrfs: unify ordering of btrfs_key initializations

2025-03-18T19:35:42+00:00

The btrfs_key is defined as objectid/type/offset and the keys are also
printed like that. For better readability, update all key
initializations to match this order.

Signed-off-by: David Sterba

btrfs: update prelim_ref_insert() to use rb helpers

2025-01-13T13:53:18+00:00

Update prelim_ref_insert() to use rb_find_add_cached().

There is a special change that the existing prelim_ref_compare() is
called with the first parameter as the existing ref in the rbtree.

But the newer rb_find_add_cached() expects the cmp() function to have
the first parameter as the to-be-added node, thus the new helper
prelim_ref_rb_add_cmp() need to adapt this new order.

Signed-off-by: Roger L. Beckermeyer III 
Reviewed-by: Qu Wenruo 
Signed-off-by: Qu Wenruo 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba