linux.git/fs/btrfs/backref.c, branch v3.16

Btrfs: fix scrub_print_warning to handle skinny metadata extents

2014-06-10T00:21:17+00:00

The skinny extents are intepreted incorrectly in scrub_print_warning(),
and end up hitting the BUG() in btrfs_extent_inline_ref_size.

Reported-by: Konstantinos Skarlatos 
Signed-off-by: Liu Bo 
Signed-off-by: Chris Mason

Btrfs: use right type to get real comparison

2014-06-10T00:21:15+00:00

We want to make sure the point is still within the extent item, not to verify
the memory it's pointing to.

Signed-off-by: Liu Bo 
Signed-off-by: Chris Mason

Btrfs: don't check nodes for extent items

2014-06-10T00:21:14+00:00

The backref code was looking at nodes as well as leaves when we tried to
populate extent item entries.  This is not good, and although we go away with it
for the most part because we'd skip where disk_bytenr != random_memory,
sometimes random_memory would match and suddenly boom.  This fixes that problem.
Thanks,

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: add sanity tests for new qgroup accounting code

2014-06-10T00:20:49+00:00

This exercises the various parts of the new qgroup accounting code.  We do some
basic stuff and do some things with the shared refs to make sure all that code
works.  I had to add a bunch of infrastructure because I needed to be able to
insert items into a fake tree without having to do all the hard work myself,
hopefully this will be usefull in the future.  Thanks,

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: remove transaction from send

2014-04-07T00:39:30+00:00

Lets try this again.  We can deadlock the box if we send on a box and try to
write onto the same fs with the app that is trying to listen to the send pipe.
This is because the writer could get stuck waiting for a transaction commit
which is being blocked by the send.  So fix this by making sure looking at the
commit roots is always going to be consistent.  We do this by keeping track of
which roots need to have their commit roots swapped during commit, and then
taking the commit_root_sem and swapping them all at once.  Then make sure we
take a read lock on the commit_root_sem in cases where we search the commit root
to make sure we're always looking at a consistent view of the commit roots.
Previously we had problems with this because we would swap a fs tree commit root
and then swap the extent tree commit root independently which would cause the
backref walking code to screw up sometimes.  With this patch we no longer
deadlock and pass all the weird send/receive corner cases.  Thanks,

Reportedy-by: Hugo Mills 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: take into account total references when doing backref lookup

2014-03-21T22:28:09+00:00

I added an optimization for large files where we would stop searching for
backrefs once we had looked at the number of references we currently had for
this extent.  This works great most of the time, but for snapshots that point to
this extent and has changes in the original root this assumption falls on it
face.  So keep track of any delayed ref mods made and add in the actual ref
count as reported by the extent item and use that to limit how far down an inode
we'll search for extents.  Thanks,

Reportedy-by: Hugo Mills 
Signed-off-by: Josef Bacik 
Reported-by: Hugo Mills 
Tested-by: Hugo Mills 
Signed-off-by: Chris Mason

Btrfs: skip locking when searching commit root

2014-03-10T19:16:55+00:00

We won't change commit root, skip locking dance with commit root
when walking backrefs, this can speed up btrfs send operations.

Signed-off-by: Wang Shilong 
Signed-off-by: Josef Bacik

Btrfs: switch to btrfs_previous_extent_item()

2014-03-10T19:15:54+00:00

Since we have introduced btrfs_previous_extent_item() to search previous
extent item, just switch into it.

Signed-off-by: Wang Shilong 
Reviewed-by: Filipe Manana 
Signed-off-by: Josef Bacik

Btrfs: only add roots if necessary in find_parent_nodes()

2014-03-10T19:15:41+00:00

find_all_leafs() dosen't need add all roots actually, add roots only
if we need, this can avoid unnecessary ulist dance.

Signed-off-by: Wang Shilong 
Signed-off-by: Josef Bacik

Btrfs: fix memory leaks on walking backrefs failure

2014-01-29T15:06:26+00:00

When walking backrefs, we may iterate every inode's extent
and add/merge them into ulist, and the caller will free memory
from ulist.

However, if we fail to allocate inode's extents element
memory or ulist_add() fail to allocate memory, we won't
add allocated memory into ulist, and the caller won't
free some allocated memory thus memory leaks happen.

Signed-off-by: Wang Shilong 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason