linux.git/fs/block_dev.c, branch v5.7-rc2

Merge tag 'vfs-5.7-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux

2020-04-02T19:59:36+00:00

Pull hibernation fix from Darrick Wong:
 "Fix a regression where we broke the userspace hibernation driver by
  disallowing writes to the swap device"

* tag 'vfs-5.7-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
  hibernate: Allow uswsusp to write to swap

hibernate: Allow uswsusp to write to swap

2020-03-23T15:22:15+00:00

It turns out that there is one use case for programs being able to
write to swap devices, and that is the userspace hibernation code.

Quick fix: disable the S_SWAPFILE check if hibernation is configured.

Fixes: dc617f29dbe5 ("vfs: don't allow writes to swap files")
Reported-by: Domenico Andreoli 
Reported-by: Marian Klein 
Signed-off-by: Domenico Andreoli 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Darrick J. Wong

block: fix a device invalidation regression

2020-03-18T14:47:04+00:00

Historically we only set the capacity to zero for devices that support
partitions (independ of actually having partitions created).  Doing that
is rather inconsistent, but changing it broke legacy udisks polling for
legacy ide-cdrom devices.  Use the crude a crude check for devices that
either are non-removable or partitionable to get the sane behavior for
most device while not breaking userspace for this particular setup.

Fixes: a1548b674403 ("block: move rescan_partitions to fs/block_dev.c")
Reported-by: He Zhe 
Signed-off-by: Christoph Hellwig 
Tested-by: He Zhe 
Signed-off-by: Jens Axboe

block: don't send uevent for empty disk when not invalidating

2019-12-03T01:49:30+00:00

Commit 6917d0689993 ("block: merge invalidate_partitions into
rescan_partitions") caused a regression where systemd-udevd spins
forever using max CPU starting at boot time.

It's caused by a behavior change where a KOBJ_CHANGE uevent is now sent
in a case where previously it wasn't.

Restore the old behavior.

Fixes: 6917d0689993 ("block: merge invalidate_partitions into rescan_partitions")
Reviewed-by: Christoph Hellwig 
Signed-off-by: Eric Biggers 
Signed-off-by: Jens Axboe

block: move clearing bd_invalidated into check_disk_size_change

2019-11-14T14:44:01+00:00

Both callers of check_disk_size_change clear bd_invalidate directly
after the call, so move the clearing into check_disk_size_change
itself.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove (__)blkdev_reread_part as an exported API

2019-11-14T14:43:59+00:00

In general drivers should never mess with partition tables directly.
Unfortunately s390 and loop do for somewhat historic reasons, but they
can use bdev_disk_changed directly instead when we export it as they
satisfy the sanity checks we have in __blkdev_reread_part.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Stefan Haberland 	[dasd]
Reviewed-by: Jan Kara 
Signed-off-by: Jens Axboe

block: fix bdev_disk_changed for non-partitioned devices

2019-11-14T14:43:53+00:00

We still have to set the capacity to 0 if invalidating or call
revalidate_disk if not even if the disk has no partitions.  Fix
that by merging rescan_partitions into bdev_disk_changed and just
stubbing out blk_add_partitions and blk_drop_partitions for
non-partitioned devices.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Signed-off-by: Jens Axboe

block: move rescan_partitions to fs/block_dev.c

2019-11-14T14:43:21+00:00

Large parts of rescan_partitions aren't about partitions, and
moving it to block_dev.c will allow for some further cleanups by
merging it into its only caller.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Signed-off-by: Jens Axboe

block: merge invalidate_partitions into rescan_partitions

2019-11-14T14:42:41+00:00

A lot of the logic in invalidate_partitions and rescan_partitions is
shared.  Merge the two functions to simplify things.  There is a small
behavior change in that we now send the kevent change notice also if we
were not invalidating but no partitions were found, which seems like
the right thing to do.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Signed-off-by: Jens Axboe

bdev: Refresh bdev size for disks without partitioning

2019-11-03T14:53:50+00:00

Currently, block device size in not updated on second and further open
for block devices where partition scan is disabled. This is particularly
annoying for example for DVD drives as that means block device size does
not get updated once the media is inserted into a drive if the device is
already open when inserting the media. This is actually always the case
for example when pktcdvd is in use.

Fix the problem by revalidating block device size on every open even for
devices with partition scan disabled.

Signed-off-by: Jan Kara 
Signed-off-by: Jens Axboe