linux.git/fs/bcachefs, branch v6.8 Linux kernel source tree bcachefs: fix bch2_save_backtrace() 2024-02-25T20:45:36+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-25T20:45:34+00:00 5197728f8182a93a07e5bf860726456322d3a908 Missed a call in the previous fix. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Missed a call in the previous fix.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix check_snapshot() memcpy 2024-02-25T01:47:47+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-24T06:18:45+00:00 c4333eb541b92d91be57f757dccf6d4368516746 check_snapshot() copies the bch_snapshot to a temporary to easily handle older versions that don't have all the fields of the current version, but it lacked a min() to correctly handle keys newer and larger than the current version. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
check_snapshot() copies the bch_snapshot to a temporary to easily handle
older versions that don't have all the fields of the current version,
but it lacked a min() to correctly handle keys newer and larger than the
current version.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix bch2_journal_flush_device_pins() 2024-02-25T01:46:48+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-18T01:38:47+00:00 097471f9e458dbbe41e25394c1fb1ccd751f0bee If a journal write errored, the list of devices it was written to could be empty - we're not supposed to mark an empty replicas list. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
If a journal write errored, the list of devices it was written to could
be empty - we're not supposed to mark an empty replicas list.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: fix iov_iter count underflow on sub-block dio read 2024-02-25T01:45:24+00:00 Brian Foster bfoster@redhat.com 2024-02-15T17:16:05+00:00 b58b1b883b9b702e25204dbe2b221eecc8ecd159 bch2_direct_IO_read() checks the request offset and size for sector alignment and then falls through to a couple calculations to shrink the size of the request based on the inode size. The problem is that these checks round up to the fs block size, which runs the risk of underflowing iter->count if the block size happens to be large enough. This is triggered by fstest generic/361 with a 4k block size, which subsequently leads to a crash. To avoid this crash, check that the shorten length doesn't exceed the overall length of the iter. Fixes: Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Su Yue <glass.su@suse.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bch2_direct_IO_read() checks the request offset and size for sector
alignment and then falls through to a couple calculations to shrink
the size of the request based on the inode size. The problem is that
these checks round up to the fs block size, which runs the risk of
underflowing iter->count if the block size happens to be large
enough. This is triggered by fstest generic/361 with a 4k block
size, which subsequently leads to a crash. To avoid this crash,
check that the shorten length doesn't exceed the overall length of
the iter.

Fixes:
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Su Yue <glass.su@suse.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix BTREE_ITER_FILTER_SNAPSHOTS on inodes btree 2024-02-25T01:41:46+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-25T00:14:36+00:00 204f45140faa0772d2ca1b3de96d1c0fb3db8e77 If we're in FILTER_SNAPSHOTS mode and we start scanning a range of the keyspace where no keys are visible in the current snapshot, we have a problem - we'll scan for a very long time before scanning terminates. Awhile back, this was fixed for most cases with peek_upto() (and assertions that enforce that it's being used). But the fix missed the fact that the inodes btree is different - every key offset is in a different snapshot tree, not just the inode field. Fixes: Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
If we're in FILTER_SNAPSHOTS mode and we start scanning a range of the
keyspace where no keys are visible in the current snapshot, we have a
problem - we'll scan for a very long time before scanning terminates.

Awhile back, this was fixed for most cases with peek_upto() (and
assertions that enforce that it's being used).

But the fix missed the fact that the inodes btree is different - every
key offset is in a different snapshot tree, not just the inode field.

Fixes:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Kill __GFP_NOFAIL in buffered read path 2024-02-25T01:41:42+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-23T02:39:13+00:00 04fee68dd99a53dbf0716e99270b66da26519daf Recently, we fixed our __GFP_NOFAIL usage in the readahead path, but the easy one in read_single_folio() (where wa can return an error) was missed - oops. Fixes: Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Recently, we fixed our __GFP_NOFAIL usage in the readahead path, but the
easy one in read_single_folio() (where wa can return an error) was
missed - oops.

Fixes:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: fix backpointer_to_text() when dev does not exist 2024-02-25T01:41:37+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-21T03:16:00+00:00 1f626223a0c8753f8f5c651bf7bfc9e3cfdef7f7 Fixes: Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Fixes:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix missing va_end() 2024-02-14T02:59:27+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-14T01:26:09+00:00 816054f40a5fdaaed05d9e7f603d2824eeee7e62 Fixes: https://lore.kernel.org/linux-bcachefs/202402131603.E953E2CF@keescook/T/#u Reported-by: coverity scan Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Fixes: https://lore.kernel.org/linux-bcachefs/202402131603.E953E2CF@keescook/T/#u
Reported-by: coverity scan
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix check_version_upgrade() 2024-02-14T02:58:37+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-13T01:05:48+00:00 2eeccee86dc75a584a8c7e67a8b824d5168c978f When also downgrading, check_version_upgrade() could pick a new version greater than the latest supported version. Fixes: Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
When also downgrading, check_version_upgrade() could pick a new version
greater than the latest supported version.

Fixes:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Clamp replicas_required to replicas 2024-02-14T01:33:38+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-11T02:01:40+00:00 4e07447503f01766ae976207eb3b947437ed8dbc This prevents going emergency read only when the user has specified replicas_required > replicas. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This prevents going emergency read only when the user has specified
replicas_required > replicas.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>