linux.git/fs/bcachefs, branch v6.15 Linux kernel source tree bcachefs: Check for casefolded dirents in non casefolded dirs 2025-05-22T00:13:14+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-21T04:38:04+00:00 010c89468134d1991b87122379f86feae23d512f Check for mismatches between casefold dirents and casefold directories. A mismatch will cause lookups to fail, as we'll be doing the lookup with the casefolded name, which won't match the non-casefolded dirent, and vice versa. Reported-by: Christopher Snowhill <chris@kode54.net> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Check for mismatches between casefold dirents and casefold directories.

A mismatch will cause lookups to fail, as we'll be doing the lookup with
the casefolded name, which won't match the non-casefolded dirent, and
vice versa.

Reported-by: Christopher Snowhill <chris@kode54.net>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix bch2_dirent_create_snapshot() for casefolding 2025-05-22T00:13:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-21T04:41:07+00:00 ecd76c5f108eec3eea0a5b32007cda0dca6c92ac bch2_dirent_create_snapshot(), used in fsck, neglected to create a casefolded dirent. Just move this into dirent_create_key(). Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bch2_dirent_create_snapshot(), used in fsck, neglected to create a
casefolded dirent.

Just move this into dirent_create_key().

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix casefold opt via xattr interface 2025-05-22T00:13:09+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-21T00:05:45+00:00 8d5ac187da10a8a5599b481588951470a2fb792b Changing the casefold option requires extra checks/work - factor out a helper from bch2_fileattr_set() for the xattr code to use. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Changing the casefold option requires extra checks/work - factor out a
helper from bch2_fileattr_set() for the xattr code to use.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: mkwrite() now only dirties one page 2025-05-19T12:28:41+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-15T01:32:40+00:00 cbed8287e5789558cf947a7b4d47fdf3e25c29bf Don't dirty the whole folio - fixes write amplification with applications doing mmaped writes. https://www.reddit.com/r/bcachefs/comments/1klzcg1/incredible_amounts_of_write_amplification_when/ Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Don't dirty the whole folio - fixes write amplification with
applications doing mmaped writes.

https://www.reddit.com/r/bcachefs/comments/1klzcg1/incredible_amounts_of_write_amplification_when/

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: fix extent_has_stripe_ptr() 2025-05-19T02:35:33+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-19T02:32:30+00:00 494d458cfa70d8c107de5a6b6fc941f31c886b12 This wasn't checking indirect extents. Fixes: https://github.com/koverstreet/bcachefs/issues/887 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This wasn't checking indirect extents.

Fixes: https://github.com/koverstreet/bcachefs/issues/887
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix bch2_btree_path_traverse_cached() when paths realloced 2025-05-17T22:46:17+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-17T22:37:02+00:00 49771a7578cdfb73ca957dc1ca9516872c8b406b btree_key_cache_fill() will allocate and traverse another path (for the underlying btree), so we can't hold pointers to paths across a call - we have to pass indices. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
btree_key_cache_fill() will allocate and traverse another path (for the
underlying btree), so we can't hold pointers to paths across a call - we
have to pass indices.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: fix wrong arg to fsck_err() 2025-05-14T22:59:15+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-14T22:53:48+00:00 9c09e59cc55cdf7feb29971fd792fc1947010b79 fsck_err() needs the btree transaction passed to it if there is one - so that it can unlock/relock around prompting userspace for fixing the error. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
fsck_err() needs the btree transaction passed to it if there is one - so
that it can unlock/relock around prompting userspace for fixing the
error.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix missing commit in backpointer to missing target 2025-05-14T21:05:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-09T19:05:19+00:00 d1041d8eab31f9b4c696ee060141d1b0d156f84d Fsck wants to do transaction commits from an outer context; it may have other repair to do (i.e. duplicate backpointers). But when calling backpointer_not_found() from runtime code, i.e. runtime self healing, we should be doing the commit - the outer context expects to just be doing lookups. This fixes bugs where we get stuck spinning, reported as "RCU lock hold time warnings. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Fsck wants to do transaction commits from an outer context; it may have
other repair to do (i.e. duplicate backpointers).

But when calling backpointer_not_found() from runtime code, i.e. runtime
self healing, we should be doing the commit - the outer context expects
to just be doing lookups.

This fixes bugs where we get stuck spinning, reported as "RCU lock hold
time warnings.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix accidental O(n^2) in fiemap 2025-05-14T21:05:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-14T17:40:47+00:00 a12cb6f758177fcf9bdb7d18b4724eaa29023740 Since bch2_seek_pagecache_data() searches for dirty data, we only want to call it for holes in the extents btree - otherwise we have an accidental O(n^2), as we repeatedly search the same range. Reported-by: Marcin Mirosław <marcin@mejor.pl> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Since bch2_seek_pagecache_data() searches for dirty data, we only want
to call it for holes in the extents btree - otherwise we have an
accidental O(n^2), as we repeatedly search the same range.

Reported-by: Marcin Mirosław <marcin@mejor.pl>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix set_should_be_locked() call in peek_slot() 2025-05-14T21:05:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-14T01:14:17+00:00 43b9fece2d9687cde58cc7eec4548dd1c35e2198 set_should_be_locked() needs to be called before peek_key_cache(), which traverses other paths and may do a trans unlock/relock. This fixes an assertion pop in path_peek_slot(), when the path we're using is unexpectedly not uptodate. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
set_should_be_locked() needs to be called before peek_key_cache(), which
traverses other paths and may do a trans unlock/relock.

This fixes an assertion pop in path_peek_slot(), when the path we're
using is unexpectedly not uptodate.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>