linux.git/fs/bcachefs/sb-errors_format.h, branch v6.11 Linux kernel source tree bcachefs: Mark more errors as autofix 2024-08-31T23:27:01+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-22T15:47:32+00:00 3d3020c461936009dc58702e267ff67b0076cbf2 errors that are known to always be safe to fix should be autofix: this should be most errors even at this point, but that will need some thorough review. note that errors are still logged in the superblock, so we'll still know that they happened. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
errors that are known to always be safe to fix should be autofix: this
should be most errors even at this point, but that will need some
thorough review.

note that errors are still logged in the superblock, so we'll still know
that they happened.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch2_accounting_invalid() 2024-08-09T18:40:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-09T03:19:59+00:00 077e47372309dcbe3a150754ea9c6f15cc838d6b Implement bch2_accounting_invalid(); check for junk at the end, and replicas accounting entries in particular need to be checked or we'll pop asserts later. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Implement bch2_accounting_invalid(); check for junk at the end, and
replicas accounting entries in particular need to be checked or we'll
pop asserts later.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: check_key_has_inode() 2024-07-14T23:00:12+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-26T22:11:37+00:00 c13d526d9dc1aa0c4962b017c881c28c1e23ca26 Consolidate duplicated checks for extents/dirents/xattrs - these keys should all have a corresponding inode of the correct type. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Consolidate duplicated checks for extents/dirents/xattrs - these keys
should all have a corresponding inode of the correct type.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Repair fragmentation_lru in alloc_write_key() 2024-06-29T22:37:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-29T22:37:13+00:00 b5cbb42dc59f519fa3cf49b9afbd5ee4805be01b fragmentation_lru derives from dirty_sectors, and wasn't being checked. Co-developed-by: Daniel Hill <daniel@gluo.nz> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
fragmentation_lru derives from dirty_sectors, and wasn't being checked.

Co-developed-by: Daniel Hill <daniel@gluo.nz>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix safe errors by default 2024-06-20T13:13:09+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-19T13:55:48+00:00 33dfafa90285c0873a24d633877d505ab8e3fc20 i.e. the start of automatic self healing: If errors=continue or fix_safe, we now automatically fix simple errors without user intervention. New error action option: fix_safe This replaces the existing errors=ro option, which gets a new slot, i.e. existing errors=ro users now get errors=fix_safe. This is currently only enabled for a limited set of errors - initially just disk accounting; errors we would never not want to fix, and we don't want to require user intervention (i.e. to make sure a bug report gets filed). Errors will still be counted in the superblock, so we (developers) will still know they've been occuring if a bug report gets filed (as bug reports typically include the errors superblock section). Eventually we'll be enabling this for a much wider set of errors, after we've done thorough error injection testing. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
i.e. the start of automatic self healing:

If errors=continue or fix_safe, we now automatically fix simple errors
without user intervention.

New error action option: fix_safe

This replaces the existing errors=ro option, which gets a new slot, i.e.
existing errors=ro users now get errors=fix_safe.

This is currently only enabled for a limited set of errors - initially
just disk accounting; errors we would never not want to fix, and we
don't want to require user intervention (i.e. to make sure a bug report
gets filed).

Errors will still be counted in the superblock, so we (developers) will
still know they've been occuring if a bug report gets filed (as bug
reports typically include the errors superblock section).

Eventually we'll be enabling this for a much wider set of errors, after
we've done thorough error injection testing.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Guard against overflowing LRU_TIME_BITS 2024-06-19T22:27:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-17T14:06:03+00:00 cff07e2739d81cf33eb2a378a6136eced852b8cb LRUs only have 48 bits for the time field (i.e. LRU order); thus we need overflow checks and guards. Reported-by: syzbot+df3bf3f088dcaa728857@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
LRUs only have 48 bits for the time field (i.e. LRU order); thus we need
overflow checks and guards.

Reported-by: syzbot+df3bf3f088dcaa728857@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Check for invalid btree IDs 2024-06-19T22:27:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-17T13:26:54+00:00 9e7cfb35e2668e542c333ed3ec4b0a951dd332ee We can only handle btree IDs up to 62, since the btree id (plus the type for interior btree nodes) has to fit ito a 64 bit bitmask - check for invalid ones to avoid invalid shifts later. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We can only handle btree IDs up to 62, since the btree id (plus the type
for interior btree nodes) has to fit ito a 64 bit bitmask - check for
invalid ones to avoid invalid shifts later.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Split out sb-errors_format.h 2024-05-28T21:33:45+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-28T21:23:01+00:00 759bb4eabc727077145f3173f8ef6c2ac745c3d6 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>