linux.git/fs/bcachefs/io_write.c, branch v6.13 Linux kernel source tree bcachefs: Fix null ptr deref in bucket_gen_get() 2024-11-07T21:48:17+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-10-28T00:40:20+00:00 fd00045f383f51b66a7a46084a0e92b8de563157 bucket_gen() checks if we're lookup up a valid bucket and returns NULL otherwise, but bucket_gen_get() was failing to check; other callers were correct. Also do a bit of cleanup on callers. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bucket_gen() checks if we're lookup up a valid bucket and returns NULL
otherwise, but bucket_gen_get() was failing to check; other callers were
correct.

Also do a bit of cleanup on callers.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Don't use commit_do() unnecessarily 2024-10-18T04:49:48+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-10-14T01:53:26+00:00 a0d11feefb1998204f095fa0400024403d233108 Using commit_do() to call alloc_sectors_start_trans() breaks when we're randomly injecting transaction restarts - the restart in the commit causes us to leak the lock that alloc_sectorS_start_trans() takes. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Using commit_do() to call alloc_sectors_start_trans() breaks when we're
randomly injecting transaction restarts - the restart in the commit
causes us to leak the lock that alloc_sectorS_start_trans() takes.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: rename version -> bversion 2024-09-28T01:46:35+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-09-26T19:49:17+00:00 cf49f8a8c277f9f2b78e2a56189a741a508a9820 give bversions a more distinct name, to aid in grepping Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
give bversions a more distinct name, to aid in grepping

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: BCH_WRITE_ALLOC_NOWAIT no longer applies to open bucket allocation 2024-09-21T15:35:20+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-09-01T21:32:22+00:00 a977f3e162924ef82536ad23448364f2b3e9f026 rebalance writes must be BCH_WRITE_ALLOC_NOWAIT because they don't allocate from the full filesystem - but we don't want spurious allocation failures due to open buckets. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
rebalance writes must be BCH_WRITE_ALLOC_NOWAIT because they don't
allocate from the full filesystem - but we don't want spurious
allocation failures due to open buckets.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Make allocator stuck timeout configurable, ratelimit messages 2024-08-08T01:04:55+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-07T17:58:57+00:00 cecf72798b25fcb00303392407fccf500a746747 Limit these messages to once every 2 minutes to avoid spamming logs; with multiple devices the output can be quite significant. Also, up the default timeout to 30 seconds from 10 seconds. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Limit these messages to once every 2 minutes to avoid spamming logs;
with multiple devices the output can be quite significant.

Also, up the default timeout to 30 seconds from 10 seconds.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Rename BCH_WRITE_DONE -> BCH_WRITE_SUBMITTED 2024-07-14T23:59:12+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-08-28T20:13:18+00:00 ae469056313f7d8a63646de8ef53eebfefc2d9c0 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Ratelimit checksum error messages 2024-07-14T23:00:16+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-28T17:51:38+00:00 5e3c208325189df6d0c08307cbadb2a03b2fbe2e Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: spelling fix 2024-07-14T23:00:16+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-28T17:36:00+00:00 0f3372dcee6212ad49a8c32ea3ca80b91f36b9d3 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Use try_cmpxchg() family of functions instead of cmpxchg() 2024-07-14T23:00:12+00:00 Uros Bizjak ubizjak@gmail.com 2024-05-23T09:19:26+00:00 68573b936d3fceda9cd5cce3a577e035d19ad426 Use try_cmpxchg() family of functions instead of cmpxchg (*ptr, old, new) == old. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg). Also, try_cmpxchg() implicitly assigns old *ptr value to "old" when cmpxchg fails. There is no need to re-read the value in the loop. No functional change intended. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Cc: Kent Overstreet <kent.overstreet@linux.dev> Cc: Brian Foster <bfoster@redhat.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Use try_cmpxchg() family of functions instead of
cmpxchg (*ptr, old, new) == old. x86 CMPXCHG instruction returns
success in ZF flag, so this change saves a compare after cmpxchg
(and related move instruction in front of cmpxchg).

Also, try_cmpxchg() implicitly assigns old *ptr value to "old" when
cmpxchg fails. There is no need to re-read the value in the loop.

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Brian Foster <bfoster@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Check for invalid bucket from bucket_gen(), gc_bucket() 2024-06-10T17:17:16+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-06T19:06:22+00:00 9432e90df1b8a544f220fd455b2fa39eed8a535d Turn more asserts into proper recoverable error paths. Reported-by: syzbot+246b47da27f8e7e7d6fb@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Turn more asserts into proper recoverable error paths.

Reported-by: syzbot+246b47da27f8e7e7d6fb@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>