linux.git/fs/bcachefs/error.c, branch v6.10 Linux kernel source tree bcachefs: Fix safe errors by default 2024-06-20T13:13:09+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-19T13:55:48+00:00 33dfafa90285c0873a24d633877d505ab8e3fc20 i.e. the start of automatic self healing: If errors=continue or fix_safe, we now automatically fix simple errors without user intervention. New error action option: fix_safe This replaces the existing errors=ro option, which gets a new slot, i.e. existing errors=ro users now get errors=fix_safe. This is currently only enabled for a limited set of errors - initially just disk accounting; errors we would never not want to fix, and we don't want to require user intervention (i.e. to make sure a bug report gets filed). Errors will still be counted in the superblock, so we (developers) will still know they've been occuring if a bug report gets filed (as bug reports typically include the errors superblock section). Eventually we'll be enabling this for a much wider set of errors, after we've done thorough error injection testing. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
i.e. the start of automatic self healing:

If errors=continue or fix_safe, we now automatically fix simple errors
without user intervention.

New error action option: fix_safe

This replaces the existing errors=ro option, which gets a new slot, i.e.
existing errors=ro users now get errors=fix_safe.

This is currently only enabled for a limited set of errors - initially
just disk accounting; errors we would never not want to fix, and we
don't want to require user intervention (i.e. to make sure a bug report
gets filed).

Errors will still be counted in the superblock, so we (developers) will
still know they've been occuring if a bug report gets filed (as bug
reports typically include the errors superblock section).

Eventually we'll be enabling this for a much wider set of errors, after
we've done thorough error injection testing.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: allow for custom action in fsck error messages 2024-05-08T21:29:18+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-28T04:39:11+00:00 19391b92947c75267cdacb1acefe8ad0d278a9dd Be more explicit to the user about what we're doing. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Be more explicit to the user about what we're doing.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: On emergency shutdown, print out current journal sequence number 2024-04-01T05:07:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-30T19:59:57+00:00 b3c7fd35c03c17a950737fb56a06b730a7962d28 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Split out recovery_passes.c 2024-04-01T00:36:11+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-24T00:07:46+00:00 d2554263adcb4041f3608cb7476f102fda036ccc We've grown a fair amount of code for managing recovery passes; tracking which ones we're running, which ones need to be run, and flagging in the superblock which ones need to be run on the next recovery. So it's worth splitting out into its own file, this code is pretty different from the code in recovery.c. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We've grown a fair amount of code for managing recovery passes; tracking
which ones we're running, which ones need to be run, and flagging in the
superblock which ones need to be run on the next recovery.

So it's worth splitting out into its own file, this code is pretty
different from the code in recovery.c.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Kill more -EIO error codes 2024-03-14T01:22:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-06T22:24:18+00:00 52946d828aac5bc8e20665a8434f87740fad03e3 This converts -EIOs related to btree node errors to private error codes, which will help with some ongoing debugging by giving us better error messages. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This converts -EIOs related to btree node errors to private error codes,
which will help with some ongoing debugging by giving us better error
messages.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Don't autofix errors we can't fix 2024-01-06T04:24:20+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-04T01:34:46+00:00 a64a37338d49a79647d332f1f510daafffeab4ad Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Online fsck can now fix errors 2024-01-06T04:24:20+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-01T00:41:45+00:00 d55ddf6e7a81e1e72b2f73c3cca836a6961c68af BCH_FS_fsck_done -> BCH_FS_fsck_running; set when we might be fixing fsck errors. Also; set fix_errors to ask by default when fsck is running. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
BCH_FS_fsck_done -> BCH_FS_fsck_running; set when we might be fixing
fsck errors. Also; set fix_errors to ask by default when fsck is
running.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: factor out thread_with_file, thread_with_stdio 2024-01-06T04:24:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-31T15:04:54+00:00 96f37eabe7a5cb4746f369e959f935be464950be thread_with_stdio now knows how to handle input - fsck can now prompt to fix errors. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
thread_with_stdio now knows how to handle input - fsck can now prompt to
fix errors.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: convert bch_fs_flags to x-macro 2024-01-01T16:47:38+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-26T22:05:02+00:00 3c471b65889aa22d6ba4f8e3d2e5006bb70fdb58 Now we can print out filesystem flags in sysfs, useful for debugging various "what's my filesystem doing" issues. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Now we can print out filesystem flags in sysfs, useful for debugging
various "what's my filesystem doing" issues.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch_sb.recovery_passes_required 2024-01-01T16:47:07+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-29T20:15:14+00:00 8b16413cda7c46d47f8071165b3071f8a9369199 Add two new superblock fields. Since the main section of the superblock is now fully, we have to add a new variable length section for them - bch_sb_field_ext. - recovery_passes_requried: recovery passes that must be run on the next mount - errors_silent: errors that will be silently fixed These are to improve upgrading and dwongrading: these fields won't be cleared until after recovery successfully completes, so there won't be any issues with crashing partway through an upgrade or a downgrade. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Add two new superblock fields. Since the main section of the superblock
is now fully, we have to add a new variable length section for them -
bch_sb_field_ext.

 - recovery_passes_requried: recovery passes that must be run on the
   next mount
 - errors_silent: errors that will be silently fixed

These are to improve upgrading and dwongrading: these fields won't be
cleared until after recovery successfully completes, so there won't be
any issues with crashing partway through an upgrade or a downgrade.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>