linux.git/fs/bcachefs/btree_write_buffer.c, branch v6.10 Linux kernel source tree bcachefs: bch2_btree_write_buffer_maybe_flush() 2024-06-29T22:34:52+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-29T22:32:01+00:00 92e1c29ae803f85d2f50b4450becb258acae4311 Add a new helper for checking references to write buffer btrees, where we need a flush before we definitively know we have an inconsistency. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Add a new helper for checking references to write buffer btrees, where
we need a flush before we definitively know we have an inconsistency.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: iter/update/trigger/str_hash flag cleanup 2024-05-08T21:29:18+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-07T22:05:34+00:00 5dd8c60e1e044816d789098ce2454a130e06b03d Combine iter/update/trigger/str_hash flags into a single enum, and x-macroize them for a to_text() function later. These flags are all for a specific iter/key/update context, so it makes sense to group them together - iter/update/trigger flags were already given distinct bits, this cleans up and unifies that handling. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Combine iter/update/trigger/str_hash flags into a single enum, and
x-macroize them for a to_text() function later.

These flags are all for a specific iter/key/update context, so it makes
sense to group them together - iter/update/trigger flags were already
given distinct bits, this cleans up and unifies that handling.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix btree node merging on write buffer btrees 2024-04-14T02:49:25+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-27T03:42:34+00:00 86dbf8c566417afd62087ecd3bedcf84f91ee4e4 The btree write buffer flush fastpath that avoids the main transaction commit path had the unfortunate side effect of not doing btree node merging. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
The btree write buffer flush fastpath that avoids the main transaction
commit path had the unfortunate side effect of not doing btree node
merging.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix journal pins in btree write buffer 2024-04-01T00:36:10+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-22T08:01:27+00:00 8aad8e1f659fcea1b24072e816e434e4cd12382d btree write buffer flush has two phases - in natural key order, which is more efficient but may fail - then in journal order The journal order flush was assuming that keys were still correctly ordered by journal sequence number - but due to coalescing by the previous phase, we need an additional sort. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
btree write buffer flush has two phases
 - in natural key order, which is more efficient but may fail
 - then in journal order

The journal order flush was assuming that keys were still correctly
ordered by journal sequence number - but due to coalescing by the
previous phase, we need an additional sort.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Improve bch2_fatal_error() 2024-03-18T04:24:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-18T01:51:19+00:00 3ed94062e3801e3fd9924ccd54b607abf58cc223 error messages should always include __func__ Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
error messages should always include __func__

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: jset_entry for loops declare loop iter 2024-03-14T01:22:25+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-24T03:46:35+00:00 0b5961b0d8a499100bd90a70075a23f875f1ddf6 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix journal_buf bitfield accesses 2024-03-14T01:22:25+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-17T22:54:39+00:00 d9290c9931e4c2ff27b13209610521681418e194 All jounal_buf bitfield updates must happen under the journal lock - perhaps we should just switch these to atomic bit flags. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
All jounal_buf bitfield updates must happen under the journal lock -
perhaps we should just switch these to atomic bit flags.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Prep work for variable size btree node buffers 2024-01-21T18:27:10+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-16T18:29:59+00:00 ec4edd7b9d2038a97e0ba3fad8fc8492b0d12d35 bcachefs btree nodes are big - typically 256k - and btree roots are pinned in memory. As we're now up to 18 btrees, we now have significant memory overhead in mostly empty btree roots. And in the future we're going to start enforcing that certain btree node boundaries exist, to solve lock contention issues - analagous to XFS's AGIs. Thus, we need to start allocating smaller btree node buffers when we can. This patch changes code that refers to the filesystem constant c->opts.btree_node_size to refer to the btree node buffer size - btree_buf_bytes() - where appropriate. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bcachefs btree nodes are big - typically 256k - and btree roots are
pinned in memory. As we're now up to 18 btrees, we now have significant
memory overhead in mostly empty btree roots.

And in the future we're going to start enforcing that certain btree node
boundaries exist, to solve lock contention issues - analagous to XFS's
AGIs.

Thus, we need to start allocating smaller btree node buffers when we
can. This patch changes code that refers to the filesystem constant
c->opts.btree_node_size to refer to the btree node buffer size -
btree_buf_bytes() - where appropriate.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: __bch2_journal_key_to_wb -> bch2_journal_key_to_wb_slowpath 2024-01-06T04:24:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-28T01:26:30+00:00 8feaebb0ae8882d688b4152c5d693e248d17e623 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: wb_key_cmp -> wb_key_ref_cmp 2024-01-06T04:24:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-27T23:23:34+00:00 371650143d173ccdddc07405d5ee55e390a86921 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>