linux.git/fs/bcachefs/btree_trans_commit.c, branch v6.7

bcachefs: Kill journal pre-reservations

2023-11-15T04:44:43+00:00

This deletes the complicated and somewhat expensive journal
pre-reservation machinery in favor of just using journal watermarks:
when the journal is more than half full, we run journal reclaim more
aggressively, and when the journal is more than 3/4s full we only allow
journal reclaim to get new journal reservations.

Signed-off-by: Kent Overstreet

bcachefs: Make sure to drop/retake btree locks before reclaim

2023-11-14T02:45:03+00:00

We really don't want to be invoking memory reclaim with btree locks
held: even aside from (solvable, but tricky) recursion issues, it can
cause painful to diagnose performance edge cases.

This fixes a recently reported issue in btree_key_can_insert_cached().

Signed-off-by: Kent Overstreet 
Reported-by: Mateusz Guzik 
Fixes: https://lore.kernel.org/linux-bcachefs/CAGudoHEsb_hGRMeWeXh+UF6po0qQuuq_NKSEo+s1sEb6bDLjpA@mail.gmail.com/T/

bcachefs: btree_trans->write_locked

2023-11-14T02:45:03+00:00

As prep work for the next patch to fix a key cache reclaim issue, we
need to start tracking whether we're currently holding write locks - so
that we can release and retake the before calling into memory reclaim.

Signed-off-by: Kent Overstreet

bcachefs: rebalance_work btree is not a snapshots btree

2023-11-05T02:19:13+00:00

rebalance_work entries may refer to entries in the extents btree, which
is a snapshots btree, or they may also refer to entries in the reflink
btree, which is not.

Hence rebalance_work keys may use the snapshot field but it's not
required to be nonzero - add a new btree flag to reflect this.

Signed-off-by: Kent Overstreet

bcachefs: Fix build errors with gcc 10

2023-11-04T18:17:11+00:00

gcc 10 seems to complain about array bounds in situations where gcc 11
does not - curious.

This unfortunately requires adding some casts for now; we may
investigate getting rid of our __u64 _data[] VLA in a future patch so
that our start[0] members can be VLAs.

Reported-by: John Stoffel 
Signed-off-by: Kent Overstreet

bcachefs: Don't downgrade locks on transaction restart

2023-11-02T01:11:08+00:00

We should only be downgrading locks on success - otherwise, our
transaction restarts won't be getting the correct locks and we'll
livelock.

Signed-off-by: Kent Overstreet

bcachefs: All triggers are BTREE_TRIGGER_WANTS_OLD_AND_NEW

2023-10-31T16:18:37+00:00

Upcoming rebalance_work btree will require extent triggers to be
BTREE_TRIGGER_WANTS_OLD_AND_NEW - so to reduce potential confusion,
let's just make all triggers BTREE_TRIGGER_WANTS_OLD_AND_NEW.

Signed-off-by: Kent Overstreet

bcachefs: Fix btree_node_type enum

2023-10-31T16:18:37+00:00

More forwards compatibility fixups: having BKEY_TYPE_btree at the end of
the enum conflicts with unnkown btree IDs, this shifts BKEY_TYPE_btree
to slot 0 and fixes things up accordingly.

Signed-off-by: Kent Overstreet

bcachefs: bch2_btree_id_str()

2023-10-31T16:18:37+00:00

Since we can run with unknown btree IDs, we can't directly index btree
IDs into fixed size arrays.

Signed-off-by: Kent Overstreet

bcachefs: Always check for invalid bkeys in main commit path

2023-10-22T21:10:15+00:00

Previously, we would check for invalid bkeys at transaction commit time,
but only if CONFIG_BCACHEFS_DEBUG=y.

This check is important enough to always be on - it appears there's been
corruption making it into the journal that would have been caught by it.

Signed-off-by: Kent Overstreet