linux.git/fs/bcachefs/btree_node_scan.c, branch v6.16

bcachefs: btree_node_scan: don't re-read before initializing found_btree_node

2025-07-20T17:26:08+00:00

If the btree node is encrypted, this caused us to initialize
found_btree_node from the encrypted header.

Signed-off-by: Kent Overstreet

bcachefs: btree node scan no longer uses btree cache

2025-07-05T16:42:41+00:00

Previously, btree node scan used the btree node cache to check if btree
nodes were readable, but this is subject to interference from threads
scanning different devices trying to read the same node - and more
critically, nodes that we already attempted and failed to read before
kicking off scan.

Instead, we now allocate a 'struct btree' that does not live in the
btree node cache, and call bch2_btree_node_read_done() directly.

Cc: Nikita Ofitserov 
Reviewed-by: Nikita Ofitserov 
Reported-and-tested-by: Edoardo Codeglia 
Signed-off-by: Kent Overstreet

bcachefs: Ensure btree node scan runs before checking for scanned nodes

2025-06-26T04:01:16+00:00

Previously, calling bch2_btree_has_scanned_nodes() when btree node
scan hadn't actually run would erroniously return false - causing us to
think a btree was entirely gone.

This fixes a 6.16 regression from moving the scheduling of btree node
scan out of bch2_btree_lost_data() (fixing the bug where we'd schedule
it persistently in the superblock) and only scheduling it when
check_toploogy() is asking for scanned btree nodes.

Signed-off-by: Kent Overstreet

bcachefs: add cond_resched() to handle_overwrites()

2025-06-04T20:45:41+00:00

Fix soft lockup warnings in btree nodes can.

Signed-off-by: Kent Overstreet

bcachefs: bch2_run_explicit_recovery_pass() cleanup

2025-05-22T00:15:04+00:00

Consolidate the run_explicit_recovery_pass() interfaces by adding a
flags parameter; this will also let us add a RUN_RECOVERY_PASS_ratelimit
flag.

Signed-off-by: Kent Overstreet

bcachefs: bch_dev.io_ref -> enumerated_ref

2025-05-22T00:14:28+00:00

Convert device IO refs to enumerated_refs, for easier debugging of
refcount issues.

Simple conversion: enumerate all users and convert to the new helpers.

Signed-off-by: Kent Overstreet

bcachefs: print_str_as_lines() -> print_str()

2025-05-22T00:14:18+00:00

bch2_print_string_as_lines() is a low level helper that allows messages
longer than 1k to be printed without truncation.

But we should always be printing with the helpers that take a filesystem
object, if we're in fsck they direct output to the userspace process
controlling fsck instead of the dmesg log.

Signed-off-by: Kent Overstreet

bcachefs: Use sort_nonatomic() instead of sort()

2025-04-06T23:33:53+00:00

Fixes "task out to lunch" warnings during recovery on large machines
with lots of dirty data in the journal.

Signed-off-by: Kent Overstreet

bcachefs: use library APIs for ChaCha20 and Poly1305

2025-04-06T23:33:53+00:00

Just use the ChaCha20 and Poly1305 libraries instead of the clunky
crypto API.  This is much simpler.  It is also slightly faster, since
the libraries provide more direct access to the same
architecture-optimized ChaCha20 and Poly1305 code.

I've tested that existing encrypted bcachefs filesystems can be continue
to be accessed with this patch applied.

Reviewed-by: Ard Biesheuvel 
Signed-off-by: Eric Biggers 
Signed-off-by: Kent Overstreet

bcachefs: Split up bch_dev.io_ref

2025-04-02T14:24:34+00:00

We now have separate per device io_refs for read and write access.

This fixes a device removal bug where the discard workers were still
running while we're removing alloc info for that device.

It's also a bit of hardening; we no longer allow writes to devices that
are read-only.

Signed-off-by: Kent Overstreet