linux.git/fs/bcachefs/btree_node_scan.c, branch v6.12

bcachefs: Fix null ptr deref in bucket_gen_get()

2024-11-07T21:48:17+00:00

bucket_gen() checks if we're lookup up a valid bucket and returns NULL
otherwise, but bucket_gen_get() was failing to check; other callers were
correct.

Also do a bit of cleanup on callers.

Signed-off-by: Kent Overstreet

bcachefs: add check for btree id against max in try read node

2024-10-09T20:42:53+00:00

Add check for read node's btree_id against BTREE_ID_NR_MAX in
try_read_btree_node to prevent triggering EBUG_ON condition in
bch2_btree_id_root[1].

[1] https://syzkaller.appspot.com/bug?extid=cf7b2215b5d70600ec00

Reported-by: syzbot+cf7b2215b5d70600ec00@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=cf7b2215b5d70600ec00
Fixes: 4409b8081d16 ("bcachefs: Repair pass for scanning for btree nodes")
Signed-off-by: Piotr Zalewski 
Signed-off-by: Kent Overstreet

bcachefs: Fix incorrect IS_ERR_OR_NULL usage

2024-09-28T01:46:34+00:00

Returning a positive integer instead of an error code causes error paths
to become very confused.

Closes: syzbot+c0360e8367d6d8d04a66@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: Make bkey_fsck_err() a wrapper around fsck_err()

2024-08-14T03:00:50+00:00

bkey_fsck_err() was added as an interface that looks like fsck_err(),
but previously all it did was ensure that the appropriate error counter
was incremented in the superblock.

This is a cleanup and bugfix patch that converts it to a wrapper around
fsck_err(). This is needed to fix an issue with the upgrade path to
disk_accounting_v3, where the "silent fix" error list now includes
bkey_fsck errors; fsck_err() handles this in a unified way, and since we
need to change printing of bkey fsck errors from the caller to the inner
bkey_fsck_err() calls, this ends up being a pretty big change.

Als,, rename .invalid() methods to .validate(), for clarity, while we're
changing the function signature anyways (to drop the printbuf argument).

Signed-off-by: Kent Overstreet

bcachefs: btree node scan: fall back to comparing by journal seq

2024-07-14T23:00:16+00:00

highly damaged filesystems, or filesystems that have been damaged and
repair and damaged again, may have sequence numbers we can't fully trust
- which in itself is something we need to debug.

Add a journal_seq fallback so that repair doesn't get stuck.

Signed-off-by: Kent Overstreet

bcachefs: Fix incorrect error handling found_btree_node_is_readable()

2024-06-10T17:17:15+00:00

error handling here is slightly odd, which is why we were accidently
calling evict() on an error pointer

Signed-off-by: Kent Overstreet

bcachefs: btree node scan now fills in sectors_written

2024-04-29T01:34:29+00:00

Signed-off-by: Kent Overstreet

bcachefs: node scan: ignore multiple nodes with same seq if interior

2024-04-16T23:14:00+00:00

Interior nodes are not really needed, when we have to scan - but if this
pops up for leaf nodes we'll need a real heuristic.

Signed-off-by: Kent Overstreet

bcachefs: bch_member.btree_allocated_bitmap

2024-04-15T00:02:11+00:00

This adds a small (64 bit) per-device bitmap that tracks ranges that
have btree nodes, for accelerating btree node scan if it is ever needed.

- New helpers, bch2_dev_btree_bitmap_marked() and
  bch2_dev_bitmap_mark(), for checking and updating the bitmap

- Interior btree update path updates the bitmaps when required

- The check_allocations pass has a new fsck_err check,
  btree_bitmap_not_marked

- New on disk format version, mi_btree_mitmap, which indicates the new
  bitmap is present

- Upgrade table lists the required recovery pass and expected fsck error

- Btree node scan uses the bitmap to skip ranges if we're on the new
  version

Signed-off-by: Kent Overstreet

bcachefs: btree node scan: handle encrypted nodes

2024-04-14T02:48:16+00:00

Signed-off-by: Kent Overstreet