linux.git/fs/bcachefs/btree_cache.c, branch v6.17 Linux kernel source tree bcachefs: Tweak btree cache helpers for use by btree node scan 2025-07-05T03:17:07+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-07-03T22:50:18+00:00 c2b2c7d1da8f26c6db40de2bed142d66e238bd8a btree node scan needs to not use the btree node cache: that causes interference from prior failed reads and parallel workers. Instead we need to allocate btree nodes that don't live in the btree cache, so that we can call bch2_btree_node_read_done() directly. This patch tweaks the low level helpers so they don't touch the btree cache lists. Cc: Nikita Ofitserov <himikof@gmail.com> Reviewed-by: Nikita Ofitserov <himikof@gmail.com> Reported-and-tested-by: Edoardo Codeglia <bcachefs@404.blue> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
btree node scan needs to not use the btree node cache: that causes
interference from prior failed reads and parallel workers.

Instead we need to allocate btree nodes that don't live in the btree
cache, so that we can call bch2_btree_node_read_done() directly.

This patch tweaks the low level helpers so they don't touch the btree
cache lists.

Cc: Nikita Ofitserov <himikof@gmail.com>
Reviewed-by: Nikita Ofitserov <himikof@gmail.com>
Reported-and-tested-by: Edoardo Codeglia <bcachefs@404.blue>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch_err_throw() 2025-06-02T16:16:35+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-28T15:57:50+00:00 09b9c72bd4b77a954123997377665fb30f1d07e1 Add a tracepoint for any time we return an error and unwind. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Add a tracepoint for any time we return an error and unwind.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Reduce usage of recovery.curr_pass 2025-05-22T00:15:03+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-13T21:36:55+00:00 7ed4c14e20be2b113e111ec9fa1803c778e00280 We want recovery.curr_pass to be private to the recovery passes code, for better showing recovery pass status; also, it may rewind and is generally not the correct member to use. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We want recovery.curr_pass to be private to the recovery passes code,
for better showing recovery pass status; also, it may rewind and is
generally not the correct member to use.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: struct bch_fs_recovery 2025-05-22T00:15:03+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-10T22:21:49+00:00 68708efcac711946ffeb1803eb54ebaf44675010 bch_fs has gotten obnoxiously big, let's start organizing thins a bit better. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bch_fs has gotten obnoxiously big, let's start organizing thins a bit
better.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Debug params are now static_keys 2025-05-22T00:14:54+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-10T18:14:06+00:00 284251557562f6e8f0ce439cb52a6b9645b4e9a4 We'd like users to be able to debug without building custom kernels, so this will help us get rid of CONFIG_BCACHEFS_DEBUG, at least for most things. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We'd like users to be able to debug without building custom kernels, so
this will help us get rid of CONFIG_BCACHEFS_DEBUG, at least for most
things.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Kill bch2_trans_unlock_noassert 2025-05-22T00:14:14+00:00 Alan Huang mmpgouride@gmail.com 2025-04-15T05:33:04+00:00 f013b4ca356d37b2cc2e84a096c02dad592b1574 Signed-off-by: Alan Huang <mmpgouride@gmail.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Improve bch2_btree_cache_to_text() 2025-05-22T00:14:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-04-13T11:47:47+00:00 93ac4d5f92fc33dc3ba6a60a66e177ac1f4be032 Make the output slightly clearer, and include a counter for "nodes we couldn't free because we would have gone under our reserve". Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Make the output slightly clearer, and include a counter for "nodes we
couldn't free because we would have gone under our reserve".

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: __btree_node_reclaim_checks() 2025-05-22T00:14:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-04-13T11:45:13+00:00 e50fe14c5430d30c5464ebdaef7d0e9684480aca Factor out a helper so we're not duplicating checks after locking the btree node. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Factor out a helper so we're not duplicating checks after locking the
btree node.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: kill BTREE_CACHE_NOT_FREED_INCREMENT() 2025-05-22T00:14:12+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-04-13T11:42:46+00:00 68aaeb7c8bc8fd82805b5045c606bc5fe00cbea8 Small cleanup, just always increment the counters. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Small cleanup, just always increment the counters.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Don't set btree nodes as accessed on fill 2025-05-14T21:05:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2025-05-13T18:27:01+00:00 19b22d04cd44ded1ea5af7849aec9cbf4021c852 Prevent jobs that do lots of scanning (i.e. evacuatee, scrub) from causing OOMs. The shrinker code seems to be having issues when it doesn't do any freeing because it's just flipping off the acccessed bit - and the accessed bit shouldn't be set on first use anyways. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Prevent jobs that do lots of scanning (i.e. evacuatee, scrub) from
causing OOMs.

The shrinker code seems to be having issues when it doesn't do any
freeing because it's just flipping off the acccessed bit - and the
accessed bit shouldn't be set on first use anyways.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>