linux.git/fs/bcachefs/btree_cache.c, branch v6.11 Linux kernel source tree bcachefs: fix failure to relock in btree_node_fill() 2024-08-22T06:07:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-20T19:04:15+00:00 5dbfc4ef72f15508882aff58c307b8425cf037a8 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: fix failure to relock in bch2_btree_node_mem_alloc() 2024-08-22T06:07:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-19T19:22:55+00:00 3c5d0b72a8e8c19c960e8fefb7463067e58b6bc4 We weren't always so strict about trans->locked state - but now we are, and new assertions are shaking some bugs out. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We weren't always so strict about trans->locked state - but now we are,
and new assertions are shaking some bugs out.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix failure to relock in btree_node_get() 2024-08-22T06:07:22+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-18T19:08:12+00:00 49203a6b9d12bfd1a223a67847a631a78f1cd782 discovered by new trans->locked asserts Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
discovered by new trans->locked asserts

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch2_btree_id_to_text() 2024-07-14T23:00:15+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-07T22:19:39+00:00 11169d9983d55f1550ba2d65e074128dd0373937 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Use try_cmpxchg() family of functions instead of cmpxchg() 2024-07-14T23:00:12+00:00 Uros Bizjak ubizjak@gmail.com 2024-05-23T09:19:26+00:00 68573b936d3fceda9cd5cce3a577e035d19ad426 Use try_cmpxchg() family of functions instead of cmpxchg (*ptr, old, new) == old. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg). Also, try_cmpxchg() implicitly assigns old *ptr value to "old" when cmpxchg fails. There is no need to re-read the value in the loop. No functional change intended. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Cc: Kent Overstreet <kent.overstreet@linux.dev> Cc: Brian Foster <bfoster@redhat.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Use try_cmpxchg() family of functions instead of
cmpxchg (*ptr, old, new) == old. x86 CMPXCHG instruction returns
success in ZF flag, so this change saves a compare after cmpxchg
(and related move instruction in front of cmpxchg).

Also, try_cmpxchg() implicitly assigns old *ptr value to "old" when
cmpxchg fails. There is no need to re-read the value in the loop.

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Brian Foster <bfoster@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Enable automatic shrinking for rhashtables 2024-06-10T17:17:16+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-06T22:56:59+00:00 5ae67abcdfdfa49de84be00320ffe8a669ef674f Since the key cache shrinker walks the rhashtable, a mostly empty rhashtable leads to really nasty reclaim performance issues. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Since the key cache shrinker walks the rhashtable, a mostly empty
rhashtable leads to really nasty reclaim performance issues.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: add counters for failed shrinker reclaim 2024-05-09T20:24:29+00:00 Daniel Hill daniel@gluo.nz 2022-09-30T03:37:15+00:00 bceacfa97ec8b67a76efad2f95899434230b317c This adds distinct counters for every reason the btree node shrinker can fail to free an object - if our shrinker isn't making progress, this will tell us why. Signed-off-by: Daniel Hill <daniel@gluo.nz> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This adds distinct counters for every reason the btree node shrinker can
fail to free an object - if our shrinker isn't making progress, this
will tell us why.

Signed-off-by: Daniel Hill <daniel@gluo.nz>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: for_each_bset() declares loop iter 2024-05-09T20:23:34+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-08T05:42:10+00:00 b6fb4269e707bb410e202fb160c8d7a188ef60f8 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Improve sysfs internal/btree_cache 2024-05-08T21:29:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-05T13:47:53+00:00 e11ecc6133b345a6c5919ae35920c384c6ff6f95 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Run bch2_check_fix_ptrs() via triggers 2024-05-08T21:29:20+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-07T23:07:09+00:00 f40d13f94df744185f99732e89bc8d085729ecc9 Currently, the reflink_p gc trigger does repair as well - turning a reflink_p key into an error key if the reflink_v it points to doesn't exist. This won't work with online check/repair, because the repair path once online will be subject to transaction restarts, but BTREE_TRIGGER_gc is not idempotant - we can't run it multiple times if we get a transaction restart. So we need to split these paths; to do so this patch calls check_fix_ptrs() by a new general path - a new trigger type, BTREE_TRIGGER_check_repair. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Currently, the reflink_p gc trigger does repair as well - turning a
reflink_p key into an error key if the reflink_v it points to doesn't
exist.

This won't work with online check/repair, because the repair path once
online will be subject to transaction restarts, but BTREE_TRIGGER_gc is
not idempotant - we can't run it multiple times if we get a transaction
restart.

So we need to split these paths; to do so this patch calls
check_fix_ptrs() by a new general path - a new trigger type,
BTREE_TRIGGER_check_repair.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>