linux.git/fs/bcachefs/bkey_methods.c, branch v6.9 Linux kernel source tree bcachefs: Guard against unknown k.k->type in __bkey_invalid() 2024-05-06T14:58:17+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-06T02:33:05+00:00 2bb9600d5d4735953c47dd1ee99382c68dd04caa For forwards compatibility we have to allow unknown key types, and only run the checks that make sense against them. Fix a missing guard on k.k->type being known. Reported-by: syzbot+ae4dc916da3ce51f284f@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
For forwards compatibility we have to allow unknown key types, and only
run the checks that make sense against them.

Fix a missing guard on k.k->type being known.

Reported-by: syzbot+ae4dc916da3ce51f284f@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Interior known are required to have known key types 2024-04-14T22:01:12+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-14T03:59:28+00:00 d789e9a7d5e2799f4d5425b0b620210d2fcad529 For forwards compatibilyt, we allow bkeys of unknown type in leaf nodes; we can simply ignore metadata we don't understand. Pointers to btree nodes must always be of known types, howwever. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
For forwards compatibilyt, we allow bkeys of unknown type in leaf nodes;
we can simply ignore metadata we don't understand. Pointers to btree
nodes must always be of known types, howwever.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: add missing bounds check in __bch2_bkey_val_invalid() 2024-04-14T22:01:12+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-14T03:59:06+00:00 bceb86be9e970bc6d77bfd1f8e5272d9a2007c16 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Add .val_to_text() for KEY_TYPE_cookie 2024-01-21T18:27:09+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-15T19:15:03+00:00 741c1d3ec1a4a91d0bf18f200e2f0f8bed1ee7e9 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: rebalance_work btree is not a snapshots btree 2023-11-05T02:19:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-03T22:30:08+00:00 d3c7727bb9269c7f7a2f17ef76b9e5c9b8cc8863 rebalance_work entries may refer to entries in the extents btree, which is a snapshots btree, or they may also refer to entries in the reflink btree, which is not. Hence rebalance_work keys may use the snapshot field but it's not required to be nonzero - add a new btree flag to reflect this. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
rebalance_work entries may refer to entries in the extents btree, which
is a snapshots btree, or they may also refer to entries in the reflink
btree, which is not.

Hence rebalance_work keys may use the snapshot field but it's not
required to be nonzero - add a new btree flag to reflect this.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Enumerate fsck errors 2023-11-02T01:11:08+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-10-25T00:44:36+00:00 b65db750e2bb9252321fd54c284edd73c1595a09 This patch adds a superblock error counter for every distinct fsck error; this means that when analyzing filesystems out in the wild we'll be able to see what sorts of inconsistencies are being found and repair, and hence what bugs to look for. Errors validating bkeys are not yet considered distinct fsck errors, but this patch adds a new helper, bkey_fsck_err(), in order to add distinct error types for them as well. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This patch adds a superblock error counter for every distinct fsck
error; this means that when analyzing filesystems out in the wild we'll
be able to see what sorts of inconsistencies are being found and repair,
and hence what bugs to look for.

Errors validating bkeys are not yet considered distinct fsck errors, but
this patch adds a new helper, bkey_fsck_err(), in order to add distinct
error types for them as well.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix btree_node_type enum 2023-10-31T16:18:37+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-10-20T04:01:53+00:00 50a38ca1baace3dc66027ad41393917b05318b14 More forwards compatibility fixups: having BKEY_TYPE_btree at the end of the enum conflicts with unnkown btree IDs, this shifts BKEY_TYPE_btree to slot 0 and fixes things up accordingly. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
More forwards compatibility fixups: having BKEY_TYPE_btree at the end of
the enum conflicts with unnkown btree IDs, this shifts BKEY_TYPE_btree
to slot 0 and fixes things up accordingly.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch2_btree_id_str() 2023-10-31T16:18:37+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-10-20T02:49:08+00:00 88dfe193bd2abd08926c1a0d48b770bb68ac8ccb Since we can run with unknown btree IDs, we can't directly index btree IDs into fixed size arrays. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Since we can run with unknown btree IDs, we can't directly index btree
IDs into fixed size arrays.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix handling of unknown bkey types 2023-10-22T21:10:16+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-09-29T00:24:21+00:00 6929d5e74e473fb8b15875c627f7c5ad963c1889 min_val_size was U8_MAX for unknown key types, causing us to flag any known key as invalid - it should have been 0. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
min_val_size was U8_MAX for unknown key types, causing us to flag any
known key as invalid - it should have been 0.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix W=12 build errors 2023-10-22T21:10:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-09-12T22:41:22+00:00 96dea3d599dbc31f59eb786af2ac5079122beb88 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>