linux.git/fs/bcachefs/backpointers.h, branch v6.10 Linux kernel source tree bcachefs: s/bkey_invalid_flags/bch_validate_flags 2024-05-09T20:23:36+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-08T22:40:42+00:00 65eaf4e24ab6b4809491248e1fed36b8d49c1ea9 We're about to start using bch_validate_flags for superblock section validation - it's no longer bkey specific. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We're about to start using bch_validate_flags for superblock section
validation - it's no longer bkey specific.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Kill bch2_dev_bkey_exists() in backpointer code 2024-05-08T21:29:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-30T20:50:28+00:00 633cf069445d95384d88e9ff40f395c001f8b2b7 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: PTR_BUCKET_POS() now takes bch_dev 2024-05-08T21:29:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-30T23:34:28+00:00 1f2f92ec3f2e5802c2870d0d34ccfa66ae9216ad Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: member helper cleanups 2024-05-08T21:29:19+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-12T03:31:55+00:00 2f724563fcd76166b9922c506078a4afa4e3a90a Some renaming for better consistency bch2_member_exists -> bch2_member_alive bch2_dev_exists -> bch2_member_exists bch2_dev_exsits2 -> bch2_dev_exists bch_dev_locked -> bch2_dev_locked bch_dev_bkey_exists -> bch2_dev_bkey_exists new helper - bch2_dev_safe Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Some renaming for better consistency

bch2_member_exists	-> bch2_member_alive
bch2_dev_exists		-> bch2_member_exists
bch2_dev_exsits2	-> bch2_dev_exists
bch_dev_locked		-> bch2_dev_locked
bch_dev_bkey_exists	-> bch2_dev_bkey_exists

new helper - bch2_dev_safe

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bucket_pos_to_bp_noerror() 2024-05-06T14:58:17+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-03T15:06:54+00:00 a2ddaf965f6a15c316f483e7446fbe3d81fba27c We don't want the assert when we're checking if the backpointer is valid. Reported-by: syzbot+bf7215c0525098e7747a@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We don't want the assert when we're checking if the backpointer is
valid.

Reported-by: syzbot+bf7215c0525098e7747a@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Check for backpointer bucket_offset >= bucket size 2024-04-15T00:02:11+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-14T04:51:48+00:00 f0a73d4fde5b285d94a702026216d9fd1fd2733d Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Kill bch2_bkey_ptr_data_type() 2024-04-01T00:36:11+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-25T23:26:05+00:00 47d2080e30b0b9fc636eba4e74f9e4bdc01543d7 Remove some duplication, and inconsistency between check_fix_ptrs and the main ptr marking paths Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Remove some duplication, and inconsistency between check_fix_ptrs and
the main ptr marking paths

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Prep work for variable size btree node buffers 2024-01-21T18:27:10+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-16T18:29:59+00:00 ec4edd7b9d2038a97e0ba3fad8fc8492b0d12d35 bcachefs btree nodes are big - typically 256k - and btree roots are pinned in memory. As we're now up to 18 btrees, we now have significant memory overhead in mostly empty btree roots. And in the future we're going to start enforcing that certain btree node boundaries exist, to solve lock contention issues - analagous to XFS's AGIs. Thus, we need to start allocating smaller btree node buffers when we can. This patch changes code that refers to the filesystem constant c->opts.btree_node_size to refer to the btree node buffer size - btree_buf_bytes() - where appropriate. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bcachefs btree nodes are big - typically 256k - and btree roots are
pinned in memory. As we're now up to 18 btrees, we now have significant
memory overhead in mostly empty btree roots.

And in the future we're going to start enforcing that certain btree node
boundaries exist, to solve lock contention issues - analagous to XFS's
AGIs.

Thus, we need to start allocating smaller btree node buffers when we
can. This patch changes code that refers to the filesystem constant
c->opts.btree_node_size to refer to the btree node buffer size -
btree_buf_bytes() - where appropriate.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: No need to allocate keys for write buffer 2024-01-01T16:47:38+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-27T01:18:16+00:00 c259bd95d1df6a95d6a78b7f6ebc69c8d172126f Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: use swab40 for bch_backpointer.bucket_offset bitfield 2023-11-05T02:19:13+00:00 Brian Foster bfoster@redhat.com 2023-11-03T13:09:38+00:00 7cb2a7895d94db2979c29e4a20f33b5557c702d5 The bucket_offset field of bch_backpointer is a 40-bit bitfield, but the bch2_backpointer_swab() helper uses swab32. This leads to inconsistency when an on-disk fs is accessed from an opposite endian machine. As it turns out, we already have an internal swab40() helper that is used from the bch_alloc_v4 swab callback. Lift it into the backpointers header file and use it consistently in both places. Signed-off-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
The bucket_offset field of bch_backpointer is a 40-bit bitfield, but the
bch2_backpointer_swab() helper uses swab32. This leads to inconsistency
when an on-disk fs is accessed from an opposite endian machine.

As it turns out, we already have an internal swab40() helper that is
used from the bch_alloc_v4 swab callback. Lift it into the backpointers
header file and use it consistently in both places.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>