linux.git/fs/bcachefs/backpointers.c, branch v6.8 Linux kernel source tree bcachefs: fix backpointer_to_text() when dev does not exist 2024-02-25T01:41:37+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-21T03:16:00+00:00 1f626223a0c8753f8f5c651bf7bfc9e3cfdef7f7 Fixes: Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Fixes:
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Prep work for variable size btree node buffers 2024-01-21T18:27:10+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-16T18:29:59+00:00 ec4edd7b9d2038a97e0ba3fad8fc8492b0d12d35 bcachefs btree nodes are big - typically 256k - and btree roots are pinned in memory. As we're now up to 18 btrees, we now have significant memory overhead in mostly empty btree roots. And in the future we're going to start enforcing that certain btree node boundaries exist, to solve lock contention issues - analagous to XFS's AGIs. Thus, we need to start allocating smaller btree node buffers when we can. This patch changes code that refers to the filesystem constant c->opts.btree_node_size to refer to the btree node buffer size - btree_buf_bytes() - where appropriate. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bcachefs btree nodes are big - typically 256k - and btree roots are
pinned in memory. As we're now up to 18 btrees, we now have significant
memory overhead in mostly empty btree roots.

And in the future we're going to start enforcing that certain btree node
boundaries exist, to solve lock contention issues - analagous to XFS's
AGIs.

Thus, we need to start allocating smaller btree node buffers when we
can. This patch changes code that refers to the filesystem constant
c->opts.btree_node_size to refer to the btree node buffer size -
btree_buf_bytes() - where appropriate.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: extents_to_bp_state 2024-01-21T18:27:10+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-15T23:19:52+00:00 1a5039041b376f545dfc11d89af77cc720217b44 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bkey_and_val_eq() 2024-01-21T18:27:09+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-15T23:08:32+00:00 ba96d36ca526f99b163927115abfec36ef5565e0 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: fsck_err()s don't need to manually check c->sb.version anymore 2024-01-06T04:24:21+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-01-04T04:29:02+00:00 074cbcdaeee433a02d6d0565b936bee0915cc5da Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: for_each_btree_key() now declares loop iter 2024-01-01T16:47:42+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-17T03:30:09+00:00 80eab7a7c2808f84e56ba1f2f1408a16c46d3bdc Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch_err_(fn|msg) check if should print 2024-01-01T16:47:41+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-17T03:43:41+00:00 cf904c8d964fa477cdb83445a03d05e9eda5d65c Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Make backpointer fsck wb flush check more rigorous 2024-01-01T16:47:39+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-30T07:16:19+00:00 a56c61714a2d2e548f5c3792130149159e0657ed backpointers fsck now always runs in rw mode - the btree is being modified while it runs, by e.g. copygc, rebalance, the discard worker, the invalidate worker. We could find a missing backpointer, flush the btree write buffer, and then on the next iteration find a new key at the exact same position - which will most likely need another write buffer flush. Hence, we have to check for an exact match on last_flushed, not just the pos. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
backpointers fsck now always runs in rw mode - the btree is being
modified while it runs, by e.g. copygc, rebalance, the discard worker,
the invalidate worker.

We could find a missing backpointer, flush the btree write buffer, and
then on the next iteration find a new key at the exact same position -
which will most likely need another write buffer flush.

Hence, we have to check for an exact match on last_flushed, not just the
pos.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: On missing backpointer to interior node, flush interior updates 2024-01-01T16:47:39+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-30T07:11:15+00:00 0f64a6daaa4852db735a2df754b37d187f5480d1 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Explicity go RW for fsck 2024-01-01T16:47:39+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-28T21:36:54+00:00 3f0e297d8677c0f4465225ecb6d30d0edbc6e519 This eliminates a lot of BCH_TRANS_COMMIT_lazy_rw flags, and is less error prone. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This eliminates a lot of BCH_TRANS_COMMIT_lazy_rw flags, and is less
error prone.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>