linux.git/fs/bcachefs/backpointers.c, branch v6.7 Linux kernel source tree bcachefs: Fix null ptr deref in bch2_backpointer_get_node() 2023-11-14T02:42:22+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-07T15:30:22+00:00 03cc1e67a243cbb2c85d5fd84f369449f94d4269 bch2_btree_iter_peek_node() can return a NULL ptr (when the tree is shorter than the search depth); handle this with an early return. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Fixes: https://lore.kernel.org/linux-bcachefs/5fc3c28b-c232-4ec7-b0ac-4ef220ddf976@moroto.mountain/T/ Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
bch2_btree_iter_peek_node() can return a NULL ptr (when the tree is
shorter than the search depth); handle this with an early return.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: https://lore.kernel.org/linux-bcachefs/5fc3c28b-c232-4ec7-b0ac-4ef220ddf976@moroto.mountain/T/
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Simplify, fix bch2_backpointer_get_key() 2023-11-05T18:14:22+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-05T00:22:56+00:00 853960d00b4b3df96acbf8e18980896f9115c45c - backpointer_not_found() checks backpointers_no_use_write_buffer, no need to do it inbackpointer_get_key(). - always use backpointer_get_node() for pointers to nodes: backpointer_get_key() was sometimes returning the key from the root node unlocked. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
 - backpointer_not_found() checks backpointers_no_use_write_buffer, no
   need to do it inbackpointer_get_key().

 - always use backpointer_get_node() for pointers to nodes:
   backpointer_get_key() was sometimes returning the key from the root
   node unlocked.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: kill thing_it_points_to arg to backpointer_not_found() 2023-11-05T18:14:22+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-11-05T01:22:34+00:00 daba90f2da9d1a32b94552207f8dad5adb646a5c This can be calculated locally. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This can be calculated locally.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: use swab40 for bch_backpointer.bucket_offset bitfield 2023-11-05T02:19:13+00:00 Brian Foster bfoster@redhat.com 2023-11-03T13:09:38+00:00 7cb2a7895d94db2979c29e4a20f33b5557c702d5 The bucket_offset field of bch_backpointer is a 40-bit bitfield, but the bch2_backpointer_swab() helper uses swab32. This leads to inconsistency when an on-disk fs is accessed from an opposite endian machine. As it turns out, we already have an internal swab40() helper that is used from the bch_alloc_v4 swab callback. Lift it into the backpointers header file and use it consistently in both places. Signed-off-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
The bucket_offset field of bch_backpointer is a 40-bit bitfield, but the
bch2_backpointer_swab() helper uses swab32. This leads to inconsistency
when an on-disk fs is accessed from an opposite endian machine.

As it turns out, we already have an internal swab40() helper that is
used from the bch_alloc_v4 swab callback. Lift it into the backpointers
header file and use it consistently in both places.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Enumerate fsck errors 2023-11-02T01:11:08+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-10-25T00:44:36+00:00 b65db750e2bb9252321fd54c284edd73c1595a09 This patch adds a superblock error counter for every distinct fsck error; this means that when analyzing filesystems out in the wild we'll be able to see what sorts of inconsistencies are being found and repair, and hence what bugs to look for. Errors validating bkeys are not yet considered distinct fsck errors, but this patch adds a new helper, bkey_fsck_err(), in order to add distinct error types for them as well. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
This patch adds a superblock error counter for every distinct fsck
error; this means that when analyzing filesystems out in the wild we'll
be able to see what sorts of inconsistencies are being found and repair,
and hence what bugs to look for.

Errors validating bkeys are not yet considered distinct fsck errors, but
this patch adds a new helper, bkey_fsck_err(), in order to add distinct
error types for them as well.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch2_btree_id_str() 2023-10-31T16:18:37+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-10-20T02:49:08+00:00 88dfe193bd2abd08926c1a0d48b770bb68ac8ccb Since we can run with unknown btree IDs, we can't directly index btree IDs into fixed size arrays. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Since we can run with unknown btree IDs, we can't directly index btree
IDs into fixed size arrays.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix a null ptr deref in bch2_get_alloc_in_memory_pos() 2023-10-22T21:10:15+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-09-22T18:19:52+00:00 82142a5541063addd15c84fcda890675035df8aa Reported-by: smatch Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Reported-by: smatch
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Heap allocate btree_trans 2023-10-22T21:10:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-09-12T21:16:02+00:00 6bd68ec266ad71827ef940151067b67b62fb8fed We're using more stack than we'd like in a number of functions, and btree_trans is the biggest object that we stack allocate. But we have to do a heap allocatation to initialize it anyways, so there's no real downside to heap allocating the entire thing. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We're using more stack than we'd like in a number of functions, and
btree_trans is the biggest object that we stack allocate.

But we have to do a heap allocatation to initialize it anyways, so
there's no real downside to heap allocating the entire thing.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix W=12 build errors 2023-10-22T21:10:13+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-09-12T22:41:22+00:00 96dea3d599dbc31f59eb786af2ac5079122beb88 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix a handful of spelling mistakes in various messages 2023-10-22T21:10:13+00:00 Colin Ian King colin.i.king@gmail.com 2023-09-12T08:25:27+00:00 6bf3766b5211dde53e5a2f88082d71073ea6e7df There are several spelling mistakes in error messages. Fix these. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
There are several spelling mistakes in error messages. Fix these.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>