linux.git/fs/bcachefs/alloc_background.c, branch v6.10 Linux kernel source tree bcachefs: add check for missing fragmentation in check_alloc_to_lru_ref() 2024-06-29T22:35:18+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-29T22:35:18+00:00 d39881d2da2a621df49118bfe5b594c7e8099aa6 We need to make sure we're not missing any fragmenation entries in the LRU BTREE after repairing ALLOC BTREE Also, use the new bch2_btree_write_buffer_maybe_flush() helper; this was only working without it before since bucket invalidation (usually) wasn't happening while fsck was running. Co-developed-by: Daniel Hill <daniel@gluo.nz> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We need to make sure we're not missing any fragmenation entries in the
LRU BTREE after repairing ALLOC BTREE

Also, use the new bch2_btree_write_buffer_maybe_flush() helper; this was
only working without it before since bucket invalidation (usually)
wasn't happening while fsck was running.

Co-developed-by: Daniel Hill <daniel@gluo.nz>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Discard, invalidate workers are now per device 2024-06-25T22:47:55+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-23T04:53:44+00:00 64ee1431cc7d11e01a1007ead0afe737781cbbab There's no reason for discards to be single threaded across all devices; this will improve performance on multi device setups. Additionally, making them per-device simplifies the refcounting on bch_dev->io_ref; we now hold it for the duration that the discard path is running, which fixes a race between the discard path and device removal. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
There's no reason for discards to be single threaded across all devices;
this will improve performance on multi device setups.

Additionally, making them per-device simplifies the refcounting on
bch_dev->io_ref; we now hold it for the duration that the discard path
is running, which fixes a race between the discard path and device
removal.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Replace bare EEXIST with private error codes 2024-06-21T14:17:07+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-27T02:52:22+00:00 504794067fc266be5ac170777a94a927a72ac846 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix missing alloc_data_type_set() 2024-06-21T14:17:07+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-20T14:04:35+00:00 f648b6c12b70af9d24a293617102729cee6b7862 Incorrect bucket state transition in the discard path; when incrementing a bucket's generation number that had already been discarded, we were forgetting to check if it should be need_gc_gens, not free. This was caught by the .invalid checks in the transaction commit path, causing us to go emergency read only. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Incorrect bucket state transition in the discard path; when incrementing
a bucket's generation number that had already been discarded, we were
forgetting to check if it should be need_gc_gens, not free.

This was caught by the .invalid checks in the transaction commit path,
causing us to go emergency read only.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Handle cached data LRU wraparound 2024-06-19T22:27:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-17T17:15:16+00:00 2e9940d4a19507deb29b3e05571fcaaed88155e2 We only have 48 bits for the LRU time field, which is insufficient to prevent wraparound. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We only have 48 bits for the LRU time field, which is insufficient to
prevent wraparound.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Guard against overflowing LRU_TIME_BITS 2024-06-19T22:27:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-17T14:06:03+00:00 cff07e2739d81cf33eb2a378a6136eced852b8cb LRUs only have 48 bits for the time field (i.e. LRU order); thus we need overflow checks and guards. Reported-by: syzbot+df3bf3f088dcaa728857@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
LRUs only have 48 bits for the time field (i.e. LRU order); thus we need
overflow checks and guards.

Reported-by: syzbot+df3bf3f088dcaa728857@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Fix a locking bug in the do_discard_fast() path 2024-06-19T22:27:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-17T13:09:52+00:00 3727ca56049d893859b68f70e50092250de79f28 We can't discard a bucket while it's still open; this needs the bucket_is_open_safe() version, which takes the open_buckets lock. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We can't discard a bucket while it's still open; this needs the
bucket_is_open_safe() version, which takes the open_buckets lock.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: Check for invalid bucket from bucket_gen(), gc_bucket() 2024-06-10T17:17:16+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-06T19:06:22+00:00 9432e90df1b8a544f220fd455b2fa39eed8a535d Turn more asserts into proper recoverable error paths. Reported-by: syzbot+246b47da27f8e7e7d6fb@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Turn more asserts into proper recoverable error paths.

Reported-by: syzbot+246b47da27f8e7e7d6fb@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: s/bkey_invalid_flags/bch_validate_flags 2024-05-09T20:23:36+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-05-08T22:40:42+00:00 65eaf4e24ab6b4809491248e1fed36b8d49c1ea9 We're about to start using bch_validate_flags for superblock section validation - it's no longer bkey specific. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
We're about to start using bch_validate_flags for superblock section
validation - it's no longer bkey specific.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
bcachefs: bch2_dev_get_ioref() checks for device not present 2024-05-09T20:23:36+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-04-30T19:37:51+00:00 2c91ab7262e6b08bbc76b83ed1981602fa6ef835 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>