linux.git/fs/aio.c, branch v4.10

aio: fix lock dep warning

2017-01-15T00:31:40+00:00

lockdep reports a warnning. file_start_write/file_end_write only
acquire/release the lock for regular files. So checking the files in aio
side too.

[  453.532141] ------------[ cut here ]------------
[  453.533011] WARNING: CPU: 1 PID: 1298 at ../kernel/locking/lockdep.c:3514 lock_release+0x434/0x670
[  453.533011] DEBUG_LOCKS_WARN_ON(depth <= 0)
[  453.533011] Modules linked in:
[  453.533011] CPU: 1 PID: 1298 Comm: fio Not tainted 4.9.0+ #964
[  453.533011] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.0-1.fc24 04/01/2014
[  453.533011]  ffff8803a24b7a70 ffffffff8196cffb ffff8803a24b7ae8 0000000000000000
[  453.533011]  ffff8803a24b7ab8 ffffffff81091ee1 ffff8803a5dba700 00000dba00000008
[  453.533011]  ffffed0074496f59 ffff8803a5dbaf54 ffff8803ae0f8488 fffffffffffffdef
[  453.533011] Call Trace:
[  453.533011]  [] dump_stack+0x67/0x9c
[  453.533011]  [] __warn+0x111/0x130
[  453.533011]  [] warn_slowpath_fmt+0x97/0xb0
[  453.533011]  [] ? __warn+0x130/0x130
[  453.533011]  [] ? blk_finish_plug+0x29/0x60
[  453.533011]  [] lock_release+0x434/0x670
[  453.533011]  [] ? import_single_range+0xd4/0x110
[  453.533011]  [] ? rw_verify_area+0x65/0x140
[  453.533011]  [] ? aio_write+0x1f6/0x280
[  453.533011]  [] aio_write+0x229/0x280
[  453.533011]  [] ? aio_complete+0x640/0x640
[  453.533011]  [] ? debug_check_no_locks_freed+0x1a0/0x1a0
[  453.533011]  [] ? debug_lockdep_rcu_enabled.part.2+0x1a/0x30
[  453.533011]  [] ? debug_lockdep_rcu_enabled+0x35/0x40
[  453.533011]  [] ? __might_fault+0x7e/0xf0
[  453.533011]  [] do_io_submit+0x94c/0xb10
[  453.533011]  [] ? do_io_submit+0x23e/0xb10
[  453.533011]  [] ? SyS_io_destroy+0x270/0x270
[  453.533011]  [] ? mark_held_locks+0x23/0xc0
[  453.533011]  [] ? trace_hardirqs_on_thunk+0x1a/0x1c
[  453.533011]  [] SyS_io_submit+0x10/0x20
[  453.533011]  [] entry_SYSCALL_64_fastpath+0x18/0xad
[  453.533011]  [] ? trace_hardirqs_off_caller+0xc0/0x110
[  453.533011] ---[ end trace b2fbe664d1cc0082 ]---

Cc: Dmitry Monakhov 
Cc: Jan Kara 
Cc: Christoph Hellwig 
Cc: Al Viro 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Shaohua Li 
Signed-off-by: Al Viro

ktime: Get rid of the union

2016-12-25T16:21:22+00:00

ktime is a union because the initial implementation stored the time in
scalar nanoseconds on 64 bit machine and in a endianess optimized timespec
variant for 32bit machines. The Y2038 cleanup removed the timespec variant
and switched everything to scalar nanoseconds. The union remained, but
become completely pointless.

Get rid of the union and just keep ktime_t as simple typedef of type s64.

The conversion was done with coccinelle and some manual mopping up.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra

Replace with globally

2016-12-24T19:46:01+00:00

This was entirely automated, using the script by Al:

  PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*'
  sed -i -e "s!$PATT!#include !" \
        $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h)

to do the replacement at the end of the merge window.

Requested-by: Al Viro 
Signed-off-by: Linus Torvalds

move aio compat to fs/aio.c

2016-12-23T03:58:37+00:00

... and fix the minor buglet in compat io_submit() - native one
kills ioctx as cleanup when put_user() fails.  Get rid of
bogus compat_... in !CONFIG_AIO case, while we are at it - they
should simply fail with ENOSYS, same as for native counterparts.

Signed-off-by: Al Viro

don't open-code file_inode()

2016-12-04T23:29:28+00:00

Signed-off-by: Al Viro

aio: fix freeze protection of aio writes

2016-10-30T17:09:42+00:00

Currently we dropped freeze protection of aio writes just after IO was
submitted. Thus aio write could be in flight while the filesystem was
frozen and that could result in unexpected situation like aio completion
wanting to convert extent type on frozen filesystem. Testcase from
Dmitry triggering this is like:

for ((i=0;i<60;i++));do fsfreeze -f /mnt ;sleep 1;fsfreeze -u /mnt;done &
fio --bs=4k --ioengine=libaio --iodepth=128 --size=1g --direct=1 \
    --runtime=60 --filename=/mnt/file --name=rand-write --rw=randwrite

Fix the problem by dropping freeze protection only once IO is completed
in aio_complete().

Reported-by: Dmitry Monakhov 
Signed-off-by: Jan Kara 
[hch: forward ported on top of various VFS and aio changes]
Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

fs: remove aio_run_iocb

2016-10-30T17:09:42+00:00

Pass the ABI iocb structure to aio_setup_rw and let it handle the
non-vectored I/O case as well.  With that and a new helper for the AIO
return value handling we can now define new aio_read and aio_write
helpers that implement reads and writes in a self-contained way without
duplicating too much code.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

fs: remove the never implemented aio_fsync file operation

2016-10-30T17:09:42+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

aio: hold an extra file reference over AIO read/write operations

2016-10-30T17:09:42+00:00

Otherwise we might dereference an already freed file and/or inode
when aio_complete is called before we return from the read_iter or
write_iter method.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

fs/aio.c: eliminate redundant loads in put_aio_ring_file

2016-09-28T01:45:46+00:00

Using a local variable we can prevent gcc from reloading
aio_ring_file->f_inode->i_mapping twice, eliminating 2x2 dependent
loads.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Al Viro