linux.git/fs/afs/security.c, branch v4.11

afs: security: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

2017-03-16T16:27:45+00:00

The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Signed-off-by: Andreea-Cristina Bernat 
Signed-off-by: David Howells

afs: Adjust mode bits processing

2017-03-16T16:27:44+00:00

Mode bits for an afs file should not be enforced in the usual
way.

For files, the absence of user bits can restrict file access
with respect to what is granted by the server.

These bits apply regardless of the owner or the current uid; the
rest of the mode bits (group, other) are ignored.

Signed-off-by: Marc Dionne 
Signed-off-by: David Howells

->permission() sanitizing: don't pass flags to ->permission()

2011-07-20T05:43:24+00:00

not used by the instances anymore.

Signed-off-by: Al Viro

->permission() sanitizing: don't pass flags to generic_permission()

2011-07-20T05:43:22+00:00

redundant; all callers get it duplicated in mask & MAY_NOT_BLOCK and none of
them removes that bit.

Signed-off-by: Al Viro

kill check_acl callback of generic_permission()

2011-07-20T05:43:16+00:00

its value depends only on inode and does not change; we might as
well store it in ->i_op->check_acl and be done with that.

Signed-off-by: Al Viro

fs: provide rcu-walk aware permission i_ops

2011-01-07T06:50:29+00:00

Signed-off-by: Nick Piggin

AFS: Potential null dereference

2010-03-22T16:57:19+00:00

It seems clear from the surrounding code that xpermits is allowed to be
NULL here.

Signed-off-by: Dan Carpenter 
Signed-off-by: David Howells 
Signed-off-by: Linus Torvalds

[PATCH] sanitize ->permission() prototype

2008-07-27T00:53:14+00:00

* kill nameidata * argument; map the 3 bits in ->flags anybody cares
  about to new MAY_... ones and pass with the mask.
* kill redundant gfs2_iop_permission()
* sanitize ecryptfs_permission()
* fix remaining places where ->permission() instances might barf on new
  MAY_... found in mask.

The obvious next target in that direction is permission(9)

folded fix for nfs_permission() breakage from Miklos Szeredi 

Signed-off-by: Al Viro

fs/afs/security.c: fix uninitialized var warning

2008-02-08T17:22:36+00:00

fs/afs/security.c: In function 'afs_permission':
fs/afs/security.c:290: warning: 'access' may be used uninitialized in this function

Cc: David Howells 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)

2008-02-07T16:42:26+00:00

Convert instances of ERR_PTR(PTR_ERR(p)) to ERR_CAST(p) using:

perl -spi -e 's/ERR_PTR[(]PTR_ERR[(](.*)[)][)]/ERR_CAST(\1)/' `grep -rl 'ERR_PTR[(]*PTR_ERR' fs crypto net security`

Signed-off-by: David Howells 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds