linux.git/fs/affs, branch v4.0

fs/affs/file.c: unlock/release page on error

2015-03-25T23:20:31+00:00

When affs_bread_ino() fails, correctly unlock the page and release the
page cache with proper error value.  All write_end() should
unlock/release the page that was locked by write_beg().

Signed-off-by: Taesoo Kim 
Cc: Fabian Frederick 
Cc: Al Viro 
Cc: Geert Uytterhoeven 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/super.c: fix switch indentation

2015-02-17T22:34:53+00:00

Fix checkpatch error:

  ERROR: switch and case should be at the same indent

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/inode.c: remove double extern affs_symlink_inode_operations

2015-02-17T22:34:52+00:00

affs_symlink_inode_operations was already declared extern in affs.h

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/bitmap.c: remove unnecessary return

2015-02-17T22:34:52+00:00

return is not needed at the end of function.

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/amigaffs.c: remove else after return

2015-02-17T22:34:52+00:00

else is unnecessary after return -ENAMETOOLONG

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs: define AFFSNAMEMAX to replace constant use

2015-02-17T22:34:52+00:00

30 was used all over the place to compare name length against
AFFS maximum name length.

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs: use unsigned int for string lengths

2015-02-17T22:34:52+00:00

- Some min() were used with different types.

- Create a new variable in __affs_hash_dentry() to process
  affs_check_name()/min() return

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/super.c: destroy sbi mutex in affs_kill_sb()

2015-02-17T22:34:52+00:00

Call mutex_destroy() on superblock mutex in affs_kill_sb() otherwise mutex
debugging code isn't able to detect that mutex is used after being freed.
(thanks to Jan Kara for complete definition).

Signed-off-by: Fabian Frederick 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/file.c: fix direct IO writes beyond EOF

2015-02-17T22:34:52+00:00

Use the same fallback to normal IO in case of write
operations beyond EOF as fat direct IO. This patch fixes

fsx file -d -Z -r 4096 -w 4096

Report:
  129(129 mod 256): TRUNCATE DOWN from 0x3ff01 to 0xb3f6
  130(130 mod 256): WRITE    0x22000 thru 0x2dfff (0xc000 bytes) HOLE

Thanks to Jan for helping me on this problem.

The ideal solution suggested by Jan Kara would be to use
cont_write_begin() but affs direct_IO shouldn't be used a lot anyway...

Signed-off-by: Fabian Frederick 
Reviewed-by: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/affs/file.c: replace if/BUG by BUG_ON

2015-02-17T22:34:52+00:00

Signed-off-by: Fabian Frederick 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds