linux.git/drivers/xen/gntdev.c, branch v2.6.39

xen-gntdev: unlock on error path in gntdev_mmap()

2011-03-24T14:32:45+00:00

We should unlock here and also decrement the number of &map->users.

Signed-off-by: Dan Carpenter 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: return -EFAULT on copy_to_user failure

2011-03-24T14:32:44+00:00

copy_to_user() returns the amount of data remaining to be copied.  We
want to return a negative error code here.  The upper layers just
call WARN_ON() if we return non-zero so this doesn't change the
behavior.  But returning -EFAULT is still cleaner.

Signed-off-by: Dan Carpenter 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: Use ballooned pages for grant mappings

2011-03-16T14:05:36+00:00

Grant mappings cause the PFN<->MFN mapping to be lost on the pages used
for the mapping. Instead of leaking memory, use pages that have already
been ballooned out and so have no valid mapping. This removes the need
for the bad-page leak workaround as pages are repopulated by the balloon
driver.

Acked-by: Ian Campbell 
Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk

xen: gntdev: fix build warning

2011-03-10T00:59:19+00:00

addr is actually a virtual address so use an unsigned long. Fixes:

  CC      drivers/xen/gntdev.o
drivers/xen/gntdev.c: In function 'map_grant_pages':
drivers/xen/gntdev.c:268: warning: cast from pointer to integer of different size

Reduce the scope of the variable at the same time.

Signed-off-by: Ian Campbell 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: Add cast to pointer

2011-02-23T15:10:34+00:00

Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: Fix incorrect use of zero handle

2011-02-23T15:10:34+00:00

The handle with numeric value 0 is a valid map handle, so it cannot
be used to indicate that a page has not been mapped. Use -1 instead.

Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: prevent using UNMAP_NOTIFY_CLEAR_BYTE on read-only mappings

2011-02-14T19:16:23+00:00

Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: Avoid double-mapping memory

2011-02-14T19:16:22+00:00

If an already-mapped area of the device was mapped into userspace a
second time, a hypercall was incorrectly made to remap the memory
again. Avoid the hypercall on later mmap calls, and fail the mmap call
if a writable mapping is attempted on a read-only range.

Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: Avoid unmapping ranges twice

2011-02-14T19:16:21+00:00

In paravirtualized domains, mn_invl_page or mn_invl_range_start can
unmap a segment of a mapped region without unmapping all pages. When
the region is later released, the pages will be unmapped twice, leading
to an incorrect -EINVAL return.

Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk

xen-gntdev: Use map->vma for checking map validity

2011-02-14T19:16:20+00:00

The is_mapped flag used to be set at the completion of the map operation,
but was not checked in all error paths. Use map->vma instead, which will
now be cleared if the initial grant mapping fails.

Signed-off-by: Daniel De Graaf 
Signed-off-by: Konrad Rzeszutek Wilk