linux.git/drivers/w1, branch v2.6.24

W1: w1_therm.c is flagging 0C etc as invalid

2008-01-22T17:17:48+00:00

The extra rom[0] check is flagging valid temperatures as invalid when
there is already a CRC data transmission check.

w1_therm_read_bin()
	if (rom[8] == crc && rom[0])
		verdict = 1;

Requiring rom[0] to be non-zero will flag as invalid temperature
conversions when the low byte is zero, specifically the temperatures 0C,
16C, 32C, 48C, -16C, -32C, and -48C.

The CRC check is produced on the device for the previous 8 bytes and is
required to ensure the data integrity in transmission.  I don't see why the
extra check for rom[0] being non-zero is in there.  Evgeniy Polyakov didn't
know either.  Just for a check I unplugged the sensor, executed a
temperature conversion, and read the results.  The read was all ff's, which
also failed the CRC, so it doesn't need to protect against a disconnected
sensor.

I have more extensive patches in the work, but these two trivial ones will
do for today.  I would like to hear from people who use the ds2490 USB to
one wire dongle.  1 if you would be willing to test the patches as I
currently only have the one sensor on a short parisite powered wire, 2 if
there is any cheap sources for the ds2490.

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

W1: w1_therm.c ds18b20 decode freezing temperatures correctly

2008-01-22T17:17:48+00:00

Correct the decoding of negative C temperatures.  The code did a binary OR
of two bytes to make a 16 bit value, but assignd it to an integer.  This
caused the value to not be sign extended and to loose that it was a
negative number in the assignment.

Before the patch (in my freezer),
	w1_slave
	ed fe 4b 46 7f ff 03 10 e4 : crc=e4 YES
	ed fe 4b 46 7f ff 03 10 e4 t=4078
With the patch,
	e3 fe 4b 46 7f ff 0d 10 81 : crc=81 YES
	e3 fe 4b 46 7f ff 0d 10 81 t=-17

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

w1: decrement slave counter only in ->release() callback

2008-01-14T16:52:22+00:00

Decrement the slave counter only in ->release() callback instead of both
in ->release() and w1 control.

Patch is based on debug work and preliminary patch made by Henri Laakso.
Henri noticed in debug that this counter becomes negative after w1 slave
device is physically removed.

Signed-off-by: Evgeniy Polyakov 
Cc: Henri Laakso 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

W1: fix memset size error

2007-11-15T02:45:36+00:00

The size argument passed to memset is wrong.

Signed-off-by Li Zefan 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Kbuild/doc: fix links to Documentation files

2007-10-30T21:26:30+00:00

Fix links to files in Documentation/* in various Kconfig files

Signed-off-by: Dirk Hohndel 
Signed-off-by: Linus Torvalds

Add missing newlines to some uses of dev_ messages

2007-10-18T21:37:28+00:00

Found these while looking at printk uses.

Add missing newlines to dev_ uses
Add missing KERN_ prefixes to multiline dev_s
Fixed a wierd->weird spelling typo
Added a newline to a printk

Signed-off-by: Joe Perches 
Cc: "Luck, Tony" 
Cc: Jens Axboe 
Cc: Mark M. Hoffman 
Cc: Roland Dreier 
Cc: Tilman Schmidt 
Cc: David Woodhouse 
Cc: Jeff Garzik 
Cc: Stephen Hemminger 
Cc: Greg KH 
Cc: Jeremy Fitzhardinge 
Cc: Geert Uytterhoeven 
Cc: Alessandro Zummo 
Cc: David Brownell 
Cc: James Smart 
Cc: Andrew Vasquez 
Cc: "Antonino A. Daplas" 
Cc: Evgeniy Polyakov 
Cc: Russell King 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Clean up duplicate includes in drivers/w1/

2007-10-17T15:42:48+00:00

This patch cleans up duplicate includes in
	drivers/w1/

Signed-off-by: Jesper Juhl 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Driver core: change add_uevent_var to use a struct

2007-10-12T21:51:01+00:00

This changes the uevent buffer functions to use a struct instead of a
long list of parameters. It does no longer require the caller to do the
proper buffer termination and size accounting, which is currently wrong
in some places. It fixes a known bug where parts of the uevent
environment are overwritten because of wrong index calculations.

Many thanks to Mathieu Desnoyers for finding bugs and improving the
error handling.

Signed-off-by: Kay Sievers 
Cc: Mathieu Desnoyers 
Cc: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman

missing null termination in one wire uevent

2007-09-25T15:51:04+00:00

Need to null terminate environment.  Found by inspection while looking for
similar problems to platform uevent bug

Signed-off-by: Stephen Hemminger 
Cc: Greg Kroah-Hartman 
Acked-by: Evgeniy Polyakov 
Cc: Andrew Morton 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

w1: fix w1_remove_master_device() searching

2007-08-23T02:52:46+00:00

In case bus master driver provided bogus value as its private data, search
can be incorrect.  Problem found by Adrian Bunk.

Signed-off-by: Evgeniy Polyakov 
Cc: Adrian Bunk 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds