linux.git/drivers/video/fbdev/imxfb.c, branch v6.11 Linux kernel source tree fbdev: imx: Constify lcd_ops 2024-05-03T09:45:46+00:00 Krzysztof Kozlowski krzk@kernel.org 2024-04-24T06:33:43+00:00 8b2d4564eca41581950ee113d41e180db7ea77b9 'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Peng Fan <peng.fan@nxp.com> Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-17-1aaa82b07bc6@kernel.org Signed-off-by: Lee Jones <lee@kernel.org> 
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-17-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
fbdev: imxfb: add '*/' on a separate line in block comment 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:59+00:00 d6dfcdaa4e6e1a7fa99dc068f47f6b7b8c5bb634 Linux kernel coding style uses '*/' on a separate line at the end of multi line comments. Fix block comments by moving '*/' at the end of block comments on a separate line as reported by checkpatch: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Linux kernel coding style uses '*/' on a separate line at the end of
multi line comments.

Fix block comments by moving '*/' at the end of block comments on a
separate line as reported by checkpatch:

WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: use __func__ for function name 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:58+00:00 cb892e5dfed3044974c4f10addbc297966224fe8 Resolve the following warning reported by checkpatch: WARNING: Prefer using '"%s...", __func__' to using 'imxfb_blank', this function's name, in a string Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Resolve the following warning reported by checkpatch:

WARNING: Prefer using '"%s...", __func__' to using 'imxfb_blank', this function's name, in a string

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: Fix style warnings relating to printk() 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:57+00:00 77bf5df43348c45eddf40e06e9a1d417f1d755ef Resolve the following warning reported by checkpatch: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... This made it necessary to move the 'fbi->pdev = pdev' setting to the beginning of the driver's probing. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Resolve the following warning reported by checkpatch:

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

This made it necessary to move the 'fbi->pdev = pdev' setting to the
beginning of the driver's probing.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: add missing spaces after ',' 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:56+00:00 62c82a47cbf8f183db24382bd5fc6e3067cd54c4 Fix the following checkpatch error: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Fix the following checkpatch error:

ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: drop ftrace-like logging 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:55+00:00 f11025059b59fe84880b48b2c3e7cf6894677b93 Resolve the following warning reported by checkpatch: WARNING: Unnecessary ftrace-like logging - prefer using ftrace Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Resolve the following warning reported by checkpatch:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: add missing SPDX tag 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:54+00:00 df937b8bb6044f1763945e00a5c0b29b8cc51ba4 Resolve the following warning reported by checkpatch.pl: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 The patch also removes some license info made redundant by the addition of the SPDX tag. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Resolve the following warning reported by checkpatch.pl:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

The patch also removes some license info made redundant by the addition
of the SPDX tag.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: replace some magic numbers with constants 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:53+00:00 da119a074d776e95a29d5891cf50248553064749 The patch gets rid of magic numbers replacing them with appropriate macros. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
The patch gets rid of magic numbers replacing them with appropriate
macros.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: use BIT, FIELD_{GET,PREP} and GENMASK macros 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:52+00:00 b0e05872f7ae4d005e51952b2f3aca9504452495 Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
Replace opencoded masking and shifting, with BIT(), GENMASK(),
FIELD_GET() and FIELD_PREP() macros.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: move PCR bitfields near their offset 2024-01-11T16:09:01+00:00 Dario Binacchi dario.binacchi@amarulasolutions.com 2023-11-11T10:41:51+00:00 b85f173679900d1f4d1abfc6aa00495ecf1b17e4 The patch moves the bitfields of the PCR register near the macro that defines its offset, just like for all the other registers. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Signed-off-by: Helge Deller <deller@gmx.de> 
The patch moves the bitfields of the PCR register near the macro that
defines its offset, just like for all the other registers.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>