linux.git/drivers/usb, branch v3.15-rc2

uas: fix deadlocky memory allocations

2014-04-16T21:04:59+00:00

There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.

Signed-off-by: Oliver Neukum 
Reviewed-by: Hans de Goede 
Acked-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

uas: fix error handling during scsi_scan()

2014-04-16T21:04:59+00:00

intfdata is set only after scsi_scan(). uas_pre_reset() however
needs intfdata to be valid and will follow the NULL pointer
killing khubd. intfdata must be preemptively set before the
host is registered and undone in the error case.

Signed-off-by: Oliver Neukum 
Reviewed-by: Hans de Goede 
Acked-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

uas: fix GFP_NOIO under spinlock

2014-04-16T21:04:59+00:00

Quote Dan:

The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible" from Nov 7, 2013, leads to the following static
checker warning:

        drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
        error: scheduling with locks held: 'spin_lock:lock'

Some other allocations under spinlock are not caught.
The fix essentially reverts e36e64930cffd94e1c37fdb82f35989384aa946b

Signed-off-by: Oliver Neukum 
Reported-by: Dan Carpenter 
Reviewed-by: Hans de Goede 
Acked-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: Remove Motorola/Telit H24 serial interfaces from ACM driver

2014-04-16T21:03:40+00:00

By specifying NO_UNION_NORMAL the ACM driver does only use the first two
USB interfaces (modem data & control). The AT Port, Diagnostic and NMEA
interfaces are left to the USB serial driver.

Signed-off-by: Michael Ulbricht 
Signed-off-by: Alexander Stein 
Signed-off-by: Oliver Neukum 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: ohci-jz4740: FEAT_POWER is a port feature, not a hub feature

2014-04-16T20:59:41+00:00

Power control of hub ports target the CLEAR_FEATURE and SET_FEATURE
requests to ports, not to the hub. Fix the hub control function to
detect the request correctly.

Signed-off-by: Laurent Pinchart 
Acked-by: Lars-Peter Clausen 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: ohci-jz4740: Fix uninitialized variable warning

2014-04-16T20:59:40+00:00

The ret variable is not initialized in all code paths of the
ohci_jz4740_hub_control function. Fix it.

Signed-off-by: Laurent Pinchart 
Acked-by: Lars-Peter Clausen 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: EHCI: tegra: set txfill_tuning

2014-04-16T20:59:13+00:00

To avoid memory fetch underflows with larger USB transfers, Tegra SoCs
need txfill_tuning's txfifothresh register field set to a non-default
value. Add a custom reset override in order to set this up.

These values are recommended practice for all Tegra chips. However,
I've only noticed practical problems when not setting them this way on
systems using Tegra124. Hence, CC: stable only for recent kernels which
actually support Tegra124.

Cc:  # 3.14+
Signed-off-by: Stephen Warren 
Acked-by: Alan Stern 
Tested-by: Alexandre Courbot 
Signed-off-by: Greg Kroah-Hartman

usb: ehci-platform: Return immediately from suspend if ehci_suspend fails

2014-04-16T20:59:13+00:00

Patch 'b8efdaf USB: EHCI: add check for wakeup/suspend race'
adds a check for possible race between suspend and wakeup interrupt,
and thereby it returns -EBUSY as error code if there's a wakeup
interrupt.
So the platform host controller should not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.

Signed-off-by: Vivek Gautam 
Acked-by: Alan Stern 
Cc: Hauke Mehrtens 
Cc: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-16T20:59:13+00:00

Patch 'b8efdaf USB: EHCI: add check for wakeup/suspend race'
adds a check for possible race between suspend and wakeup interrupt,
and thereby it returns -EBUSY as error code if there's a wakeup
interrupt.
So the platform host controller should not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.

Signed-off-by: Vivek Gautam 
Acked-by: Jingoo Han 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: fix crash during hotplug of PCI USB controller card

2014-04-16T20:59:12+00:00

The code in hcd-pci.c that matches up EHCI controllers with their
companion UHCI or OHCI controllers assumes that the private drvdata
fields don't get set too early.  However, it turns out that this field
gets set by usb_create_hcd(), before hcd-pci expects it, and this can
result in a crash when two controllers are probed in parallel (as can
happen when a new controller card is hotplugged).

The companions_rwsem lock was supposed to prevent this sort of thing,
but usb_create_hcd() is called outside the scope of the rwsem.

A simple solution is to check that the root-hub pointer has been
initialized as well as the drvdata field.  This doesn't happen until
usb_add_hcd() is called; that call and the check are both protected by
the rwsem.

This patch should be applied to stable kernels from 3.10 onward.

Signed-off-by: Alan Stern 
Reported-by: Stefani Seibold 
Tested-by: Stefani Seibold 
CC: 
Signed-off-by: Greg Kroah-Hartman