linux.git/drivers/usb/wusbcore/security.c, branch v3.19

wusb: replace memset by memzero_explicit

2014-12-03T00:15:02+00:00

Memset on a local variable may be removed when it is called just before the
variable goes out of scope.  Using memzero_explicit defeats this
optimization.  A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr/)

// 
@@
identifier x;
type T;
@@

{
... when any
T x[...];
... when any
    when exists
- memset
+ memzero_explicit
  (x,
-0,
  ...)
... when != x
    when strict
}
// 

This change was suggested by Daniel Borkmann 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

usb: wusbcore: fix device disconnect on rekey timeout

2014-09-24T05:06:59+00:00

If three or more wireless devices are connected and two of them
disconnect between 1-3 seconds apart, it can cause the HWA to disconnect
the remaining devices due to failing to see a DN_Alive message from
them.  This happens because when the HWA detects that the first device
is gone, it will attempt to rekey the remaining devices.  If one of the
devices is not responding because it has also been disconnected but not
yet timed out, the synchronous rekey operation running on the wusbd
workqueue can block for up to 5 seconds.  This will prevent the
KEEPALIVE timer from running and DN_Alive messages from being processed
because they are processed by the same workqueue.  This patch moves the
rekey operation to a separate workqueue since it is the only wusb work
item that needs to communicate directly with wireless devices.  The rest
of the WUSB work items either perform no device IO or communicate
directly with the host controller and should not be blocked out by a
non-responding wireless device.

Signed-off-by: Thomas Pugliese 
Signed-off-by: Greg Kroah-Hartman

USB: wusbcore: fix up line break coding style issues in security.c

2014-01-08T00:19:30+00:00

Signed-off-by: Rahul Bedarkar 
Signed-off-by: Greg Kroah-Hartman

USB: wusbcore: correct spelling mistakes in comments and error string

2014-01-08T00:17:41+00:00

Signed-off-by: Rahul Bedarkar 
Acked-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman

Merge branch 3.13-rc4 into usb-next

2013-12-16T16:46:03+00:00

usb: wusbcore: use USB_CTRL_SET_TIMEOUT and USB_CTRL_GET_TIMEOUT

2013-12-09T21:28:48+00:00

Use USB_CTRL_SET_TIMEOUT and USB_CTRL_GET_TIMEOUT for USB control
messages instead of an arbitrary 1s timeout value.  This is particularly
useful for WUSB since in the worst case RF scanario, a WUSB device can
be unresponsive for up to 4s and still be connected.

Signed-off-by: Thomas Pugliese 
Signed-off-by: Greg Kroah-Hartman

usb: wusbcore: fix deadlock in wusbhc_gtk_rekey

2013-12-02T23:21:04+00:00

When multiple wireless USB devices are connected and one of the devices
disconnects, the host will distribute a new group key to the remaining
devicese using wusbhc_gtk_rekey.  wusbhc_gtk_rekey takes the
wusbhc->mutex and holds it while it submits a URB to set the new key.
This causes a deadlock in wa_urb_enqueue when it calls a device lookup
helper function that takes the same lock.

This patch changes wusbhc_gtk_rekey to submit a work item to set the GTK
so that the URB is submitted without holding wusbhc->mutex.

Signed-off-by: Thomas Pugliese 
Signed-off-by: Greg Kroah-Hartman

wusb: Fix potential memory leak in wusb_dev_sec_add()

2012-08-10T19:06:38+00:00

Do not leak memory by updating pointer with potentially NULL realloc return value.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Greg Kroah-Hartman

USB: wusb: Use kcalloc instead of kzalloc to allocate array

2011-12-10T00:18:20+00:00

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

usb: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed

2011-10-31T23:31:25+00:00

With module.h being implicitly everywhere via device.h, the absence
of explicitly including something for EXPORT_SYMBOL went unnoticed.
Since we are heading to fix things up and clean module.h from the
device.h file, we need to explicitly include these files now.

Use the lightweight version of the header that has just THIS_MODULE
and EXPORT_SYMBOL variants.

Signed-off-by: Paul Gortmaker