linux.git/drivers/usb/storage, branch v2.6.33

USB: storage: Remove unneeded SC/PR from unusual_devs.h

2010-02-16T23:11:03+00:00

This patch removes the subclass and protocol entries from a Microtech
entry in unusual_devs.h. This was reported by .

Greg, please apply.

Signed-off-by: Phil Dibowitz 
Signed-off-by: Greg Kroah-Hartman

USB: fix usbstorage for 2770:915d delivers no FAT

2010-01-20T23:24:35+00:00

Resolves kernel.org bug 14914.

Remove entry for 2770:915d (usb digital camera with mass storage
support) from unusual_devs.h. The fix triggered by the entry causes
the file system on the camera to be completely inaccessible (no
partition table, the device is not mountable).

The patch works, but let me clarify a few things about it.  All the
patch does is remove the entry for this device from the
drivers/usb/storage/unusual_devs.h, which is supposed to help with a
problem with the device's reported size (I think).  I'm pretty sure it
was originally added for a reason, so I'm not sure removing it won't
cause other problems to reappear.  Also, I should note that this
unusual_devs.h entry was present (and activating workarounds) in
2.6.29, but in that version everything works fine.  Starting with
2.6.30, things no longer work.

Signed-off-by: Ryan May 
Cc: Rohan Hart 
Signed-off-by: Greg Kroah-Hartman

USB: fix bitmask merge error

2010-01-20T23:24:34+00:00

This patch adds a mask bit which was mistakenly omitted from the
as1311 patch (usb-storage: add BAD_SENSE flag).

Signed-off-by: Alan Stern 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: usb-storage: fix bug in fill_inquiry

2009-12-11T19:55:26+00:00

This patch (as1312) fixes a minor bug in usb-storage.  The
fill_inquiry() routine neglects to pre-load the inquiry data buffer
with spaces.  As a result, if the vendor name is shorter than 8
characters or the product name is shorter than 16, the remainder will
be filled with garbage.

The patch also removes some unnecessary calls to strlen().

Signed-off-by: Alan Stern 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: usb-storage: add BAD_SENSE flag

2009-12-11T19:55:26+00:00

This patch (as1311) fixes a problem in usb-storage: Some devices are
pretty broken when it comes to reporting sense data.  The information
they send back indicates that they have more than 18 bytes of sense
data available, but when the system asks for more than 18 they fail or
hang.  The symptom is that probing fails with multiple resets.

The patch adds a new BAD_SENSE flag to indicate that usb-storage
should never ask for more than 18 bytes of sense data.  The flag can
be set in an unusual_devs entry or via the "quirks=" module parameter,
and it is set automatically whenever a REQUEST SENSE command for more
than 18 bytes fails or times out.

An unusual_devs entry is added for the Agfa photo frame, which uses a
Prolific chip having this bug.

Signed-off-by: Alan Stern 
Tested-by: Daniel Kukula 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: make urb scatter-gather support more generic

2009-12-11T19:55:14+00:00

The WHCI HCD will also support urbs with scatter-gather lists.  Add a
usb_bus field to indicated how many sg list elements are supported by
the HCD.  Use this to decide whether to pass the scatter-list to the HCD
or not.

Make the usb-storage driver use this new field.

Signed-off-by: David Vrabel 
Cc: Alan Stern 
Cc: Sarah Sharp 
Cc: Matthew Dharm 
Signed-off-by: Greg Kroah-Hartman

USB Storage: Make driver less chatty when it finds a new device

2009-12-11T19:55:13+00:00

Use dev_dbg() instead of an unconditional printk(KERN_DEBUG).  This has
two benefits; one is that it identifies the USB device which the messages
related to, and the other is that the messages won't be produced unless
debug is turned on.

Enable the debug messages when CONFIG_USB_STORAGE_DEBUG is set.

Signed-off-by: Matthew Wilcox 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: usb-storage: Associate the name of the interface with the scsi host

2009-12-11T19:55:13+00:00

Instead of reporting "SCSI emulation for USB Mass Storage devices",
report "usb-storage 1-4:1.0".

Signed-off-by: Matthew Wilcox 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb-storage: Workaround devices with bogus sense size

2009-10-14T21:54:44+00:00

usb-storage: Workaround devices with bogus sense size

Some devices, such as Huawei E169, advertise more than the standard
amount of sense data, causing us to set US_FL_SANE_SENSE, assuming
they support it. However, they subsequently fail the request sense
with that size.

This works around it generically. When a sense request fails due to
a device returning an error, US_FL_SANE_SENSE was set, and that sense
request used a larger sense size, we retry with a smaller size before
giving up.

Based on an original patch by Ben Efros 

Signed-off-by: Benjamin Herrenschmidt 
Acked-by: Alan Stern 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: storage: When a device returns no sense data, call it a Hardware Error

2009-10-09T20:52:08+00:00

This patch (as1294) fixes a problem that has plagued users for several
kernel releases.  Some USB mass-storage devices don't return any sense
data when they encounter certain kinds of errors.  The SCSI layer
interprets this to mean that the operation should be retried, and the
same thing happens -- over and over again with no limit.  In some
circumstances (such as when a bus reset occurs) that is the right
thing to do, but not here.

The patch checks for this condition (a transport failure with no sense
data) and changes the result code to DID_ERROR and the sense code to
Hardware Error.  This does get only a limited number of retries, and
so the command will fail relatively quickly instead of getting stuck
in an infinite loop.

This fixes a large part of Bugzilla #14118.

Signed-off-by: Alan Stern 
Tested-by: Mantas Mikulenas 
CC: stable 
Signed-off-by: Greg Kroah-Hartman