linux.git/drivers/usb/serial, branch v4.0-rc2

Merge tag 'usb-serial-3.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial into usb-next

2015-01-31T01:38:43+00:00

USB-serial fixes for v3.19-rc7

Just another device id for cp210x.

Signed-off-by: Johan Hovold

USB: cp210x: add ID for RUGGEDCOM USB Serial Console

2015-01-26T12:37:29+00:00

Added the USB serial console device ID for Siemens Ruggedcom devices
which have a USB port for their serial console.

Signed-off-by: Len Sorensen 
Cc: stable 
Signed-off-by: Johan Hovold

USB: mos7840: remove unused code

2015-01-19T14:58:16+00:00

There is old, unused code that is #defined out by the use of NOTMOS7840
and NOTMCS7840 - these are not defined anywhere.

If NOTMOS7840 is defined then the code will break on null pointer
dereferences on mos7840_port. So the code is currently unused, and
broken anyway, so why not just remove it.

Signed-off-by: Colin Ian King 
Signed-off-by: Johan Hovold

USB: option: clean up blacklist handling

2015-01-19T14:53:53+00:00

Clean up the unnecessarily complicated blacklist implementation
somewhat.

Signed-off-by: Johan Hovold

usb: serial: handle -ENODEV quietly in generic_submit_read_urb

2015-01-12T09:23:54+00:00

If a USB serial device (e.g. /dev/ttyUSB0) with an active program is
unplugged, an -ENODEV (19) error will be produced after it gives up
trying to resubmit a read.

  usb_serial_generic_submit_read_urb - usb_submit_urb failed: -19

Add -ENODEV as one of the permanent errors along with -EPERM that
usb_serial_generic_submit_read_urb() handles quietly without an error.

Signed-off-by: Jeremiah Mahler 
Signed-off-by: Johan Hovold

usb: serial: silence all non-critical read errors

2015-01-12T09:23:35+00:00

If a USB serial device is unplugged while there is an active program
using the device it may spam the logs with -EPROTO (71) messages as it
attempts to retry.

Most serial usb drivers (metro-usb, pl2303, mos7840, ...) only output
these messages for debugging.  The generic driver treats these as
errors.

Change the default output for the generic serial driver from error to
debug to silence these non-critical errors.

Signed-off-by: Jeremiah Mahler 
Signed-off-by: Johan Hovold

USB: console: fix potential use after free

2015-01-10T11:48:21+00:00

Use tty kref to release the fake tty in usb_console_setup to avoid use
after free if the underlying serial driver has acquired a reference.

Note that using the tty destructor release_one_tty requires some more
state to be initialised.

Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Cc: stable 
Signed-off-by: Johan Hovold

USB: console: fix uninitialised ldisc semaphore

2015-01-10T11:48:15+00:00

The USB console currently allocates a temporary fake tty which is used
to pass terminal settings to the underlying serial driver.

The tty struct is not fully initialised, something which can lead to a
lockdep warning (or worse) if a serial driver tries to acquire a
line-discipline reference:

	usbserial: USB Serial support registered for pl2303
	pl2303 1-2.1:1.0: pl2303 converter detected
	usb 1-2.1: pl2303 converter now attached to ttyUSB0
	INFO: trying to register non-static key.
	the code is fine but needs lockdep annotation.
	turning off the locking correctness validator.
	CPU: 0 PID: 68 Comm: udevd Tainted: G        W      3.18.0-rc5 #10
	[] (unwind_backtrace) from [] (show_stack+0x20/0x24)
	[] (show_stack) from [] (dump_stack+0x24/0x28)
	[] (dump_stack) from [] (__lock_acquire+0x1e50/0x2004)
	[] (__lock_acquire) from [] (lock_acquire+0xe4/0x18c)
	[] (lock_acquire) from [] (ldsem_down_read_trylock+0x78/0x90)
	[] (ldsem_down_read_trylock) from [] (tty_ldisc_ref+0x24/0x58)
	[] (tty_ldisc_ref) from [] (usb_serial_handle_dcd_change+0x48/0xe8)
	[] (usb_serial_handle_dcd_change) from [] (pl2303_read_int_callback+0x210/0x220 [pl2303])
	[] (pl2303_read_int_callback [pl2303]) from [] (__usb_hcd_giveback_urb+0x80/0x140)
	[] (__usb_hcd_giveback_urb) from [] (usb_giveback_urb_bh+0x98/0xd4)
	[] (usb_giveback_urb_bh) from [] (tasklet_hi_action+0x9c/0x108)
	[] (tasklet_hi_action) from [] (__do_softirq+0x148/0x42c)
	[] (__do_softirq) from [] (irq_exit+0xd8/0x114)
	[] (irq_exit) from [] (__handle_domain_irq+0x84/0xdc)
	[] (__handle_domain_irq) from [] (omap_intc_handle_irq+0xd8/0xe0)
	[] (omap_intc_handle_irq) from [] (__irq_svc+0x44/0x7c)
	Exception stack(0xdf4e7f08 to 0xdf4e7f50)
	7f00:                   debc0b80 df4e7f5c 00000000 00000000 debc0b80 be8da96c
	7f20: 00000000 00000128 c000fc84 df4e6000 00000000 df4e7f94 00000004 df4e7f50
	7f40: c038ebc0 c038d74c 600f0013 ffffffff
	[] (__irq_svc) from [] (___sys_sendmsg.part.29+0x0/0x2e0)
	[] (___sys_sendmsg.part.29) from [] (SyS_sendmsg+0x18/0x1c)
	[] (SyS_sendmsg) from [] (ret_fast_syscall+0x0/0x48)
	console [ttyUSB0] enabled

Fixes: 36697529b5bb ("tty: Replace ldisc locking with ldisc_sem")
Cc: stable 
Signed-off-by: Johan Hovold

USB: qcserial/option: make AT URCs work for Sierra Wireless MC73xx

2015-01-07T09:12:25+00:00

As has been discussed in the thread starting with
https://lkml.kernel.org/g/549748e9.d+SiJzqu50f1r4lSAL043YSc@arcor.de
Sierra Wireless MC73xx devices with USB VID/PID 0x1199:0x68c0 require the
option_send_setup() code to be used on the USB interface for the AT port
to make unsolicited response codes work correctly. Move these devices from
the qcserial driver where they have been added by commit
70a3615fc07c2330ed7c1e922f3c44f4a67c0762 ("usb: qcserial: add Sierra Wireless
MC73xx") to the option driver and add a MC73xx-specific blacklist
to ensure that
1. the sendsetup code is not used for the DIAG/DM and NMEA interfaces
2. the option driver does not attach to the QMI/network interfaces

Signed-off-by: Reinhard Speyerer 
Cc: stable 
Signed-off-by: Johan Hovold

USB: cp210x: add IDs for CEL USB sticks and MeshWorks devices

2015-01-06T15:26:43+00:00

Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks
devices.

Signed-off-by: David Peterson 
Cc: stable 
Signed-off-by: Johan Hovold