linux.git/drivers/usb/serial, branch v3.7-rc3

USB: mos7840: fix port_probe flow

2012-10-25T18:11:19+00:00

Remove temporary do-while(0) loop used to keep changes minimal.

Fixup indentation, remove some line breaks, and replace break with goto
to maintain flow.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: mos7840: fix port-data memory leak

2012-10-25T18:11:19+00:00

Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.

Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.

Note that the indentation was kept intact using a do-while(0) in order
to facilitate review. A follow-up patch will remove it.

Compile-only tested.

Signed-off-by: Johan Hovold 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: mos7840: remove invalid disconnect handling

2012-10-25T18:11:19+00:00

Remove private zombie flag used to signal disconnect and to prevent
control urb from being submitted from interrupt urb completion handler.

The control urb will not be re-submitted as both the control urb and the
interrupt urb is killed on disconnect.

Signed-off-by: Johan Hovold 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: mos7840: remove NULL-urb submission

2012-10-25T18:11:19+00:00

The private int_urb is never allocated so the submission from the
control completion handler will always fail. Remove this odd piece of
broken code.

Signed-off-by: Johan Hovold 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: qcserial: fix interface-data memory leak in error path

2012-10-25T16:39:38+00:00

Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.

Signed-off-by: Johan Hovold 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: option: fix interface-data memory leak in error path

2012-10-25T16:39:37+00:00

Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.

Note that the usb device id is stored at probe so that it can be used
in attach to determine send-setup blacklisting.

Signed-off-by: Johan Hovold 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: ipw: fix interface-data memory leak in error path

2012-10-25T16:39:37+00:00

Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.

Signed-off-by: Johan Hovold 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: mos7840: fix port-device leak in error path

2012-10-25T16:38:06+00:00

The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.

Cc: 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: mos7840: fix urb leak at release

2012-10-25T16:38:06+00:00

Make sure control urb is freed at release.

Cc: 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: sierra: fix port-data memory leak

2012-10-25T16:37:13+00:00

Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.

Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.

Note also that urb-count for multi-port interfaces has not been changed
even though the usb-serial port number is now determined from the port
and interface minor numbers.

Compile-only tested.

Cc: 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman