linux.git/drivers/usb/serial/visor.c, branch v2.6.34

USB: tty: Prune uses of tty_request_room in the USB layer

2010-03-02T22:55:12+00:00

We have lots of callers that do not need to do this in the first place.
Remove the calls as they both cost CPU and for big buffers can mess up the
multi-page allocation avoidance.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

USB: serial: Remove unnecessary \n's from dbg uses

2010-03-02T22:54:58+00:00

#define dbg adds the newline, messages shouldn't.
Converted dbg("%s", "some string") to dbg("some string")

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

USB: visor: fix DMA buffers on stack

2010-03-02T22:53:57+00:00

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: fix race between unthrottle and completion handler in visor

2009-10-09T20:52:09+00:00

usb:usbserial:visor: fix race between unthrottle and completion handler

visor_unthrottle() mustn't resubmit the URB unconditionally
as the URB may still be running.

the same bug as opticon.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: serial: fix assumption that throttle/unthrottle cannot sleep

2009-10-09T20:52:09+00:00

many serial subdrivers are clearly written as if throttle/unthrottle
cannot sleep. This leads to unneeded atomic submissions. This
patch converts affected drivers in a way to makes very clear that
throttle/unthrottle can sleep. Thus future misdesigns can be avoided
and efficiency and reliability improved.

This removes any such assumption using GFP_KERNEL and spin_lock_irq()

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: visor: fix trivial accounting bug in visor driver

2009-10-09T20:52:08+00:00

usb:usbserial:visor: fix accounting in error case

data not pushed to the tty layer due to an error mustn't be counted

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

tty: USB does not need the filp argument in the drivers

2009-09-19T20:13:26+00:00

And indeed none of them use it. Clean this up as it will make moving to a
standard open method rather easier.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

USB: usb-serial: replace shutdown with disconnect, release

2009-06-16T04:44:47+00:00

This patch (as1254) splits up the shutdown method of usb_serial_driver
into a disconnect and a release method.

The problem is that the usb-serial core was calling shutdown during
disconnect handling, but drivers didn't expect it to be called until
after all the open file references had been closed.  The result was an
oops when the close method tried to use memory that had been
deallocated by shutdown.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

tty: Bring the usb tty port structure into more use

2009-06-11T15:50:56+00:00

This allows us to clean stuff up, but is probably also going to cause
some app breakage with buggy apps as we now implement proper POSIX behaviour
for USB ports matching all the other ports. This does also mean other apps
that break on USB will now work properly.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

USB: removal of tty->low_latency hack dating back to the old serial code

2009-04-23T21:15:29+00:00

This removes tty->low_latency from all USB serial drivers that push
data into the tty layer at hard interrupt context. It's no longer needed
and actually harmful.

Signed-off-by: Oliver Neukum 
Cc: Alan Cox 
Signed-off-by: Greg Kroah-Hartman