linux.git/drivers/usb/serial/quatech2.c, branch v4.9

USB: serial: quatech2: fix use-after-free in probe error path

2016-05-10T07:40:09+00:00

The interface read URB is submitted in attach, but was only unlinked by
the driver at disconnect.

In case of a late probe error (e.g. due to failed minor allocation),
disconnect is never called and we would end up with active URBs for an
unbound interface. This in turn could lead to deallocated memory being
dereferenced in the completion callback.

Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Cc: stable 	# v3.5: 40d04738491d
Signed-off-by: Johan Hovold 
Acked-by: Greg Kroah-Hartman

USB: serial: fix boolinit.cocci warnings

2016-02-28T13:36:53+00:00

Bool initializations should use true and false. Bool tests don't need
comparisons.

Also, use IS_ENABLED instead of ifdef.

Generated by: scripts/coccinelle/misc/boolinit.cocci

Signed-off-by: Mathieu OTHACEHE 
Signed-off-by: Johan Hovold

USB: serial: add missing newlines to dev_ messages.

2014-03-12T19:44:50+00:00

Add missing newlines to dev_ messages.

Also make some messages less verbose where appropriate.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

usb: delete non-required instances of include

2014-01-08T23:01:39+00:00

None of these files are actually using any __init type directives
and hence don't need to include .  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove redundant OOM messages

2014-01-03T20:31:46+00:00

Remove redundant error messages on allocation failures, which have
already been logged.

Cc: Joe Perches 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: quatech2: fix port DMA-buffer allocations

2013-08-14T20:51:02+00:00

Make sure serial DMA-buffers are allocated separately from containing
structure to prevent potential memory corruption on non-cache-coherent
systems.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: quatech2: fix serial DMA-buffer allocations

2013-08-14T20:51:02+00:00

Make sure serial DMA-buffers are allocated separately from containing
structure to prevent potential memory corruption on non-cache-coherent
systems.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: make minor allocation dynamic

2013-06-17T20:30:02+00:00

This moves the allocation of minor device numbers from a static array to
be dynamic, using the idr interface.  This means that you could
potentially get "gaps" in a minor number range for a single USB serial
device with multiple ports, but all should still work properly.

We remove the 'minor' field from the usb_serial structure, as it no
longer makes any sense for it (use the field in the usb_serial_port
structure if you really want to know this number), and take the fact
that we were overloading a number in this field to determine if we had
initialized the minor numbers or not, and just use a flag variable
instead.

Note, we still have the limitation of 255 USB to serial devices in the
system, as that is all we are registering with the TTY layer at this
point in time.

Tested-by: Tobias Winter 
Reviewed-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: ports: add minor and port number

2013-06-10T21:46:40+00:00

The usb_serial_port structure had the number field, which was the minor
number for the port, which almost no one really cared about.  They
really wanted the number of the port within the device, which you had to
subtract from the minor of the parent usb_serial_device structure.  To
clean this up, provide the real minor number of the port, and the number
of the port within the serial device separately, as these numbers might
not be related in the future.

Bonus is that this cleans up a lot of logic in the drivers, and saves
lines overall.

Tested-by: Tobias Winter 
Reviewed-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman 

--
 drivers/staging/serqt_usb2/serqt_usb2.c |   21 +++--------
 drivers/usb/serial/ark3116.c            |    2 -
 drivers/usb/serial/bus.c                |    6 +--
 drivers/usb/serial/console.c            |    2 -
 drivers/usb/serial/cp210x.c             |    2 -
 drivers/usb/serial/cypress_m8.c         |    4 +-
 drivers/usb/serial/digi_acceleport.c    |    6 ---
 drivers/usb/serial/f81232.c             |    5 +-
 drivers/usb/serial/garmin_gps.c         |    6 +--
 drivers/usb/serial/io_edgeport.c        |   58 ++++++++++++--------------------
 drivers/usb/serial/io_ti.c              |   21 ++++-------
 drivers/usb/serial/keyspan.c            |   29 +++++++---------
 drivers/usb/serial/metro-usb.c          |    4 +-
 drivers/usb/serial/mos7720.c            |   37 +++++++++-----------
 drivers/usb/serial/mos7840.c            |   52 +++++++++-------------------
 drivers/usb/serial/opticon.c            |    2 -
 drivers/usb/serial/pl2303.c             |    2 -
 drivers/usb/serial/quatech2.c           |    7 +--
 drivers/usb/serial/sierra.c             |    2 -
 drivers/usb/serial/ti_usb_3410_5052.c   |   10 ++---
 drivers/usb/serial/usb-serial.c         |    7 ++-
 drivers/usb/serial/usb_wwan.c           |    2 -
 drivers/usb/serial/whiteheat.c          |   20 +++++------
 include/linux/usb/serial.h              |    6 ++-
 24 files changed, 133 insertions(+), 180 deletions(-)

USB: quatech2: Staticize local symbol

2013-05-17T00:46:05+00:00

'qt2_process_read_urb' is referenced only in this file. Make it static.

Signed-off-by: Sachin Kamat 
Signed-off-by: Greg Kroah-Hartman