linux.git/drivers/usb/serial/ipw.c, branch v2.6.27

tty-usb-ipw: Coding style

2008-07-22T20:03:24+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Linus Torvalds

usb_serial: API all change

2008-07-22T20:03:22+00:00

USB serial likes to use port->tty back pointers for the real work it does and
to do so without any actual locking. Unfortunately when you consider hangup
events, hangup/parallel reopen or even worse hangup followed by parallel close
events the tty->port and port->tty pointers are not guaranteed to be the same
as port->tty is the active tty while tty->port is the port the tty may or
may not still be attached to.

So rework the entire API to pass the tty struct. For console cases we need
to pass both for now. This shows up multiple drivers that immediately crash
with USB console some of which have been fixed in the process.

Longer term we need a proper tty as console abstraction

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Linus Torvalds

USB: replace remaining FUNCTION occurrences

2008-04-25T04:16:55+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove unneeded number endpoints settings

2008-04-25T04:16:52+00:00

The usb-serial core no longer checks these fields so remove them from
all of the individual drivers.  They will be removed from the usb-serial
core in a patch later in the series.

Signed-off-by: Greg Kroah-Hartman

Add missing newlines to some uses of dev_ messages

2007-10-18T21:37:28+00:00

Found these while looking at printk uses.

Add missing newlines to dev_ uses
Add missing KERN_ prefixes to multiline dev_s
Fixed a wierd->weird spelling typo
Added a newline to a printk

Signed-off-by: Joe Perches 
Cc: "Luck, Tony" 
Cc: Jens Axboe 
Cc: Mark M. Hoffman 
Cc: Roland Dreier 
Cc: Tilman Schmidt 
Cc: David Woodhouse 
Cc: Jeff Garzik 
Cc: Stephen Hemminger 
Cc: Greg KH 
Cc: Jeremy Fitzhardinge 
Cc: Geert Uytterhoeven 
Cc: Alessandro Zummo 
Cc: David Brownell 
Cc: James Smart 
Cc: Andrew Vasquez 
Cc: "Antonino A. Daplas" 
Cc: Evgeniy Polyakov 
Cc: Russell King 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

USB: serial: ipw: clean up urb->status usage

2007-07-12T23:34:33+00:00

This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.


Cc: 
Cc: Roelf Diedericks 
Signed-off-by: Greg Kroah-Hartman

USB serial: add driver pointer to all usb-serial drivers

2007-02-07T23:44:34+00:00

Every usb serial driver should have a pointer to the corresponding usb driver.
So the usb serial core can add a new id not only to the usb serial driver, but
also to the usb driver.

Also the usb drivers of ark3116, mos7720 and mos7840 missed the flag
no_dynamic_id=1. This is added now.

Signed-off-by: Johannes Hölzl 
Signed-off-by: Greg Kroah-Hartman

USB: kmemdup() cleanup in drivers/usb/

2006-12-01T22:23:27+00:00

replace open coded kmemdup() to save some screen space,
and allow inlining/not inlining to be triggered by gcc.

Signed-off-by: Eric Sesterhenn 
Signed-off-by: Greg Kroah-Hartman

IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

2006-10-05T14:10:12+00:00

Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.

The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around.  On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).

Where appropriate, an arch may override the generic storage facility and do
something different with the variable.  On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.

Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions.  Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller.  A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.

I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.

This will affect all archs.  Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

	struct pt_regs *old_regs = set_irq_regs(regs);

And put the old one back at the end:

	set_irq_regs(old_regs);

Don't pass regs through to generic_handle_irq() or __do_IRQ().

In timer_interrupt(), this sort of change will be necessary:

	-	update_process_times(user_mode(regs));
	-	profile_tick(CPU_PROFILING, regs);
	+	update_process_times(user_mode(get_irq_regs()));
	+	profile_tick(CPU_PROFILING);

I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().

Some notes on the interrupt handling in the drivers:

 (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
     the input_dev struct.

 (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
     something different depending on whether it's been supplied with a regs
     pointer or not.

 (*) Various IRQ handler function pointers have been moved to type
     irq_handler_t.

Signed-Off-By: David Howells 
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

usb-serial: possible irq lock inversion (PPP vs. usb/serial)

2006-09-28T22:36:43+00:00

=========================================================
[ INFO: possible irq lock inversion dependency detected ]