linux.git/drivers/usb/serial/generic.c, branch v2.6.25

USB: fix usb-serial generic recursive lock

2008-03-10T23:42:25+00:00

Nobody should be using the generic usb-serial for anything other than
testing. Still, it's not a good thing that it's easy to lock up. There
is a traceback from NMI oopser here:
 https://bugzilla.redhat.com/show_bug.cgi?id=431379

But in short, if a line discipline has a chance to echo anything, input
can loop back a write method. So, don't call tty_flip_buffer_push from
under a lock taken on write path.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

USB: Prepare serial core for autosuspend.

2008-02-01T22:34:51+00:00

Claim the interface for a USB to serial converter when the tty is open,
and release the interface when the tty is closed.

If a driver doesn't provide a resume function, use the generic resume
instead.

Make sure the generic resume function does not submit the URBs if we're
coming back from autosuspend.  On autoresume, we know that the open
function will be called next, which will attempt to submit the URBs.  If
we submit them in the resume function, the open will fail.

This works for:
 - autosuspend
 - suspending with the tty open or closed
 - hibernate with the tty closed

A hibernate (or a suspend that causes the USB subsystem to lose power)
has issues.  If you have the tty open when you hibernate, a new tty will
be created when the device re-enumerates during resume.

Signed-off-by: Sarah Sharp 
Signed-off-by: Greg Kroah-Hartman

usbserial: fix inconsistent lock state

2007-11-28T21:58:34+00:00

In commit acd2a847e7fee7df11817f67dba75a2802793e5d usb_serial_generic_write()
disables interrupts when taking &port->lock which is also taken in
usb_serial_generic_read_bulk_callback() resulting in an inconsistent lock state
due to the latter not disabling interrupts on the local cpu. Fix that by
disabling interrupts in the latter call site also.

Signed-off-by: Borislav Petkov 
Acked-by: Jiri Kosina 
Signed-off-by: Greg Kroah-Hartman

USB: usbserial - fix potential deadlock between write() and IRQ

2007-10-25T19:18:45+00:00

USB: usbserial - fix potential deadlock between write() and IRQ

usb_serial_generic_write() doesn't disable interrupts when taking port->lock,
and could therefore deadlock with usb_serial_generic_read_bulk_callback()
being called from interrupt, taking the same lock. Fix it.

Signed-off-by: Jiri Kosina 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

USB: serial: generic: clean up urb->status usage

2007-07-12T23:34:33+00:00

This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.


Cc: 
Signed-off-by: Greg Kroah-Hartman

USB: generic usb serial to new buffering scheme

2007-07-12T23:29:51+00:00

the generic driver also had its own buffering.

Signed-off-by: Oliver Neukum

USB: suspend support for usb serial

2007-07-12T23:29:44+00:00

this implements generic support for suspend/resume for usb serial.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: fix usb-serial/generic build warning

2007-03-26T21:17:48+00:00

Fix annoying build warning when CONFIG_USB_SERIAL_GENERIC is undefined.

  drivers/usb/serial/generic.c:24: warning: `generic_probe' declared `static' but never defined

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

USB: add flow control to usb-serial generic driver.

2007-02-16T23:32:18+00:00

I added two fields to struct usb_serial_port to keep track of the
throttle state. Other usb-serial drivers typically use private data for
such things, but the generic driver can not really do that because some
of its code is also used by other drivers (which may have their own
private data needs).

As it is, I am not sure that this patch is useful in all scenarios.
It is certainly helpful for low-bandwidth devices that can hold their
data in response to throttling. But for devices that pump data in
real-time as fast as possible (webcam, A/D converter, etc), throttling
may actually cause more data loss.

From: Joris van Rantwijk 
Signed-off-by: Greg Kroah-Hartman

USB serial: add driver pointer to all usb-serial drivers

2007-02-07T23:44:34+00:00

Every usb serial driver should have a pointer to the corresponding usb driver.
So the usb serial core can add a new id not only to the usb serial driver, but
also to the usb driver.

Also the usb drivers of ark3116, mos7720 and mos7840 missed the flag
no_dynamic_id=1. This is added now.

Signed-off-by: Johannes Hölzl 
Signed-off-by: Greg Kroah-Hartman